Re: [Postgres-xc-developers] Query Planning bug ?

[Tomonari K. <kat...@po...>]

Hi Abbas,

(2013/07/19 20:37), Abbas Butt wrote:
 > I had a look at your patch, here is my feedback.
 >
Thank you for the feedback.

 > 1. The problem you reported seems to be caused by a missing 
initialization
 > i.e.
 > query->rtable = NIL;
 > Can you please explain why did the server crash and how it got fixed by
 > having the above initialization statement?
The fix has nothing to do with server crash.
The test environment(2datanodes and 1cordinator) avoids the crash.

 > It would be nice to add some comment on top of this line explaining it.
 >
To be honest, I don't know why my fix solves
my infinite loop problem.
I'll check it deeper and revise the patch.
Please wait for it.

 > 2. I think your patch unintentionally includes a change in
 > contrib/pgxc_ctl/signature.h
 >     Can you please remove it?
 >
OK, I'll do it.

 > 3. Can you please add a test case in say xc_misc.sql?
 >
OK, I'll do it too.

regards,
-------------------
NTT Software Corporation
Tomonari Katsumata