Re: [Postgres-xc-developers] Second argument of initdb is wrong

[鈴木 幸市 <ko...@in...>]

I think this change is for help message and is okay to commit.   Any other comments?

Regards;
---
Koichi Suzuki



On 2013/07/17, at 11:06, Masataka Saito <pg...@gm...> wrote:

> Hello all.
> 
> I found the second argument of initdb has some problems and wrote a patch to fix it.
> 
> First, the documentation and the usage is conflict. The documentation says initdb takes only one argument but usage says that second argument may be NODENAME.
> 
> --------
> Documentation's synopsis:
>  initdb [option...] [--pgdata | -D | --nodename nodename] directory
> 
> $ initdb --help
> initdb initializes a PostgreSQL database cluster.
> 
> Usage:
> initdb [OPTION]... [DATADIR] [NODENAME]
> (snip)
> --------
> 
> Second, giving two argument to initdb makes an error and the error message is also wrong (It says the first argument overflowed is the third argument.)
> 
> --------
> $ initdb datadir nodename
> initdb: too many command-line arguments (first is "(null)")
> Try "initdb --help" for more information.
> 
> $ initdb datadir nodename third
> initdb: too many command-line arguments (first is "third")
> Try "initdb --help" for more information.
> --------
> 
> I speculated that it is bug of the usage and message indication from description of -D and --nodename options in help message.
> 
> Regards.
> <initdb_argument.patch>------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk_______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers