[Postgres-xc-developers] Bug in gtm_backup.c - missing fclose

[Himpich, S. <Ste...@se...>]

Hi there,

while testing 1.1-beta, I ran into a lot of gtm crashes, "too many open files".

I tracked it down to a missing fclose in gtm_backup.c, see diff / patch below.

Greetings,
Stefan Himpich


-------------------------------------------------------------------------------------
--- postgres-xc/src/gtm/main/gtm_backup.c.orig	2013-07-11 16:16:24.751750009 +0200
+++ postgres-xc/src/gtm/main/gtm_backup.c	2013-07-11 16:11:48.707056211 +0200
@@ -27,6 +27,7 @@
 	if (!gtm_need_bkup)
 	{
 		GTM_RWLockRelease(&gtm_bkup_lock);
+		fclose(f);
 		return;
 	}
 	gtm_need_bkup = FALSE;