Re: [Postgres-xc-developers] Minor Fixes

[Koichi S. <koi...@gm...>]

Hi,

I reviewed this thread again.  It may be better to include Matt's patch to
the master after we build REL1_1_STABLE so that he can continue his
Solaris-related work on the master.   As Ashutosh suggested, it will be
less confusing not to include this in REL1_1_STABLE.

Because I'm about to build REL1_1_STABLE for beta work, please let me know
if anybody need Matt's patch in 1.1.

Matt, could you let me know your idea and if you can continue to test XC on
Solaris and declare that XC supports Solaris?

Best Regards;

----------
Koichi Suzuki


2013/6/25 Koichi Suzuki <koi...@gm...>

> I meant that removing "return" statement which returns another function
> return value will be a good refactoring.   Of course, simple return may not
> be removed.
>
>
> ----------
> Koichi Suzuki
>
>
> 2013/6/25 Koichi Suzuki <koi...@gm...>
>
>> Year.   The code is not harmfull at all.    Removing "return" from void
>> functions could be a good refactoring.   Although Solaris is not supported
>> officieally yet, I think it's a good idea to have it in master.   I do hope
>> Matt continues to test XC so that we can tell XC runs on Solaris.
>>
>> Any more inputs?
>>
>> Regardsds;
>>
>> ----------
>> Koichi Suzuki
>>
>>
>> 2013/6/25 Matt Warner <MW...@xi...>
>>
>>> I'll double check but I thought I'd only removed return from functions
>>> declaring void as their return type.
>>>
>>> ?
>>>
>>> Matt
>>>
>>> On Jun 23, 2013, at 6:22 PM, "鈴木 幸市" <ko...@in...> wrote:
>>>
>>> The patch looks reasonable.   One comment: removing "return" for
>>> non-void function will cause Linux gcc warning.  For this case, we need
>>> #ifdef SOLARIS directive.
>>>
>>> You sent two similar patch for proxy_main.c in separate e-mails.   The
>>> later one seems to resolve my comment above.   Although the core team
>>> cannot declare that XC runs on Solaris so far, I think the patch is
>>> reasonable to be included.
>>>
>>> Any other comments?
>>>  ---
>>> Koichi Suzuki
>>>
>>>
>>>
>>> On 2013/06/22, at 1:26, Matt Warner <MW...@XI...> wrote:
>>>
>>> Regarding the other changes, they are specific to Solaris. For example,
>>> in src/backend/pgxc/pool/pgxcnode.c, Solaris requires we include
>>> sys/filio.h. I’ll be searching to see if I can find a macro already defined
>>> for Solaris that I can leverage to #ifdef those Solaris-specific items.*
>>> ***
>>>
>>> Matt****
>>>
>>> *From:* Matt Warner
>>> *Sent:* Friday, June 21, 2013 9:21 AM
>>> *To:* 'Koichi Suzuki'
>>> *Cc:* 'pos...@li...'
>>> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>>> ** **
>>> First patch.****
>>>
>>> *From:* Matt Warner
>>> *Sent:* Friday, June 21, 2013 8:50 AM
>>> *To:* 'Koichi Suzuki'
>>> *Cc:* pos...@li...
>>> *Subject:* RE: [Postgres-xc-developers] Minor Fixes****
>>> ** **
>>> Yes, I’m running XC on Solaris x64.****
>>>
>>> *From:* Koichi Suzuki [mailto:koi...@gm...<koi...@gm...>
>>> ]
>>> *Sent:* Thursday, June 20, 2013 6:34 PM
>>> *To:* Matt Warner
>>> *Cc:* pos...@li...
>>> *Subject:* Re: [Postgres-xc-developers] Minor Fixes****
>>> ** **
>>> Thanks a lot for the patch.   As Michael mentioned, you can send a patch
>>> to developers mailing list.****
>>> ** **
>>> BTW, core team tested current XC on 64bit Intel CentOS and others tested
>>> it against RedHat.    Did you test XC on Solaris?****
>>> ** **
>>> Regards;****
>>>
>>> ****
>>> ----------
>>> Koichi Suzuki****
>>>
>>> ** **
>>> 2013/6/21 Matt Warner <MW...@xi...>****
>>> Just a quick question about contributing fixes. I’ve had to make some
>>> minor changes to get XC compiled on Solaris x64.****
>>> What format would you like to see for the changes? Most are very minor,
>>> such as removing return statements inside void functions (which the Solaris
>>> compiler flags as incorrect since you can’t return from a void function).
>>> ****
>>> Matt****
>>>  ****
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> This SF.net email is sponsored by Windows:
>>>
>>> Build for Windows Store.
>>>
>>> http://p.sf.net/sfu/windows-dev2dev
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers****
>>> ** **
>>>
>>> ------------------------------------------------------------------------------
>>> This SF.net email is sponsored by Windows:
>>>
>>> Build for Windows Store.
>>>
>>>
>>> http://p.sf.net/sfu/windows-dev2dev_______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>>
>>
>