From: Michael P. <mic...@gm...> - 2013-06-21 01:24:46
|
On Fri, Jun 21, 2013 at 5:45 AM, Matt Warner <MW...@xi...> wrote: > Just a quick question about contributing fixes. I’ve had to make some minor > changes to get XC compiled on Solaris x64. > > What format would you like to see for the changes? Most are very minor, such > as removing return statements inside void functions (which the Solaris > compiler flags as incorrect since you can’t return from a void function). Please send patches generated by git that are based on the branch you want to have the fix applied, generally master, such as fixes can be easily backported to other maintenance branches. For the format of the patches, I personally don't really mind, and I am sure that the others will agree, if such patches are generated without context diff as long as they are understandable. Thanks, -- Michael |