Re: [Postgres-xc-developers] Patch for handling Number of tuples processed (3601633)

[Abbas B. <abb...@en...>]

Hi,
Attached please find a revised patch that removes the variable non_fqs_dml
from RemoteQueryState whihc is no longer needed.
With this small change included the patch is good to go.


On Thu, May 23, 2013 at 9:41 AM, Abbas Butt <abb...@en...>wrote:

> I will try to spare some time for this over the weekend.
>
>
> On Thu, May 23, 2013 at 1:09 AM, Ahsan Hadi <ahs...@en...>wrote:
>
>> Abbas,
>> Can you please review this patch this week?
>>
>>
>> On Tue, May 21, 2013 at 3:55 AM, Amit Khandekar <
>> ami...@en...> wrote:
>>
>>> Currently the number of tuples processed is updated in both
>>> HandleCommandComplete and ExecInsert/Update/Delete.
>>>
>>> In HandleCommandComplete() it gets it from the command tag returned from
>>> the datanode i.e. INSERT 0 2, UPDATE 5 and likewise. And then it updates
>>> estate->es_processed. But it does this only for FQS. For non-FQS, in
>>> ExecInsert/Update,  it is just incremented by 1. So if a trigger function
>>> skips one row on datanode, the command tag returned from datanode is INSERT
>>> 0 0. But still in ExecInsert() increments the row count.
>>>
>>> I have added a new field RemoteQueryState->rqs_processed, which is
>>> updated in HandleCommandComplete(). Then it is used in
>>> ExecInsert/Update/Delete() for non-FQS, and in RemoteQueryNext() for FQS.
>>>
>>> While fixing this issue, I see that there seem to be some issue with
>>> combiner->command_complete_count. Currently it checks for consistency of
>>> number of tuples returned for replicated tables, but it does that only for
>>> FQS. Need to completely remove the dependency on whether it's an FQS or
>>> non-FQS DML query. For this, command_complete_count needs to be better
>>> handled. I felt it needs some refactoring which I did not feel good to do
>>> in this release. Currently this field is being updated for each iteration
>>> of FetchTuple by re-using the same combiner for each iteration, whereas it
>>> seems it should be updated only for each node execution, not for each tuple
>>> fetched. I haven't touched this part, but added a TODO, and opened 3613645.
>>>
>>> Added some testcases in existing tests xc_trigship and xc_returning.
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_may
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Ahsan Hadi
>> Snr Director Product Development
>> EnterpriseDB Corporation
>> The Enterprise Postgres Company
>>
>> Phone: +92-51-8358874
>> Mobile: +92-333-5162114
>>
>> Website: www.enterprisedb.com
>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>
>> This e-mail message (and any attachment) is intended for the use of the
>> individual or entity to whom it is addressed. This message contains
>> information from EnterpriseDB Corporation that may be privileged,
>> confidential, or exempt from disclosure under applicable law. If you are
>> not the intended recipient or authorized to receive this for the intended
>> recipient, any use, dissemination, distribution, retention, archiving, or
>> copying of this communication is strictly prohibited. If you have received
>> this e-mail in error, please notify the sender immediately by reply e-mail
>> and delete this message.
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_may
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>