Re: [Postgres-xc-developers] Fix for test case plancache

[Ashutosh B. <ash...@en...>]

Hi Abbas,
The changes you have done affect the general query deparsing logic, which
is used for dumping views. I don't think we should affect that. So, we
should device a way to qualify objects only when it's being done for
RemoteQuery. This might involve a lot of changes esp. in function
definitions.

But, diving deeper into the reasons, we have following two problems which
might (I haven't tested those myself, so this uncertainty; otherwise I am
100% sure) be causing this issue.

One of the reasons why this problem occurs is, we prepare the statements at
the datanodes during first execute command. So, one of the way to
completely solve this problem, is to prepare the statements at the
datanodes at the time of preparing the statement. This is possible if the
target datanodes are known at the time of planning.

The second reason why we see this problem is bug *3607975*. Solving this
bug would solve the regression diff. Can you please attempt it?

Solving reason 2 would be enough to silence the diffs, I guess. Can you
please check?



On Fri, May 17, 2013 at 1:59 PM, Abbas Butt <abb...@en...>wrote:

> Hi,
> Attached please find a fix for test case plancache.
> The test was failing because of the following issue
>
>   create schema s1 create table abc (f1 int) distribute by replication;
>   create schema s2 create table abc (f1 int) distribute by replication;
>   insert into s1.abc values(123);
>   insert into s2.abc values(456);
>   set search_path = s1;
>   prepare p1 as select f1 from abc;
>   set search_path = s2;
>   execute p1;
>
> The last execute must send select f1 from s1.abc to the datanode,
> despite the fact that the current schema has been set to s2.
>
> The solution was to schema qualify remote queries, and for that the
> function generate_relation_name is modified to make sure that relations are
> schema qualified independent of current search path.
>
> Expected outputs of many test cases are changed which makes the size and
> footprint of this patch large.
>
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>
>
> ------------------------------------------------------------------------------
> AlienVault Unified Security Management (USM) platform delivers complete
> security visibility with the essential security capabilities. Easily and
> efficiently configure, manage, and operate all of your security controls
> from a single console and one unified framework. Download a free trial.
> http://p.sf.net/sfu/alienvault_d2d
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company