Re: [Postgres-xc-developers] [Postgres-xc-core] Patch to change name of a couple of variables to more general names

[Abbas B. <abb...@en...>]

On Thu, May 16, 2013 at 12:00 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Abbas,
> I didn't check every place that needed replacement. But it will be caught
> in compilation I guess. I have few comments
> 1. Instead of name has_to_save_cmd_id, can we use save_cmd_id or pass
> command id?
>

Sure we can use the name you suggest.


> 2. The comment against this variable is still the old, it needs to change,
> with the change in the name?
>

I had modified the comment against the variable to add some more lines in
it. I checked that the change is in the patch I sent earlier. Please see if
those changes are sufficient.


>
> Why that member needs to be in Query structure? I think we have discussed
> this when we added the member, but I think, at that time, we added it there
> to avoid last minute complications. Is there a better place?
>

We catch the statements requiring command id exchange in transformation
stage e.g. the WITH query needing command id exchange is caught in
transformUpdateStmt, and this is required in RemoteQuery, so we had decided
that a member is Query structure will be required. Do you see some other
way of conveying this information from transformUpdateStmt to
create_remotequery_plan?


>
>
> On Wed, May 15, 2013 at 5:30 AM, Abbas Butt <abb...@en...>wrote:
>
>> Adding developers mailing list.
>>
>>
>> On Wed, May 15, 2013 at 4:51 AM, Abbas Butt <abb...@en...>wrote:
>>
>>> Hi,
>>> PFA a patch to change names of a couple of variable to more general
>>> names.
>>> This patch touches some of the areas of command id exchange mechanism
>>> between nodes of the cluster and we can use this thread to discuss whether
>>> we need to enable command id exchange in all cases OR not.
>>> For reference see the patch 38b2b79 committed by Michael for the rest of
>>> the details of the mechanism.
>>>
>>> --
>>> *Abbas*
>>>  Architect
>>>
>>> Ph: 92.334.5100153
>>>  Skype ID: gabbasb
>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>
>>
>>
>>
>> --
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>>
>> ------------------------------------------------------------------------------
>> AlienVault Unified Security Management (USM) platform delivers complete
>> security visibility with the essential security capabilities. Easily and
>> efficiently configure, manage, and operate all of your security controls
>> from a single console and one unified framework. Download a free trial.
>> http://p.sf.net/sfu/alienvault_d2d
>> _______________________________________________
>> Postgres-xc-core mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-core
>>
>>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
-- 
*Abbas*
 Architect

Ph: 92.334.5100153
 Skype ID: gabbasb
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community>and
more<http://www.enterprisedb.com/resources-community>