Re: [Postgres-xc-developers] [Postgres-xc-core] Patch to change name of a couple of variables to more general names

[Ashutosh B. <ash...@en...>]

Hi Abbas,
I didn't check every place that needed replacement. But it will be caught
in compilation I guess. I have few comments
1. Instead of name has_to_save_cmd_id, can we use save_cmd_id or pass
command id?
2. The comment against this variable is still the old, it needs to change,
with the change in the name?

Why that member needs to be in Query structure? I think we have discussed
this when we added the member, but I think, at that time, we added it there
to avoid last minute complications. Is there a better place?


On Wed, May 15, 2013 at 5:30 AM, Abbas Butt <abb...@en...>wrote:

> Adding developers mailing list.
>
>
> On Wed, May 15, 2013 at 4:51 AM, Abbas Butt <abb...@en...>wrote:
>
>> Hi,
>> PFA a patch to change names of a couple of variable to more general names.
>> This patch touches some of the areas of command id exchange mechanism
>> between nodes of the cluster and we can use this thread to discuss whether
>> we need to enable command id exchange in all cases OR not.
>> For reference see the patch 38b2b79 committed by Michael for the rest of
>> the details of the mechanism.
>>
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>
>
> ------------------------------------------------------------------------------
> AlienVault Unified Security Management (USM) platform delivers complete
> security visibility with the essential security capabilities. Easily and
> efficiently configure, manage, and operate all of your security controls
> from a single console and one unified framework. Download a free trial.
> http://p.sf.net/sfu/alienvault_d2d
> _______________________________________________
> Postgres-xc-core mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-core
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company