Menu
▾
▴
Re: [Postgres-xc-developers] xc_sort regression failure fix
|
From: Koichi S. <koi...@gm...> - 2013-05-16 05:34:22
|
Thank you Ashutosh. ---------- Koichi Suzuki 2013/5/15 Ashutosh Bapat <ash...@en...> > I committed this patch with some changes. > > > On Wed, May 15, 2013 at 1:28 PM, 鈴木 幸市 <ko...@in...> wrote: > >> Here's third try. >> >> I just left all the explain with (….) option as is and just added >> (verbose on, num_nodes off, nodes off, costs off) option to only one >> explain statement which simply issued explain verbose. >> >> Hope this patch makes sense. >> --- >> Koichi Suzuki >> >> >> >> On 2013/05/15, at 16:33, 鈴木 幸市 <ko...@in...> wrote: >> >> Verbose appeared in the old files. Should I remove all the "verbose"? >> >> Regards; >> --- >> Koichi Suzuki >> >> >> >> On 2013/05/15, at 14:58, Ashutosh Bapat <ash...@en...> >> wrote: >> >> Hi Suzuki-san, >> There are syntax errors in expected output in your patch. The right way >> to invoke EXPLAIN is >> EXPLAIN (verbose, num_nodes off, nodes off, costs off) <query> >> >> In your patch it is used as >> EXPLAIN (verbose, num_nodes off, nodes off, costs off) verbose <query> >> that's why it's giving syntax error. >> >> Also, you have use cost off instead of cost*s* off. >> >> >> On Wed, May 15, 2013 at 11:01 AM, 鈴木 幸市 <ko...@in...> wrote: >> >>> Here's the second fix. >>> >>> Regards; >>> --- >>> Koichi Suzuki >>> >>> >>> >>> >>> On 2013/05/15, at 13:22, Ashutosh Bapat <ash...@en...> >>> wrote: >>> >>> Again in this case, the right fix is to use the standard EXPLAIN form >>> EXPLAIN (verbose, num_nodes off, nodes off, costs off). >>> >>> What I don't understand is how come these changes appeared suddenly? >>> >>> >>> On Wed, May 15, 2013 at 7:59 AM, Koichi Suzuki < >>> koi...@gm...> wrote: >>> >>>> Hello; >>>> >>>> This failure was caused by the following: >>>> >>>> 1. Now FQS pushes down order by and there're no sort at coordinator. >>>> Current regression did not reflect this. >>>> >>>> 2. Regression test changed the datanode name. Current regression did >>>> not reflect this. >>>> >>>> Enclosed is a fix. >>>> >>>> Regards; >>>> ---------- >>>> Koichi Suzuki >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> AlienVault Unified Security Management (USM) platform delivers complete >>>> security visibility with the essential security capabilities. Easily and >>>> efficiently configure, manage, and operate all of your security controls >>>> from a single console and one unified framework. Download a free trial. >>>> http://p.sf.net/sfu/alienvault_d2d >>>> _______________________________________________ >>>> Postgres-xc-developers mailing list >>>> Pos...@li... >>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>>> >>>> >>> >>> >>> -- >>> Best Wishes, >>> Ashutosh Bapat >>> EntepriseDB Corporation >>> The Postgres Database Company >>> ------------------------------------------------------------------------------ >>> AlienVault Unified Security Management (USM) platform delivers complete >>> security visibility with the essential security capabilities. Easily and >>> efficiently configure, manage, and operate all of your security controls >>> from a single console and one unified framework. Download a free trial. >>> >>> http://p.sf.net/sfu/alienvault_d2d_______________________________________________ >>> Postgres-xc-developers mailing list >>> Pos...@li... >>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>> >>> >>> >>> >> >> >> -- >> Best Wishes, >> Ashutosh Bapat >> EntepriseDB Corporation >> The Postgres Database Company >> >> >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform delivers complete >> security visibility with the essential security capabilities. Easily and >> efficiently configure, manage, and operate all of your security controls >> from a single console and one unified framework. Download a free trial. >> >> http://p.sf.net/sfu/alienvault_d2d_______________________________________________ >> Postgres-xc-developers mailing list >> Pos...@li... >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >> >> >> >> > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > Postgres-xc-developers mailing list > Pos...@li... > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers > > |
