From: Koichi S. <koi...@gm...> - 2013-05-09 13:12:25
|
Let me take a look at it. I'd like to review/commit error correction and sequence backup to the slave first. Thank you; ---------- Koichi Suzuki 2013/5/9 Andrei Martsinchyk <and...@gm...> > So maybe attached fix would be acceptable? > It just disables loading of register.node with #if, no code is removed. > > > > 2013/5/9 鈴木 幸市 <ko...@in...> > >> Andrei; >> >> It's wonderful to have these fixes, especially sequence issues, which is >> already in the bug track. >> >> Error messages need some more thought, I think. Node registration will >> be useful in the future. Disabling this could be a quick fix but I think >> we should keep this code. >> >> Thank you very much; >> --- >> Koichi Suzuki >> >> >> >> On 2013/05/09, at 17:15, Andrei Martsinchyk <and...@gm...> >> wrote: >> >> Hi, >> >> We have found few bugs related to GTM standby. >> 1. Missing break; after handling MSG_BKUP_TXN_BEGIN_GETGXID on standby >> was causing error >> "insufficient data left in message". Patch is attached. >> 2. GTM master does not forward information about sequence created to >> standby. Patch is attached, too. >> 3. When restarting cluster with standby, GTM master logs errors >> "Expecting a startup message, but received �". The problem disappears if I >> remove file register.node from the GTM master data directory. Before I >> start looking into details, why GTM needs to save information about running >> nodes? Cluster may be shut down for reconfiguration and information in >> register.node may be out of date. At the same time when nodes connect to >> GTM they deliver actual information. >> So, maybe proper fix for the problem is just to remove code to >> save/restore register.node? >> >> -- >> Andrei Martsinchyk >> >> StormDB - http://www.stormdb.com >> The Database Cloud >> >> <missing_break.patch><create_sequence.patch> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book >> "Graph Databases" is the definitive new guide to graph databases and >> their applications. This 200-page book is written by three acclaimed >> leaders in the field. The early access version is available now. >> Download your free book today! >> http://p.sf.net/sfu/neotech_d2d_may_______________________________________________ >> Postgres-xc-developers mailing list >> Pos...@li... >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >> >> >> > > > -- > Andrei Martsinchyk > > StormDB - http://www.stormdb.com > The Database Cloud > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and > their applications. This 200-page book is written by three acclaimed > leaders in the field. The early access version is available now. > Download your free book today! http://p.sf.net/sfu/neotech_d2d_may > _______________________________________________ > Postgres-xc-developers mailing list > Pos...@li... > https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers > > |