Re: [Postgres-xc-developers] Fix for test case combocid

[Ashutosh B. <ash...@en...>]

Ok, looks good.


On Wed, May 8, 2013 at 4:19 PM, Abbas Butt <abb...@en...>wrote:

> Attached please find a revised patch to fix test case combocid.sql.
> As discussed I have modified the distribution strategy of the table being
> used to replication and found that the test works fine.
>
>
> On Wed, May 8, 2013 at 12:36 PM, Abbas Butt <abb...@en...>wrote:
>
>> Sure, that should work. Let me try.
>>
>>
>> On Wed, May 8, 2013 at 9:18 AM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Is that because the table is distributed? Can you please check if the
>>> table can be replicated (explicitly)?
>>>
>>>
>>> On Wed, May 8, 2013 at 7:12 AM, Abbas Butt <abb...@en...>wrote:
>>>
>>>> You are right, but the problem is that there is a test case in
>>>> combocid.sql that selects ctid
>>>>
>>>> SELECT ctid,cmin,* FROM combocidtest ORDER BY ctid;
>>>>
>>>> The query results in the following output on my machine.
>>>>  ctid  | cmin | foobar
>>>> -------+------+--------
>>>>  (0,1) |   10 |    444
>>>>
>>>> The alternate expected output file has
>>>>  ctid  | cmin | foobar
>>>> -------+------+--------
>>>>  (0,4) |   10 |    444
>>>>
>>>> The test fails on my machine and passes on buildfarm, meaning that the
>>>> query results in (0,4) as ctid on buildfarm.
>>>>
>>>> I therefore thought of resetting ctid, so that we can get (0,1) ctid on
>>>> buildfarm as well as the rest of the setups. But I agree that the
>>>> additional statement in SQL to reset ctid will not be required when
>>>> SAVEPOINTs are implemented.
>>>> What strategy should we then adopt to solve the issue?
>>>>
>>>> On Tue, May 7, 2013 at 4:17 PM, Ashutosh Bapat <
>>>> ash...@en...> wrote:
>>>>
>>>>> Hi Abbas,
>>>>> Since this diff is because we do not support a particular feature, I
>>>>> think, we need up update alternate expected output file (only) with the
>>>>> diff. There is no need to add any new SQL. If we do so, we will have
>>>>> problem in future, when we start supporting SAVEPOINT.
>>>>>
>>>>
>>>> The test case
>>>>
>>>>
>>>>>
>>>>>
>>>>> On Wed, Apr 24, 2013 at 11:12 PM, Abbas Butt <
>>>>> abb...@en...> wrote:
>>>>>
>>>>>> Hi,
>>>>>> The test was failing because ctid was being selected and was not
>>>>>> being reset explicitly.
>>>>>> SAVEPOINT is not implemented yet and the transaction fails because of
>>>>>> that statement.
>>>>>> Due to the failure / rollback the ctid remains incremented and that
>>>>>> incremented value
>>>>>> is dependent on cluster configuration.
>>>>>> The solution is to explicitly reset ctid using truncate statement.
>>>>>>
>>>>>> --
>>>>>> *Abbas*
>>>>>>  Architect
>>>>>>
>>>>>> Ph: 92.334.5100153
>>>>>>  Skype ID: gabbasb
>>>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>>>> *
>>>>>> Follow us on Twitter*
>>>>>> @EnterpriseDB
>>>>>>
>>>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>>>> New Relic is the only SaaS-based application performance monitoring
>>>>>> service
>>>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>>>> and get this awesome Nerd Life shirt!
>>>>>> http://p.sf.net/sfu/newrelic_d2d_apr
>>>>>> _______________________________________________
>>>>>> Postgres-xc-developers mailing list
>>>>>> Pos...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Wishes,
>>>>> Ashutosh Bapat
>>>>> EntepriseDB Corporation
>>>>> The Postgres Database Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> --
>>>> *Abbas*
>>>>  Architect
>>>>
>>>> Ph: 92.334.5100153
>>>>  Skype ID: gabbasb
>>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>>>> *
>>>> Follow us on Twitter*
>>>> @EnterpriseDB
>>>>
>>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>>>
>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> --
>> *Abbas*
>>  Architect
>>
>> Ph: 92.334.5100153
>>  Skype ID: gabbasb
>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>> *
>> Follow us on Twitter*
>> @EnterpriseDB
>>
>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>>
>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company