Re: [Postgres-xc-developers] Truncate with restart identity

[Nikhil S. <ni...@st...>]

Thanks Ashutosh,

Looks ok to me.

Regards,
Nikhils


On Tue, May 7, 2013 at 6:41 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi Nikhil,
> Thanks for the documentation changes. There were few more expected output
> changes to make the test pass with the restriction. I have attached updated
> patch. Please check if the changes are fine. I will commit it after that.
>
>
> On Tue, Apr 30, 2013 at 6:17 PM, Nikhil Sontakke <ni...@st...>wrote:
>
>> There's so much noise in the output that it's kinda difficult to cogently
>> provide a diff for just this case. Anyways I have added the relevant error
>> messages in the output file where RESTART IDENTITY has been used.
>>
>> HTH,
>> Nikhils
>>
>>
>> On Tue, Apr 30, 2013 at 5:39 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Hi Nikhil,
>>> We are trying to clean up the regression, so that there are 0 failures.
>>> This helps to stop new differences creeping in the already failing files.
>>>
>>> If there are features we are not supporting in XC, we are silencing
>>> those failure (and only those failures) by adding alternate outputs.
>>> truncate already has an alternate output file, so you need to change that.
>>>
>>>
>>> On Tue, Apr 30, 2013 at 4:22 PM, Nikhil Sontakke <ni...@st...>wrote:
>>>
>>>>
>>>>
>>>>
>>>>
>>>>> Thanks for the patch. Please include the testcase expected output
>>>>> changes as well.
>>>>>
>>>>>
>>>> This patch already has a lot of other issues. I know I can provide a
>>>> truncate_1.out but I do not see the point.
>>>>
>>>> PFA, patch with the documentation fixed up.
>>>>
>>>> Regards,
>>>> Nikhils
>>>>
>>>>
>>>>>
>>>>> On Thu, Apr 25, 2013 at 2:21 PM, Nikhil Sontakke <ni...@st...>wrote:
>>>>>
>>>>>> PFA, the patch to disallow.
>>>>>>
>>>>>>
>>>>>> >> +1 so far.   Does anybody know how widely it is used?   I hope it
>>>>>> is not used widely.
>>>>>>
>>>>>> Suzuki-san, the user has an option to reset the sequence value
>>>>>> afterwards on his own to circumvent this issue. So it should be ok..
>>>>>>
>>>>>> Regards,
>>>>>> Nikhils
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Apr 25, 2013 at 2:05 PM, Ashutosh Bapat <
>>>>>> ash...@en...> wrote:
>>>>>>
>>>>>>> Can you please provide the patch to restrict the feature?
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Apr 25, 2013 at 2:03 PM, Nikhil Sontakke <
>>>>>>> ni...@st...> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> If it can not be done easily and before release, we need to at
>>>>>>>>> least disable RESTART IDENTITY clause.
>>>>>>>>>
>>>>>>>>> +1 for now..
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Nikhils
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Apr 24, 2013 at 11:45 PM, Nikhil Sontakke <
>>>>>>>>> ni...@st...> wrote:
>>>>>>>>>
>>>>>>>>>> Ok,
>>>>>>>>>> This is not so straight forward. We cannot reset the sequence
>>>>>>>>>> value in the GTM as is. We got to handle the case when the user can
>>>>>>>>>> rollback the truncate operation in which case the old value should still
>>>>>>>>>> hold.
>>>>>>>>>>
>>>>>>>>>> ISTM, we need to add handing code when the commit operation
>>>>>>>>>> actually unlinks the corresponding underlying relfilenode for the earlier
>>>>>>>>>> version of the sequence.
>>>>>>>>>>
>>>>>>>>>> Regards,
>>>>>>>>>> Nikhils
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, Apr 24, 2013 at 7:34 PM, Ashutosh Bapat <
>>>>>>>>>> ash...@en...> wrote:
>>>>>>>>>>
>>>>>>>>>>> Good, that works. This bug is causing testcase truncate to fail.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:53 PM, Nikhil Sontakke <
>>>>>>>>>>> ni...@st...> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Ashutosh,
>>>>>>>>>>>>
>>>>>>>>>>>> By the EOW?
>>>>>>>>>>>>
>>>>>>>>>>>> Regards,
>>>>>>>>>>>> Nikhils
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:49 PM, Ashutosh Bapat <
>>>>>>>>>>>> ash...@en...> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Nikhil,
>>>>>>>>>>>>> Thanks for taking this up?
>>>>>>>>>>>>>
>>>>>>>>>>>>> By when do you think you can provide the patch?
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Wed, Apr 24, 2013 at 6:01 PM, Nikhil Sontakke <
>>>>>>>>>>>>> ni...@st...> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ResetSequence(), the function being called from
>>>>>>>>>>>>>>> ExecuteTruncate() does not send reset message to GTM. It applies sequence
>>>>>>>>>>>>>>> changes locally on the coordinator, which is not enough.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Can someone with relevant experience look into this problem
>>>>>>>>>>>>>>> and provide a fix?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached the testcase and its output showing the bug.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I guess setval() was handled but we forgot to handle reset
>>>>>>>>>>>>>> sequence. I will take this up when I cleanup currval, nextval for negative
>>>>>>>>>>>>>> sequences.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>>> Nikhils
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Best Wishes,
>>>>>>>>>>>>> Ashutosh Bapat
>>>>>>>>>>>>> EntepriseDB Corporation
>>>>>>>>>>>>> The Postgres Database Company
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> StormDB - http://www.stormdb.com
>>>>>>>>>>>> The Database Cloud
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Best Wishes,
>>>>>>>>>>> Ashutosh Bapat
>>>>>>>>>>> EntepriseDB Corporation
>>>>>>>>>>> The Postgres Database Company
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> StormDB - http://www.stormdb.com
>>>>>>>>>> The Database Cloud
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Best Wishes,
>>>>>>>>> Ashutosh Bapat
>>>>>>>>> EntepriseDB Corporation
>>>>>>>>> The Postgres Database Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> StormDB - http://www.stormdb.com
>>>>>>>> The Database Cloud
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Best Wishes,
>>>>>>> Ashutosh Bapat
>>>>>>> EntepriseDB Corporation
>>>>>>> The Postgres Database Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> StormDB - http://www.stormdb.com
>>>>>> The Database Cloud
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Wishes,
>>>>> Ashutosh Bapat
>>>>> EntepriseDB Corporation
>>>>> The Postgres Database Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> StormDB - http://www.stormdb.com
>>>> The Database Cloud
>>>>
>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
StormDB - http://www.stormdb.com
The Database Cloud