From: Ashutosh B. <ash...@en...> - 2013-05-07 06:38:01
|
BTW, fix the bug in separate patch and fix expected outputs in separate patch. On Tue, May 7, 2013 at 11:54 AM, Ashutosh Bapat < ash...@en...> wrote: > Can you please fix the bug then? > > > On Tue, May 7, 2013 at 10:25 AM, Abbas Butt <abb...@en...>wrote: > >> >> >> On Tue, Apr 30, 2013 at 4:57 PM, Ashutosh Bapat < >> ash...@en...> wrote: >> >>> Hi Abbas, >>> I see that the EXPLAIN commands are changed to include the XC specific >>> options. Since the original test is using capital letters everywhere, it's >>> better to maintain that style. >>> >> >> Done. >> >> >>> >>> Please make sure that the changes you have done (explain output) reflect >>> in all the alt. expected output files. >>> >> >> Done. >> >> >>> Can you please see if we can eliminate the alternate expected output >>> files as well? What are the reasons we have to maintain those? >>> >> >> select_views.out and select_view_1.out are maintained by vanilla PG. We >> have added select_views_2.out and It can be removed, however I noticed that >> the test case that was added (Leaky View Scenario) is failing and needs a >> fix. >> >> >>> >>> >>> On Wed, Apr 24, 2013 at 10:59 PM, Abbas Butt < >>> abb...@en...> wrote: >>> >>>> Hi, >>>> The test was failing because some more tests are added in sql file. >>>> >>>> -- >>>> *Abbas* >>>> Architect >>>> >>>> Ph: 92.334.5100153 >>>> Skype ID: gabbasb >>>> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >>>> * >>>> Follow us on Twitter* >>>> @EnterpriseDB >>>> >>>> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Try New Relic Now & We'll Send You this Cool Shirt >>>> New Relic is the only SaaS-based application performance monitoring >>>> service >>>> that delivers powerful full stack analytics. Optimize and monitor your >>>> browser, app, & servers with just a few lines of code. Try New Relic >>>> and get this awesome Nerd Life shirt! >>>> http://p.sf.net/sfu/newrelic_d2d_apr >>>> _______________________________________________ >>>> Postgres-xc-developers mailing list >>>> Pos...@li... >>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers >>>> >>>> >>> >>> >>> -- >>> Best Wishes, >>> Ashutosh Bapat >>> EntepriseDB Corporation >>> The Postgres Database Company >>> >> >> >> >> -- >> -- >> *Abbas* >> Architect >> >> Ph: 92.334.5100153 >> Skype ID: gabbasb >> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/> >> * >> Follow us on Twitter* >> @EnterpriseDB >> >> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community> >> > > > > -- > Best Wishes, > Ashutosh Bapat > EntepriseDB Corporation > The Postgres Database Company > -- Best Wishes, Ashutosh Bapat EntepriseDB Corporation The Postgres Database Company |