Re: [Postgres-xc-developers] Problem with cached plan and aggregates

[Ashutosh B. <ash...@en...>]

Thanks Abbas for quick review. I will take care of inherit and truncate. I
am committing this patch.


On Thu, Apr 25, 2013 at 3:44 PM, Abbas Butt <abb...@en...>wrote:

> The patch fixes the attached test case as well as the one that was failing
> in plpgsql.sql.
>
> Regression before and after the patch shows some diffs in the following
> files
>
> 1. plpgsql - I will take care of those
> 2. truncate &
> 3. Inherit
>
> I have attached the regression.diff before and after the patch.
>
> The patch can be committed , the additional diffs can be taken care of
> separately.
>
> Regards
>
>
> On Wed, Apr 24, 2013 at 3:27 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi All,
>> PFA a patch to fix the cached plan and aggregate problem. Attached is the
>> test code which gave wrong answer.
>>
>>
>> PLpgSQL functions create plans for the queries involved in the functions
>> and cache those. While caching the plan for these queries is copied using
>> copyObject function, which in turn calls _copyAgg for copying the aggregate
>> nodes in the plan. _copyAgg was not copying the skip_trans status, which
>> caused the transitioned results from datanodes to be transitioned again.
>> Hence we got wrong answer for count(*) aggregate.
>>
>> The bug was uncovered from testcase truncate. Someone had just copied the
>> wrong results in alternate expected output file.
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Postgres Database Company
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Postgres-xc-developers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>
>>
>
>
> --
> --
> *Abbas*
>  Architect
>
> Ph: 92.334.5100153
>  Skype ID: gabbasb
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community>and more<http://www.enterprisedb.com/resources-community>
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Postgres Database Company