Re: [Postgres-xc-developers] Truncate with restart identity

[Nikhil S. <ni...@st...>]

If it can not be done easily and before release, we need to at least
> disable RESTART IDENTITY clause.
>
> +1 for now..

Regards,
Nikhils


>
> On Wed, Apr 24, 2013 at 11:45 PM, Nikhil Sontakke <ni...@st...>wrote:
>
>> Ok,
>> This is not so straight forward. We cannot reset the sequence value in
>> the GTM as is. We got to handle the case when the user can rollback the
>> truncate operation in which case the old value should still hold.
>>
>> ISTM, we need to add handing code when the commit operation actually
>> unlinks the corresponding underlying relfilenode for the earlier version of
>> the sequence.
>>
>> Regards,
>> Nikhils
>>
>>
>>
>> On Wed, Apr 24, 2013 at 7:34 PM, Ashutosh Bapat <
>> ash...@en...> wrote:
>>
>>> Good, that works. This bug is causing testcase truncate to fail.
>>>
>>>
>>> On Wed, Apr 24, 2013 at 6:53 PM, Nikhil Sontakke <ni...@st...>wrote:
>>>
>>>> Hi Ashutosh,
>>>>
>>>> By the EOW?
>>>>
>>>> Regards,
>>>> Nikhils
>>>>
>>>>
>>>>
>>>> On Wed, Apr 24, 2013 at 6:49 PM, Ashutosh Bapat <
>>>> ash...@en...> wrote:
>>>>
>>>>> Hi Nikhil,
>>>>> Thanks for taking this up?
>>>>>
>>>>> By when do you think you can provide the patch?
>>>>>
>>>>>
>>>>> On Wed, Apr 24, 2013 at 6:01 PM, Nikhil Sontakke <ni...@st...>wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> ResetSequence(), the function being called from ExecuteTruncate()
>>>>>>> does not send reset message to GTM. It applies sequence changes locally on
>>>>>>> the coordinator, which is not enough.
>>>>>>>
>>>>>>> Can someone with relevant experience look into this problem and
>>>>>>> provide a fix?
>>>>>>>
>>>>>>> I have attached the testcase and its output showing the bug.
>>>>>>>
>>>>>>>
>>>>>> I guess setval() was handled but we forgot to handle reset sequence.
>>>>>> I will take this up when I cleanup currval, nextval for negative sequences.
>>>>>>
>>>>>> Regards,
>>>>>> Nikhils
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Wishes,
>>>>> Ashutosh Bapat
>>>>> EntepriseDB Corporation
>>>>> The Postgres Database Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> StormDB - http://www.stormdb.com
>>>> The Database Cloud
>>>>
>>>
>>>
>>>
>>> --
>>> Best Wishes,
>>> Ashutosh Bapat
>>> EntepriseDB Corporation
>>> The Postgres Database Company
>>>
>>
>>
>>
>> --
>> StormDB - http://www.stormdb.com
>> The Database Cloud
>>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Postgres Database Company
>



-- 
StormDB - http://www.stormdb.com
The Database Cloud