Re: [Postgres-xc-developers] Review for commit 46e2b60a76d7b930a6d5c5abf7bebd4f58559437

[Ashutosh B. <ash...@en...>]

On Wed, Apr 17, 2013 at 8:59 AM, Amit Khandekar <
ami...@en...> wrote:

>
>
> On 10 April 2013 16:00, Ashutosh Bapat <ash...@en...>wrote:
>
>> Hi Amit,
>> In function pgxc_dml_add_qual_to_query(), INT4OID is used as default
>> data-type of system column. Although it serves the purpose for now, if one
>> wants to use this function for some other purpose, INT4OID would not
>> suffice. Either please update the prologue of function to mention that
>> system columns of INT4 type or accept type of system column as parameter.
>> Also, the name of the function doesn't reflect the restricted purpose the
>> function serves. It is too generic.
>>
>
> This function is neither created by the trigger changes nor is affected by
> them. So this change should not be done here.
>

Can you please open a bug and assign it to Abbas. It looks to be coming
from Abbas's work.


>
>
>>
>>
>> In this commit, I see following comment,
>> 191 +        * Beware, the ordering of ctid and node_id is important !
>> ctid should
>> 192 +        * be followed by node_id, not vice-versa, so as to be
>> consistent with
>> 193 +        * the data row to be generated while binding the parameters
>> for the
>> 194 +        * update statement.
>>
>> Is there a way, throught code,  to link the parameters added to query and
>> those bound at the time of execution? If it's not possible right now, can
>> we log a bug/feature and get to it later?
>>
>
> I had first thought that this can be considered. But now I think there is
> no easy way to do this. But still I have opened  3611078 just in case.
>
>
>> Otherwise the patch looks good.
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Enterprise Postgres Company
>>
>
>


-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company