Re: [Postgres-xc-developers] Patch to add an option in pg_dump to dump nodes and node groups [Feature ID 3608376]

[Ashutosh B. <ash...@en...>]

Hi Abbas,
It seems I am wrong. We need separate pooler for each coordinator.


On Tue, Apr 9, 2013 at 7:26 PM, Abbas Butt <abb...@en...>wrote:

>
>
> On Tue, Apr 9, 2013 at 5:46 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Abbas,
>> I reviewed both the patches --include-node and --dump-node and tested in
>> the context of coordinator addition. While adding the coordinator, I found
>> that the newly added coordinator tries to bool its own pooler and needs a
>> separate pooler port to be specified. In the current code, I always specify
>> the same pooler port for all the coordinator (even if run on the same
>> machine). This looks to be a problem.
>>
>
> Coordinator and pooler use unix domain sockets to communicate with each
> other and since unix domain sockets work only locally, sharing pooler
> between coordinators running on different machines is out of question.
> Let us restrict our discussion to coordinators running on the same machine
> and trying to share pooler. Pooler is started by PostmasterMain using  this
> code
>
>     if (IS_PGXC_COORDINATOR)
>     {
>         oldcontext = MemoryContextSwitchTo(TopMemoryContext);
>
>         /*
>          * Initialize the Data Node connection pool
>          */
>         PgPoolerPID = StartPoolManager();
>
>         MemoryContextSwitchTo(oldcontext);
>     }
>
> StartPoolManager forks the pooler process and the pooler process issues
> bind in pool_listen.
> I don't see any code to facilitate coordinators running on same machine
> sharing a pooler.
>
> Can you please elaborate on how do you start the coordinators when they
> share the same pooler?
>
>
> In the documentation, you have use &xconly for one option and a line "This
>> option is available in <productname>Postgres-XC</> only", for the second.
>> Which one is correct.
>>
>
> &xconly is correct. I have used it in both the cases.
>
>
>> Please use same thing in both the cases. Rest of the changes look fine.
>> In the attached patch, I have improved the wording in documentation
>> slightly. Please use that wording in the documentation.
>>
>
> I have noted the change, I will include it in the revised patch to commit.
>
>
>>
>>
>> On Sat, Apr 6, 2013 at 12:22 AM, Abbas Butt <abb...@en...>wrote:
>>
>>> Attached please find an updated patch that includes the documentation
>>> changes as you suggested.
>>> I have also attached an html file that would eventually become a new
>>> chapter in Server Administration section of the documentation. This html
>>> lists the steps to be performed to add a new coordinator.
>>>
>>>
>>> On Fri, Apr 5, 2013 at 5:23 PM, Ashutosh Bapat <
>>> ash...@en...> wrote:
>>>
>>>> And BTW, we need corresponding document changes for this one.
>>>>
>>>>
>>>> On Fri, Apr 5, 2013 at 5:48 PM, Ashutosh Bapat <
>>>> ash...@en...> wrote:
>>>>
>>>>> Sorry, here's the updated patch.
>>>>>
>>>>>
>>>>> On Fri, Apr 5, 2013 at 5:46 PM, Ashutosh Bapat <
>>>>> ash...@en...> wrote:
>>>>>
>>>>>> Hi Abbas
>>>>>> I reviewed your changes, they look good. I have made some minor
>>>>>> changes. Please find them in attached patch.
>>>>>>
>>>>>> I want to test this in a scenario on adding new node. Can you please
>>>>>> point me as to what steps I should follow? I don't want to lock the
>>>>>> cluster, but do this
>>>>>> 1. Take the dump of existing coordinator using this patch
>>>>>> 2. initdb a new coordinator
>>>>>> 3. boot and use this dump to update the coordinator
>>>>>>
>>>>>> Now with some magic this coordinator should be useful. Can you please
>>>>>> provide me with the steps to do this? I will run those thus testing your
>>>>>> patch.
>>>>>>
>>>>>>
>>>>>> On Sun, Mar 31, 2013 at 12:14 AM, Abbas Butt <
>>>>>> abb...@en...> wrote:
>>>>>>
>>>>>>> I just realized I had attached the wrong patch file with the
>>>>>>> previous mail, please ignore the previous attachment and use the one
>>>>>>> attached with this email for review.
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Mar 29, 2013 at 5:33 PM, Abbas Butt <
>>>>>>> abb...@en...> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>> Attached please find a revised patch that provides support in
>>>>>>>> pg_dumpall to dump nodes and node groups if the command line option
>>>>>>>> --dump-nodes is provided.
>>>>>>>>
>>>>>>>> I tested and found that pg_dumpall works as expected.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Mar 27, 2013 at 5:04 PM, Abbas Butt <
>>>>>>>> abb...@en...> wrote:
>>>>>>>>
>>>>>>>>> Feature ID 3608376
>>>>>>>>>
>>>>>>>>> On Sun, Mar 10, 2013 at 7:59 PM, Abbas Butt <
>>>>>>>>> abb...@en...> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>> Attached please find a patch that adds support in pg_dump to dump
>>>>>>>>>> nodes and node groups. This is required while adding a new node to the
>>>>>>>>>> cluster.
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Abbas
>>>>>>>>>> Architect
>>>>>>>>>> EnterpriseDB Corporation
>>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>>
>>>>>>>>>> Phone: 92-334-5100153
>>>>>>>>>>
>>>>>>>>>> Website: www.enterprisedb.com
>>>>>>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>>>>>>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>>>>>>>>>
>>>>>>>>>> This e-mail message (and any attachment) is intended for the use
>>>>>>>>>> of
>>>>>>>>>> the individual or entity to whom it is addressed. This message
>>>>>>>>>> contains information from EnterpriseDB Corporation that may be
>>>>>>>>>> privileged, confidential, or exempt from disclosure under
>>>>>>>>>> applicable
>>>>>>>>>> law. If you are not the intended recipient or authorized to
>>>>>>>>>> receive
>>>>>>>>>> this for the intended recipient, any use, dissemination,
>>>>>>>>>> distribution,
>>>>>>>>>> retention, archiving, or copying of this communication is strictly
>>>>>>>>>> prohibited. If you have received this e-mail in error, please
>>>>>>>>>> notify
>>>>>>>>>> the sender immediately by reply e-mail and delete this message.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> --
>>>>>>>>> Abbas
>>>>>>>>> Architect
>>>>>>>>> EnterpriseDB Corporation
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>> Phone: 92-334-5100153
>>>>>>>>>
>>>>>>>>> Website: www.enterprisedb.com
>>>>>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>>>>>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>>>>>>>>
>>>>>>>>> This e-mail message (and any attachment) is intended for the use of
>>>>>>>>> the individual or entity to whom it is addressed. This message
>>>>>>>>> contains information from EnterpriseDB Corporation that may be
>>>>>>>>> privileged, confidential, or exempt from disclosure under
>>>>>>>>> applicable
>>>>>>>>> law. If you are not the intended recipient or authorized to receive
>>>>>>>>> this for the intended recipient, any use, dissemination,
>>>>>>>>> distribution,
>>>>>>>>> retention, archiving, or copying of this communication is strictly
>>>>>>>>> prohibited. If you have received this e-mail in error, please
>>>>>>>>> notify
>>>>>>>>> the sender immediately by reply e-mail and delete this message.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> --
>>>>>>>> Abbas
>>>>>>>> Architect
>>>>>>>> EnterpriseDB Corporation
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>> Phone: 92-334-5100153
>>>>>>>>
>>>>>>>> Website: www.enterprisedb.com
>>>>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>>>>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>>>>>>>
>>>>>>>> This e-mail message (and any attachment) is intended for the use of
>>>>>>>> the individual or entity to whom it is addressed. This message
>>>>>>>> contains information from EnterpriseDB Corporation that may be
>>>>>>>> privileged, confidential, or exempt from disclosure under applicable
>>>>>>>> law. If you are not the intended recipient or authorized to receive
>>>>>>>> this for the intended recipient, any use, dissemination,
>>>>>>>> distribution,
>>>>>>>> retention, archiving, or copying of this communication is strictly
>>>>>>>> prohibited. If you have received this e-mail in error, please notify
>>>>>>>> the sender immediately by reply e-mail and delete this message.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> --
>>>>>>> Abbas
>>>>>>> Architect
>>>>>>> EnterpriseDB Corporation
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>> Phone: 92-334-5100153
>>>>>>>
>>>>>>> Website: www.enterprisedb.com
>>>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>>>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>>>>>>
>>>>>>> This e-mail message (and any attachment) is intended for the use of
>>>>>>> the individual or entity to whom it is addressed. This message
>>>>>>> contains information from EnterpriseDB Corporation that may be
>>>>>>> privileged, confidential, or exempt from disclosure under applicable
>>>>>>> law. If you are not the intended recipient or authorized to receive
>>>>>>> this for the intended recipient, any use, dissemination,
>>>>>>> distribution,
>>>>>>> retention, archiving, or copying of this communication is strictly
>>>>>>> prohibited. If you have received this e-mail in error, please notify
>>>>>>> the sender immediately by reply e-mail and delete this message.
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------------------
>>>>>>> Own the Future-Intel(R) Level Up Game Demo Contest 2013
>>>>>>> Rise to greatness in Intel's independent game demo contest. Compete
>>>>>>> for recognition, cash, and the chance to get your game on Steam.
>>>>>>> $5K grand prize plus 10 genre and skill prizes. Submit your demo
>>>>>>> by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
>>>>>>> _______________________________________________
>>>>>>> Postgres-xc-developers mailing list
>>>>>>> Pos...@li...
>>>>>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Wishes,
>>>>>> Ashutosh Bapat
>>>>>> EntepriseDB Corporation
>>>>>> The Enterprise Postgres Company
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Wishes,
>>>>> Ashutosh Bapat
>>>>> EntepriseDB Corporation
>>>>> The Enterprise Postgres Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Wishes,
>>>> Ashutosh Bapat
>>>> EntepriseDB Corporation
>>>> The Enterprise Postgres Company
>>>>
>>>
>>>
>>>
>>> --
>>> --
>>> Abbas
>>> Architect
>>> EnterpriseDB Corporation
>>> The Enterprise PostgreSQL Company
>>>
>>> Phone: 92-334-5100153
>>>
>>> Website: www.enterprisedb.com
>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>>
>>> This e-mail message (and any attachment) is intended for the use of
>>> the individual or entity to whom it is addressed. This message
>>> contains information from EnterpriseDB Corporation that may be
>>> privileged, confidential, or exempt from disclosure under applicable
>>> law. If you are not the intended recipient or authorized to receive
>>> this for the intended recipient, any use, dissemination, distribution,
>>> retention, archiving, or copying of this communication is strictly
>>> prohibited. If you have received this e-mail in error, please notify
>>> the sender immediately by reply e-mail and delete this message.
>>>
>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Enterprise Postgres Company
>>
>
>
>
> --
> --
> Abbas
> Architect
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
> Phone: 92-334-5100153
>
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of
> the individual or entity to whom it is addressed. This message
> contains information from EnterpriseDB Corporation that may be
> privileged, confidential, or exempt from disclosure under applicable
> law. If you are not the intended recipient or authorized to receive
> this for the intended recipient, any use, dissemination, distribution,
> retention, archiving, or copying of this communication is strictly
> prohibited. If you have received this e-mail in error, please notify
> the sender immediately by reply e-mail and delete this message.
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company