[Postgres-xc-developers] Review comments commit 5f3a271343b4754f7c28bd77db9e83e89631092c

[Ashutosh B. <ash...@en...>]

Hi Amit,
This isn't your change but, The prologue of function SetDataRowForIntParams
is using non-standard format of adding "----" at the start and end of
prologue. Please remove those.

sourceSlot and newSlot seem to be generic names in the context of function
SetDataRowForIntParams() which says "Form a bind row for internal
parameters". Since the function is going to change a bit, it will take some
data from one slot and some from other to create data row, I think we
should change the previous names of variables/functions to convey changed
symantic.

Please add prologues for function append_val and append_junkval(). These
functions need better names like append_paramval or append_param_junkval
etc., better if you add prefix pgxc_ that we are doing for all xc specific
function.

Instead of having macro SET_PARAM_TYPES (which makes debugging difficult),
can you please use function? In fact, if we set parameters just after
setting paramtypes_set?

I see we have added jf_xc_node_id and jf_whole_row as storage for attribute
numbers of corresponding fields from the source tuple. Please add some
comments specifying their usage (may be why we need these extra fields
apart from jf_junkAttNo)
-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company