Re: [Postgres-xc-developers] Patch to fix pg_dump to generate TO NODE clause in the dump

[Ashutosh B. <ash...@en...>]

Hi Abbas,
Please take a look at
http://www.postgresql.org/docs/9.2/static/app-pgdump.html, which gives all
the command line options for pg_dump. instead of include-to-node-clause,
just include-nodes would suffice, I guess.

On Fri, Mar 1, 2013 at 8:36 PM, Abbas Butt <abb...@en...>wrote:

> PFA a updated patch that provides a command line argument called
> --include-to-node-clause to let pg_dump know that the created dump is
> supposed to emit TO NODE clause in the CREATE TABLE command.
> If the argument is provided while taking the dump from a datanode, it does
> not show TO NODE clause in the dump since the catalog table is empty in
> this case.
> The documentation of pg_dump is updated accordingly.
> The rest of the functionality stays the same as before.
>
>
> On Mon, Feb 25, 2013 at 10:29 AM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> I think we should always dump DISTRIBUTE BY.
>>
>> PG does not stop dumping (or provide an option to do so) newer syntax so
>> that the dump will work on older versions. On similar lines, an XC dump can
>> not be used against PG without modification (removing DISTRIBUTE BY). There
>> can be more serious problems like exceeding table size limits if an XC dump
>> is tried to be restored in PG.
>>
>> As to TO NODE clause, I agree, that one can restore the dump on a cluster
>> with different configuration, so giving an option to dump TO NODE clause
>> will help.
>>
>> On Mon, Feb 25, 2013 at 6:42 AM, Michael Paquier <
>> mic...@gm...> wrote:
>>
>>>
>>>
>>> On Mon, Feb 25, 2013 at 4:17 AM, Abbas Butt <abb...@en...
>>> > wrote:
>>>
>>>>
>>>>
>>>> On Sun, Feb 24, 2013 at 5:33 PM, Michael Paquier <
>>>> mic...@gm...> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 24, 2013 at 7:04 PM, Abbas Butt <
>>>>> abb...@en...> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 24, 2013 at 1:44 PM, Michael Paquier <
>>>>>> mic...@gm...> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sun, Feb 24, 2013 at 3:51 PM, Abbas Butt <
>>>>>>> abb...@en...> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>> PFA a patch to  fix pg_dump to generate TO NODE clause in the dump.
>>>>>>>> This is required because otherwise all tables get created on all
>>>>>>>> nodes after a dump-restore cycle.
>>>>>>>>
>>>>>>> Not sure this is good if you take a dump of an XC cluster to restore
>>>>>>> that to a vanilla Postgres cluster.
>>>>>>> Why not adding a new option that would control the generation of
>>>>>>> this clause instead of forcing it?
>>>>>>>
>>>>>>
>>>>>> I think you can use the pg_dump that comes with vanilla PG to do
>>>>>> that, can't you? But I am open to adding a control option if every body
>>>>>> thinks so.
>>>>>>
>>>>> Sure you can, this is just to simplify the life of users a maximum by
>>>>> not having multiple pg_dump binaries in their serves.
>>>>> Saying that, I think that there is no option to choose if DISTRIBUTE
>>>>> BY is printed in the dump or not...
>>>>>
>>>>
>>>> Yah if we choose to have an option we will put both DISTRIBUTE BY and
>>>> TO NODE under it.
>>>>
>>> Why not an option for DISTRIBUTE BY, and another for TO NODE?
>>> This would bring more flexibility to the way dumps are generated.
>>> --
>>> Michael
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Everyone hates slow websites. So do we.
>>> Make your web apps faster with AppDynamics
>>> Download AppDynamics Lite for free today:
>>> http://p.sf.net/sfu/appdyn_d2d_feb
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>>
>>
>>
>> --
>> Best Wishes,
>> Ashutosh Bapat
>> EntepriseDB Corporation
>> The Enterprise Postgres Company
>>
>
>
>
> --
> --
> Abbas
> Architect
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
> Phone: 92-334-5100153
>
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of
> the individual or entity to whom it is addressed. This message
> contains information from EnterpriseDB Corporation that may be
> privileged, confidential, or exempt from disclosure under applicable
> law. If you are not the intended recipient or authorized to receive
> this for the intended recipient, any use, dissemination, distribution,
> retention, archiving, or copying of this communication is strictly
> prohibited. If you have received this e-mail in error, please notify
> the sender immediately by reply e-mail and delete this message.
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company