Re: [Postgres-xc-developers] Patch to fix a crash in COPY TO from a replicated table

[Michael P. <mic...@gm...>]

On Mon, Feb 25, 2013 at 2:18 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Thanks a lot Abbas for this quick fix.
>
> I am sorry, it's caused by my refactoring of GetRelationNodes().
>
> If possible, can you please examine the other callers of
> GetRelationNodes() which would face the problems, esp. the ones for DML and
> utilities. This is other instance, where deciding the nodes to execute on
> at the time of execution will help.
>
> About the fix
> Can you please use GetPreferredReplicationNode() instead of
> list_truncate()? It will pick the preferred node instead of first one. If
> you find more places where we need this fix, it might be better to create a
> wrapper function and use it at those places.
>
Also could you add a test in xc_copy to be sure that this does not happen
again?
I think there are already safeguards in this test but just to be sure...
-- 
Michael