Re: [Postgres-xc-developers] Patch to fix pg_dump to generate TO NODE clause in the dump

[Michael P. <mic...@gm...>]

On Mon, Feb 25, 2013 at 4:17 AM, Abbas Butt <abb...@en...>wrote:

>
>
> On Sun, Feb 24, 2013 at 5:33 PM, Michael Paquier <
> mic...@gm...> wrote:
>
>>
>>
>> On Sun, Feb 24, 2013 at 7:04 PM, Abbas Butt <abb...@en...>wrote:
>>
>>>
>>>
>>> On Sun, Feb 24, 2013 at 1:44 PM, Michael Paquier <
>>> mic...@gm...> wrote:
>>>
>>>>
>>>>
>>>> On Sun, Feb 24, 2013 at 3:51 PM, Abbas Butt <
>>>> abb...@en...> wrote:
>>>>
>>>>> Hi,
>>>>> PFA a patch to  fix pg_dump to generate TO NODE clause in the dump.
>>>>> This is required because otherwise all tables get created on all nodes
>>>>> after a dump-restore cycle.
>>>>>
>>>> Not sure this is good if you take a dump of an XC cluster to restore
>>>> that to a vanilla Postgres cluster.
>>>> Why not adding a new option that would control the generation of this
>>>> clause instead of forcing it?
>>>>
>>>
>>> I think you can use the pg_dump that comes with vanilla PG to do that,
>>> can't you? But I am open to adding a control option if every body thinks so.
>>>
>> Sure you can, this is just to simplify the life of users a maximum by not
>> having multiple pg_dump binaries in their serves.
>> Saying that, I think that there is no option to choose if DISTRIBUTE BY
>> is printed in the dump or not...
>>
>
> Yah if we choose to have an option we will put both DISTRIBUTE BY and TO
> NODE under it.
>
Why not an option for DISTRIBUTE BY, and another for TO NODE?
This would bring more flexibility to the way dumps are generated.
-- 
Michael