Re: [Postgres-xc-developers] Patch correcting implicit 2-phase commit

[Michael P. <mic...@gm...>]

Sorry for my late reply, please see my answers inline.


> #0  pgxc_node_implicit_commit_prepared (prepare_xid=924, commit_xid=925,
> pgxc_handles=0x1042c0c, gid=0xbfffef4f "T924", is_commit=1 '\001') at
> execRemote.c:1826
> 1826        int        co_conn_count = pgxc_handles->co_conn_count;
> (gdb) bt
> #0  pgxc_node_implicit_commit_prepared (prepare_xid=924, commit_xid=925,
> pgxc_handles=0x1042c0c, gid=0xbfffef4f "T924", is_commit=1 '\001') at
> execRemote.c:1826
> #1  0x001c2b0d in PGXCNodeImplicitCommitPrepared (prepare_xid=924,
> commit_xid=925, gid=0xbfffef4f "T924", is_commit=1 '\001') at
> execRemote.c:1775
> #2  0x0005845f in CommitTransaction () at xact.c:2013
> #3  0x0005948f in CommitTransactionCommand () at xact.c:2746
> #4  0x0029a6d7 in finish_xact_command () at postgres.c:2437
> #5  0x002980d2 in exec_simple_query (query_string=0x103481c "commit;") at
> postgres.c:1070
> #6  0x0029ccbb in PostgresMain (argc=4, argv=0x1002ff8, username=0x1002fc8
> "masonsharp") at postgres.c:3766
> #7  0x0025848c in BackendRun (port=0x7016f0) at postmaster.c:3607
> #8  0x002577f3 in BackendStartup (port=0x7016f0) at postmaster.c:3216
> #9  0x00254225 in ServerLoop () at postmaster.c:1445
> #10 0x00253831 in PostmasterMain (argc=5, argv=0x7005a0) at
> postmaster.c:1098
> #11 0x001cf261 in main (argc=5, argv=0x7005a0) at main.c:188
>
> pgxc_handles looks ok though. It works ok in your environment?
>

It looks that it crashed when assigning the coordinator number from
pgxc_handles.

I made a couple of tests in my environment and it worked well, with
assertions assigned.
By a couple of tests, I made a sequence creation, a couple of inserts in
single and multiple nodes, DDL run.
Everything went fine.

We already saw in the past that not all the problems are reproducible in the
environments we use for tests.

Could you give me more details about this crash?

-- 
Michael Paquier
http://michaelpq.users.sourceforge.net