Re: [Postgres-xc-developers] Patch correcting implicit 2-phase commit

[Pavan D. <pav...@gm...>]

On Tue, Nov 30, 2010 at 1:57 PM, Michael Paquier
<mic...@gm...>wrote:

> Hi all,
>
> Please see attached a patch that corrects 2PC (2 phase commit) in the case
> of an implicit 2PC.
>

I think we should try to minimize changes to CommitTransaction. Why not use
the PrepareTransaction() to prepare the transaction instead of duplicating
that code inside CommitTransaction ? Also, it would be nice if you can take
away new code in a separate function and call that, something like
AtEOXact_PGXC() or something like that.

Thanks,
Pavan

-- 
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com