Re: [Postgres-xc-developers] a patch for gtm_ctl

[Pavan D. <pav...@gm...>]

On Tue, Nov 30, 2010 at 2:49 PM, xiong wang <wan...@gm...> wrote:

> Dears,
>
> There is a bug in gtm_ctl.c. The varible gtm_path doesn't have enough space
> to concat varible gtm_app.
>
> The enclosure is the patch.
>
>
Hi Benny,

Thanks for the patch. We could just use the stack variable instead of
allocating memory. I also noticed that we should better be cautious about
buffer overflow while constructing the command string. So I added checks to
guard against that.

While looking at compiler warnings, I also noticed couple of other issues,
especially with uninitialized vars. Please see attached patch. I would
commit this barring any objections.

Thanks,
Pavan

-- 
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com