Re: [Postgres-xc-developers] Patch for bug#3107683: UPDATE on partition column

[Koichi S. <ko...@in...>]

Hi,

I understand the idea.  I'd just like to be a bit careful what should be
nice to include as a temporary or a partial solution and what we should
provide as a general solution.   I understand this patch will be useful
and people may not be confused.

Cheers;
---
Koichi

(2010年11月16日 12:09), xiong wang wrote:
> Dears,
> 
> Thanks for your suggestions.
> 
> I should clarify my idea.
> 1)This patch is a temporary solution. It cann't really solve the
> problem raised by updating on a partition column until the measure
> that moving tuples from one node to another comes true.
>     It just forbids users to update on a partition column. Therefore, I
> didn't consider too much because it will be deleted later.
> 2)The patch forbids update on partition column on coordinators. It has
> nothing to do with data nodes.
> 
> If I misunderstand you, please let me know.
> 
> Regards,
> Benny
> 
>> Hi,
> 
>> I'm curious about two issues on this patch.
> 
>> 1) Does it handle TOAST table correctly?
>> 2) Does it handle SET clause such as SET key = key+1 ?  Only a data node
> can determine if such UPDATE statement make rows invalid to stay in the
> data node.   Unfortunately, data node is not equipped with distribution
> key.  To handle this correctly, data node has to handle TOAST table as
>> mentioned in 1).
> 
>> Regards;
>> ---
>> Koichi Suzuki
> 
> (2010年11月15日 23:59), Mason Sharp wrote:
>> On 11/15/10 5:13 PM, mei le wrote:
>>> Dears,
>>>
>>> I am sorry. The bug#3107683.patch I commited before introduces a warning I didn't noticed. The enclosure is a new patch after I eliminated the warning.
>>>
>> Thanks. I just committed this and fixed a couple of other warnings that
>> we had.
>>
>> Regards,
>>
>> Mason
>>> Regards,
>>>
>>>                                               Benny
>>>
>>>
>>>
>>> --- 10年11月12日，周五, Mason Sharp<mas...@en...>   写道：
>>>
>>>
>>> 发件人: Mason Sharp<mas...@en...>
>>> 主题: Fwd: [ postgres-xc-Bugs-3107683 ] UPDATE on partition column
>>> 收件人: "Postgres-XC Developers"<pos...@li...>, "mei le"<lem...@ya...>
>>> 日期: 2010年11月12日,周五,上午10:34
>>>
>>>
>>> Benny,
>>>
>>> I thought this might be one you might be interested in working on, too, if you have time.
>>>
>>> You could validate the update statement in pgxc_planner() if it is on a partitioned table.
>>>
>>> Thanks,
>>>
>>> Mason
>>>
>>> -------- Original Message --------
>>>
>>>
>>>
>>> Subject:
>>> [ postgres-xc-Bugs-3107683 ] UPDATE on partition column
>>>
>>> Date:
>>> Fri, 12 Nov 2010 02:29:56 +0000
>>>
>>> From:
>>> SourceForge.net<no...@so...>
>>>
>>> To:
>>> no...@so...
>>>
>>> Bugs item #3107683, was opened at 2010-11-11 21:29
>>> Message generated for change (Tracker Item Submitted) made by mason_s
>>> You can respond by visiting:
>>> https://sourceforge.net/tracker/?func=detail&atid=1310232&aid=3107683&group_id=311227
>>>
>>> Please note that this message will contain a full copy of the comment thread,
>>> including the initial issue submission, for this request,
>>> not just the latest update.
>>> Category: Database Server
>>> Group: None
>>> Status: Open
>>> Resolution: None
>>> Priority: 6
>>> Private: No
>>> Submitted By: mason_s (mason_s)
>>> Assigned to: Nobody/Anonymous (nobody)
>>> Summary: UPDATE on partition column
>>>
>>> Initial Comment:
>>> Until we support moving tuples from one node to another when the partition column of a table is updated, we should at least block this from happening. At the moment you can update it, and bad things can start happening as a result.
>>>
>>> ----------------------------------------------------------------------
>>>
>>> You can respond by visiting:
>>> https://sourceforge.net/tracker/?func=detail&atid=1310232&aid=3107683&group_id=311227
>>>
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Centralized Desktop Delivery: Dell and VMware Reference Architecture
>>> Simplifying enterprise desktop deployment and management using
>>> Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
>>> client virtualization framework. Read more!
>>> http://p.sf.net/sfu/dell-eql-dev2dev
>>>
>>>
>>> _______________________________________________
>>> Postgres-xc-developers mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>>>
>>
>>
>> --
>> Mason Sharp
>> EnterpriseDB Corporation
>> The Enterprise Postgres Company
>>
>>
>> This e-mail message (and any attachment) is intended for the use of
>> the individual or entity to whom it is addressed. This message
>> contains information from EnterpriseDB Corporation that may be
>> privileged, confidential, or exempt from disclosure under applicable
>> law. If you are not the intended recipient or authorized to receive
>> this for the intended recipient, any use, dissemination, distribution,
>> retention, archiving, or copying of this communication is strictly
>> prohibited. If you have received this e-mail in error, please notify
>> the sender immediately by reply e-mail and delete this message.
>>
> 
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2&  L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today
> http://p.sf.net/sfu/msIE9-sfdev2dev
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers