Re: [Postgres-xc-developers] Patch for bug#3010262:Primary Key in CREATE TABLE

[Mason S. <mas...@en...>]

>
> Enclosure is my patch for bug#3010262. Your suggestions will be 
> appreciated.
>                                                                               
> Truely,
>                                                                                 
> Benny
>
>
>


Thanks, Benny.

In looking at the patch, I am guessing the main issue you fixed was that 
it will create an additional create index command, and that we do not 
want to send it down to the data nodes since one already ran as part of 
the create table.

I think we should try and avoid modifying the existing PostgreSQL 
function parameter list like that for transformIndexConstraints() if 
reasonably (stress: reasonably) possible to make merging and maintenance 
of PostgreSQL easier.  Can CreateStmtContext.isalter be used instead? 
Can it even be used in utility.c instead of isFromCreateStmt?

Thanks,

Mason
>
>
> ------------------------------------------------------------------------------
> Nokia and AT&T present the 2010 Calling All Innovators-North America contest
> Create new apps&  games for the Nokia N8 for consumers in  U.S. and Canada
> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
> http://p.sf.net/sfu/nokia-dev2dev
>
>
> _______________________________________________
> Postgres-xc-developers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-developers
>    


-- 
Mason Sharp
EnterpriseDB Corporation
The Enterprise Postgres Company


This e-mail message (and any attachment) is intended for the use of
the individual or entity to whom it is addressed. This message
contains information from EnterpriseDB Corporation that may be
privileged, confidential, or exempt from disclosure under applicable
law. If you are not the intended recipient or authorized to receive
this for the intended recipient, any use, dissemination, distribution,
retention, archiving, or copying of this communication is strictly
prohibited. If you have received this e-mail in error, please notify
the sender immediately by reply e-mail and delete this message.