#122 vacation.php: check date

closed-fixed
nobody
None
5
2014-10-13
2013-12-28
J.Kruis
No

temp patch for checking correct date ative from and active until

1 Attachments

Discussion

  • Christian Boltz

    Christian Boltz - 2014-05-27

    Your patch adds two texts to nl.lang:
    +$PALANG['pVacation_until_before_today'] = '[Actief t/m] ligt voor de datum van vandaag';
    +$PALANG['reply_once_per_day'] = 'Beantwoord een keer per dag';

    Can you please provide the english text for them?

     
  • Christian Boltz

    Christian Boltz - 2014-05-27
    • summary: check date --> vacation.php: check date
     
  • J.Kruis

    J.Kruis - 2014-08-15

    Hi Christian,

    here is my translation plus a number of other translation for the Netherlands

    btw according to me there are some strings marked as obsolete as those are not

    regrades Jan

     
  • J.Kruis

    J.Kruis - 2014-10-06

    Hi Christian,

    Hereby my custom patch for checking the date vacation.php and a few adjustments, also attached your request for english text for this patch. Include are also a number of other translation for the Netherlands

    btw according to me there are some strings marked as obsolete as those are not
    but still in use.

    regrades Jan

     
  • Christian Boltz

    Christian Boltz - 2014-10-13
    • status: open --> closed-fixed
     
  • Christian Boltz

    Christian Boltz - 2014-10-13

    I commited your patch (trunk r1697) with some small modifications:
    - I ignored the broadcast.php change - there's https://sourceforge.net/p/postfixadmin/patches/125/ for it ;-)
    - in vacation.php, I'm using flash_error() instead of $Error_String (which would later result in a strange error message like "Updating the auto response settings for The Date of [Active until] is set before Today failed"
    - and some comment and whitespace changes
    - change $PALANG['pUsersVacation_welcome_text'] for all languages, not only nl ;-)

    BTW: Is there a reason why you didn't remove the "# XXX" marker in nl.lang on translated strings? It doesn't really hurt, but it makes it harder to find out which texts need to be translated or updated. If the texts are ok, please submit a patch that removes all superfluous "# XXX" comments ;-)

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks