Thread: [ postfixadmin-Bugs-2682897 ] Incorrect subject encoding in sendmail.php
Brought to you by:
christian_boltz,
gingerdog
From: SourceForge.net <no...@so...> - 2009-03-11 14:42:49
|
Bugs item #2682897, was opened at 2009-03-11 17:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Languages Group: v 2.3 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dystopian (dystopian) Assigned to: Nobody/Anonymous (nobody) Summary: Incorrect subject encoding in sendmail.php Initial Comment: If subject of a message is in Russian (I don't know about other languages) the function encode_header() works incorrectly, so subject in the inbox is broken. I checked in Thunderbird, Roundcube and Opera. I used standard php encoding function mb_encode_mimeheader() which is used in broadcast-message.php. Here's the patch: 47,48c47,48 < < $fHeaders .= "Subject: " . encode_header(safepost('fSubject')) . "\n"; --- > mb_internal_encoding("UTF-8"); > $fHeaders .= "Subject: " . mb_encode_mimeheader( safepost('fSubject'), 'UTF-8', 'Q') . "\n"; I think there should be the only function for mail sending that can be used in broadcast-message.php, sendmail.php, create-mailbox.php. Also I think that base64 encoding of message body in broadcast-message.php isn't necessary - plain text would be better. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 |
From: SourceForge.net <no...@so...> - 2009-03-11 14:45:09
|
Bugs item #2682897, was opened at 2009-03-11 17:42 Message generated for change (Comment added) made by dystopian You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Languages Group: v 2.3 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dystopian (dystopian) Assigned to: Nobody/Anonymous (nobody) Summary: Incorrect subject encoding in sendmail.php Initial Comment: If subject of a message is in Russian (I don't know about other languages) the function encode_header() works incorrectly, so subject in the inbox is broken. I checked in Thunderbird, Roundcube and Opera. I used standard php encoding function mb_encode_mimeheader() which is used in broadcast-message.php. Here's the patch: 47,48c47,48 < < $fHeaders .= "Subject: " . encode_header(safepost('fSubject')) . "\n"; --- > mb_internal_encoding("UTF-8"); > $fHeaders .= "Subject: " . mb_encode_mimeheader( safepost('fSubject'), 'UTF-8', 'Q') . "\n"; I think there should be the only function for mail sending that can be used in broadcast-message.php, sendmail.php, create-mailbox.php. Also I think that base64 encoding of message body in broadcast-message.php isn't necessary - plain text would be better. ---------------------------------------------------------------------- >Comment By: Dystopian (dystopian) Date: 2009-03-11 17:44 Message: File Added: bug.png ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 |
From: SourceForge.net <no...@so...> - 2009-03-11 22:42:02
|
Bugs item #2682897, was opened at 2009-03-11 15:42 Message generated for change (Comment added) made by christian_boltz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Languages Group: v 2.3 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dystopian (dystopian) Assigned to: Nobody/Anonymous (nobody) Summary: Incorrect subject encoding in sendmail.php Initial Comment: If subject of a message is in Russian (I don't know about other languages) the function encode_header() works incorrectly, so subject in the inbox is broken. I checked in Thunderbird, Roundcube and Opera. I used standard php encoding function mb_encode_mimeheader() which is used in broadcast-message.php. Here's the patch: 47,48c47,48 < < $fHeaders .= "Subject: " . encode_header(safepost('fSubject')) . "\n"; --- > mb_internal_encoding("UTF-8"); > $fHeaders .= "Subject: " . mb_encode_mimeheader( safepost('fSubject'), 'UTF-8', 'Q') . "\n"; I think there should be the only function for mail sending that can be used in broadcast-message.php, sendmail.php, create-mailbox.php. Also I think that base64 encoding of message body in broadcast-message.php isn't necessary - plain text would be better. ---------------------------------------------------------------------- >Comment By: Christian Boltz (christian_boltz) Date: 2009-03-11 23:41 Message: The encoding is fixed in SVN r573 - thanks for your report. I agree that sending mail could (and should) be handled in a common function - I opened https://sourceforge.net/tracker2/?func=detail&aid=2684081&group_id=191583&atid=937967 for it. ---------------------------------------------------------------------- Comment By: Dystopian (dystopian) Date: 2009-03-11 15:44 Message: File Added: bug.png ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 |
From: SourceForge.net <no...@so...> - 2009-03-11 22:42:15
|
Bugs item #2682897, was opened at 2009-03-11 15:42 Message generated for change (Settings changed) made by christian_boltz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Languages Group: v 2.3 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Dystopian (dystopian) Assigned to: Nobody/Anonymous (nobody) Summary: Incorrect subject encoding in sendmail.php Initial Comment: If subject of a message is in Russian (I don't know about other languages) the function encode_header() works incorrectly, so subject in the inbox is broken. I checked in Thunderbird, Roundcube and Opera. I used standard php encoding function mb_encode_mimeheader() which is used in broadcast-message.php. Here's the patch: 47,48c47,48 < < $fHeaders .= "Subject: " . encode_header(safepost('fSubject')) . "\n"; --- > mb_internal_encoding("UTF-8"); > $fHeaders .= "Subject: " . mb_encode_mimeheader( safepost('fSubject'), 'UTF-8', 'Q') . "\n"; I think there should be the only function for mail sending that can be used in broadcast-message.php, sendmail.php, create-mailbox.php. Also I think that base64 encoding of message body in broadcast-message.php isn't necessary - plain text would be better. ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2009-03-11 23:41 Message: The encoding is fixed in SVN r573 - thanks for your report. I agree that sending mail could (and should) be handled in a common function - I opened https://sourceforge.net/tracker2/?func=detail&aid=2684081&group_id=191583&atid=937967 for it. ---------------------------------------------------------------------- Comment By: Dystopian (dystopian) Date: 2009-03-11 15:44 Message: File Added: bug.png ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2682897&group_id=191583 |