Thread: SF.net SVN: postfixadmin:[833] trunk/ADDITIONS/squirrelmail-plugin/ functions.inc.php
Brought to you by:
christian_boltz,
gingerdog
From: <chr...@us...> - 2010-06-04 23:55:32
|
Revision: 833 http://postfixadmin.svn.sourceforge.net/postfixadmin/?rev=833&view=rev Author: christian_boltz Date: 2010-06-04 23:55:25 +0000 (Fri, 04 Jun 2010) Log Message: ----------- After debugging "Login failed" with mach0 on #postfixadmin: error_log() login failures - the error message helps in debugging very much (things like "not found", "connection refused" etc.) Not sure if the exception message can contain sensitive data, therefore not displaying the details to the user. Maybe we should exclude "real" login failures (wrong password) from logging, but for now having an error message is better than no message ;-) Modified Paths: -------------- trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php Modified: trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php =================================================================== --- trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php 2010-05-23 14:48:01 UTC (rev 832) +++ trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php 2010-06-04 23:55:25 UTC (rev 833) @@ -51,6 +51,7 @@ } catch(Exception $e) { //var_dump($client->getHttpClient()->getLastResponse()->getBody()); + error_log("Failed to login to xmlrpc instance - " . $e->getMessage); die('Failed to login to xmlrpc instance'); } if($success) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <chr...@us...> - 2011-04-10 13:09:54
|
Revision: 1024 http://postfixadmin.svn.sourceforge.net/postfixadmin/?rev=1024&view=rev Author: christian_boltz Date: 2011-04-10 13:09:48 +0000 (Sun, 10 Apr 2011) Log Message: ----------- fix typo in variable name Reported by Gabriele Vivinetto (gabrielev@SF), https://sourceforge.net/tracker/?func=detail&aid=3266862&group_id=191583&atid=937964 Modified Paths: -------------- trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php Modified: trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php =================================================================== --- trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php 2011-04-10 13:05:53 UTC (rev 1023) +++ trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php 2011-04-10 13:09:48 UTC (rev 1024) @@ -92,7 +92,7 @@ // Call: check_email (string email) // function check_email ($email) { - $return = filter_var('validate_email', $emai); + $return = filter_var('validate_email', $email); if($return === false) { return false; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <gin...@us...> - 2014-02-19 11:53:11
|
Revision: 1646 http://sourceforge.net/p/postfixadmin/code/1646 Author: gingerdog Date: 2014-02-19 11:53:09 +0000 (Wed, 19 Feb 2014) Log Message: ----------- fix exception logging; fix filter_var usage Modified Paths: -------------- trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php Modified: trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php =================================================================== --- trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php 2014-02-19 11:52:36 UTC (rev 1645) +++ trunk/ADDITIONS/squirrelmail-plugin/functions.inc.php 2014-02-19 11:53:09 UTC (rev 1646) @@ -51,7 +51,7 @@ } catch(Exception $e) { //var_dump($client->getHttpClient()->getLastResponse()->getBody()); - error_log("Failed to login to xmlrpc instance - " . $e->getMessage); + error_log("Failed to login to xmlrpc instance - " . $e->getMessage()); die('Failed to login to xmlrpc instance'); } if($success) { @@ -91,8 +91,8 @@ // Action: Checks if email is valid and returns TRUE if this is the case. // Call: check_email (string email) // -function check_email ($email) { - $return = filter_var('validate_email', $email); +function check_email($email) { + $return = filter_var($email, FILTER_VALIDATE_EMAIL); if($return === false) { return false; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |