Thread: [Postfixadmin-devel] users/vacation.php should not delete records from alias table
Brought to you by:
christian_boltz,
gingerdog
From: Dyks, A. <Axe...@co...> - 2008-12-18 19:11:25
|
Hi, I've just noticed that "users/vacation.php" would delete a user's entry from the alias table, if there were no alias(es) defined for the user. See line 107++ in http://postfixadmin.svn.sourceforge.net/viewvc/postfixadmin/trunk/users/vacation.php?revision=303&view=markup Although this actually shouldn't happen, because users/edit-alias.php will never create a record with an empty goto field, it would still produce a situation which users/edit-alias.php wouldn't be able to handle, because it NEVER inserts a record, it always UPDATE(s). See line 119++ in http://postfixadmin.svn.sourceforge.net/viewvc/postfixadmin/trunk/users/edit-alias.php?revision=250&view=markup Furthermore I think that users/edit-alias.php shouldn't blindly insert a ',' into $goto at line 83. It actually APPENDS it, in case $goto is empty (no aliases specified in textbox). Cheers, Axel Vorsitzender des Aufsichtsrats/Chairman of the Supervisory Board: Günter W. Engerer Vorstand/Managing Board: Andreas Bublak, Manfred Steinberger, Robert Zellner COC AG Sitz/Registered Office Burghausen Amtsgericht/District Court Traunstein, HRB 17218 |