|
From: Juan C. G. D. <jua...@pe...> - 2010-11-24 16:05:49
|
Hello, I'm willing, for personal porpouse, to develop some new feature in postfixadmin, it's about exposing mailbox creation and password changing functionalities through web services in order to integrate a mail server with a portal. I downloaded the SVN version and got it ready to start developing in an IDE, eclipse for PHP developers (not connected to the official repository but my own one), but i don't know how to package the project in tarball (tar.gz) format in order to make a clean installation. Also I wanted to ask if it's better to install a stable postfixadmin release and the upgrade it with the new features added by me (I don't even know how to do this). By the way, destination server for this development is Ubuntu 9.10. Finally, if you think eclipse is not the right tool to work with postfixadmin, I hope you can introduce me to "the official" alternatives to work with. I hope you people can guide me through this, maybe with tutorials or even by personal contact. I didn't even know to ask for this in the postfixadmin-devel mailing list or the svn mailing list, I just decided to start here and wait for some enlightment from you. I hope I can share this feature with you when it's done and I'm open for any suggestions you might have. Thank you very much. |
|
From: Christian B. <pos...@cb...> - 2010-11-25 01:01:05
|
Hello, Am Mittwoch, 24. November 2010 schrieb Juan Carlos Gutiérrez Deliot: > I'm willing, for personal porpouse, to develop some new feature in > postfixadmin, it's about exposing mailbox creation and password > changing functionalities through web services in order to integrate > a mail server with a portal. Changing the password, the alias of a mailbox and switching vacaton on/off is already available via XMLRPC (but disabled by default in the config). Mailbox creation over XMLRPC sounds like a good feature. You should base your work on the files in the postfixadmin-cli directory (that's a quite new command-line interface for postfixadmin), especially on the model/* files. (Well, they should be merged with the "main" model/* files, but that's another story ;-) postfixadmin-cli/model/UserHandler.php already contains functions to create a mailbox. Your task will be to a) implement admin login over XMLRPC (using a mailbox login is pointless when it comes to creating mailboxes ;-) b) integrate the mailbox creation in the XMLRPC interface c) make sure that you don't create any security holes ;-) If you need some inspiration how to use the XMLRPC interface, check the squirrelmail plugin in the ADDITIONS directory. > I downloaded the SVN version and got it ready to start developing in > an IDE, eclipse for PHP developers (not connected to the official > repository but my own one), but i don't know how to package the > project in tarball (tar.gz) format in order to make a clean > installation. Just take the SVN checkout (or your edited version of it) and make a tarball from it with tar czf. In theory you could exclude the .svn directories from the tarball, but in practise they won't hurt except taking some disk space ;-) > Also I wanted to ask if it's better to install a > stable postfixadmin release and the upgrade it with the new features > added by me (I don't even know how to do this). No, please take the SVN trunk as base. There have been lots of changes (most important: Smarty templates) so that it would mean lots of work if you base your changes on the 2.3.2 release and later want to integrate them in the SVN version. BTW: Please keep the .svn directories in your development directory - they give you several advantages: - you can run "svn up" to integrate changes done in the Postfixadmin SVN in your codebase. This will work automatically as long as you don't edit the same line of code as we do. - you can run "svn diff" to create a patch against "our" code. This will make integration in the official code easier. Both are things that you don't want to do without the help of SVN ;-) > Finally, if you think eclipse is not the right tool to work with > postfixadmin, I hope you can introduce me to "the official" > alternatives to work with. David and I use vi, but I wouldn't go as far as calling it the "Official PostfixAdmin source code editor" ;-) Seriously: take any editor or IDE you want and like. We don't have something like coding guidelines, and for historical reasons we even have some files with 3 and some with 4 spaces as tab replacement. (New files should use 4 spaces.) However there is a very important thing: If you need to copy more than 5 lines of code from an existing file, please consider to put it into functions.inc.php as a function, and replace it with a function call at the original place. If you copy more than 20 lines, this is no longer optional ;-) This might sound a bit strict, but I have some experience from merging copies of similar code. I started this merging when David and I took over the postfixadmin project - for some functions like "edit an alias" there were 4 copies of the code for the same job, with different bugs in each copy :-/ In the meantime I have removed/merged lots of the duplicates, but it's an ongoing job and still not fully done. For example "create $whatever" and "edit $whatever" have many things in common, the most visible difference is INSERT vs. UPDATE. In short: I don't want to have even more code to compare and merge ;-)) > I hope you people can guide me through this, maybe with tutorials or > even by personal contact. Personal contact as in "face to face meeting" might become difficult due to long distances - your name doesn't sound german ;-) > I didn't even know to ask for this in the > postfixadmin-devel mailing list or the svn mailing list, I just > decided to start here and wait for some enlightment from you. This mailinglist is the correct place. The -svn list is read-only to distribute SVN commit messages and diffs. Additionally you can join the #postfixadmin channel on the freenode IRC network. I'm usually available there in the evening (as seen from CET timezone), and David (nick "GingerDog") is there all the day. Be "warned" that you won't get an answer within one or two minutes - there are not too many people in the channel, and some of them (including David) are there 24/7, but obviously not always awake ;-) > I hope I can share this feature with you when it's done and I'm open > for any suggestions you might have. Yes, this sounds like a good feature, and I'm quite sure we'll integrate it in postfixadmin when you have it working. Regards, Christian Boltz -- (1) ZACKBOING: Geräusch von Stirn auf Monitor-Glasscheibe(2), direkte Folge von Biosupgrades, selbst kompilierten Kerneln oder dem versehent- lichen Löschen von 30 Gigabyte Pornofilmen bei einem MySQL-Upgrade. (2) Deswegen kauft man heute oft Flachbildschirme. Die sind weicher. [Ratti in suse-linux] |
|
From: David G. <da...@co...> - 2010-11-25 12:10:47
|
Hi,
> Am Mittwoch, 24. November 2010 schrieb Juan Carlos Gutiérrez Deliot:
>> I'm willing, for personal porpouse, to develop some new feature in
>> postfixadmin, it's about exposing mailbox creation and password
>> changing functionalities through web services in order to integrate
>> a mail server with a portal.
>
> Changing the password, the alias of a mailbox and switching vacaton
> on/off is already available via XMLRPC (but disabled by default in the
> config).
>
> Mailbox creation over XMLRPC sounds like a good feature.
Ditto.
>
> You should base your work on the files in the postfixadmin-cli directory
> (that's a quite new command-line interface for postfixadmin), especially
> on the model/* files. (Well, they should be merged with the "main"
> model/* files, but that's another story ;-)
>
> postfixadmin-cli/model/UserHandler.php already contains functions to
> create a mailbox. Your task will be to
> a) implement admin login over XMLRPC (using a mailbox login is pointless
> when it comes to creating mailboxes ;-)
> b) integrate the mailbox creation in the XMLRPC interface
> c) make sure that you don't create any security holes ;-)
>
> If you need some inspiration how to use the XMLRPC interface, check the
> squirrelmail plugin in the ADDITIONS directory.
It's not overly friendly in setup atm - I'm not sure how many people
have moved to using it - I've got one open 'support request' where
someone's emailed me for help, and i've put off doing anything as I
don't have time / motivation.
> Just take the SVN checkout (or your edited version of it) and make a
> tarball from it with tar czf.
> In theory you could exclude the .svn directories from the tarball, but
> in practise they won't hurt except taking some disk space ;-)
Yes; 'internally' for development, please point the web server to an svn
checkout of the source code. Once you're happy with your changes, send
us a 'diff' file (e.g. 'svn diff > patch.txt') and we'll merge it. Once
we're vaguely happy that you're competent, we'll add you as a developer
to the project, which will mean you can do what you like, when you like
without an official approval stage.
>> Finally, if you think eclipse is not the right tool to work with
>> postfixadmin, I hope you can introduce me to "the official"
>> alternatives to work with.
>
> David and I use vi, but I wouldn't go as far as calling it the "Official
> PostfixAdmin source code editor" ;-)
> Seriously: take any editor or IDE you want and like.
Any editor is fine - emacs, nano, vim, eclipse, netbeans .... use which
ever one you're comfortable with.
>
> We don't have something like coding guidelines, and for historical
> reasons we even have some files with 3 and some with 4 spaces as tab
> replacement. (New files should use 4 spaces.)
I'd rather :
spaces, not tabs
4 space indentation
beyond that i'm not fussed.. I code like :
public function fred($arg1, $arg2) {
if($arg1 == false) {
return true;
}
// etc.
}
>> I hope you people can guide me through this, maybe with tutorials or
>> even by personal contact.
>
> Personal contact as in "face to face meeting" might become difficult due
> to long distances - your name doesn't sound german ;-)
I'm in the UK. Meetings would be difficult for me.... at least normally
(family/work etc)
> Additionally you can join the #postfixadmin channel on the freenode IRC
> network. I'm usually available there in the evening (as seen from CET
> timezone), and David (nick "GingerDog") is there all the day. Be
> "warned" that you won't get an answer within one or two minutes - there
> are not too many people in the channel, and some of them (including
> David) are there 24/7, but obviously not always awake ;-)
If you want my attention, just say my name 'GingerDog' and i'll
eventually realise and respond.
thanks
David.
--
David Goodwin
[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk ]
|
|
From: Juan C. G. D. <jua...@pe...> - 2010-11-26 16:37:40
|
On 25/11/2010 06:54 a.m., David Goodwin wrote:
> Hi,
>
>> Am Mittwoch, 24. November 2010 schrieb Juan Carlos Gutiérrez Deliot:
>>> I'm willing, for personal porpouse, to develop some new feature in
>>> postfixadmin, it's about exposing mailbox creation and password
>>> changing functionalities through web services in order to integrate
>>> a mail server with a portal.
>> Changing the password, the alias of a mailbox and switching vacaton
>> on/off is already available via XMLRPC (but disabled by default in the
>> config).
>>
>> Mailbox creation over XMLRPC sounds like a good feature.
>
> Ditto.
>
>
>> You should base your work on the files in the postfixadmin-cli directory
>> (that's a quite new command-line interface for postfixadmin), especially
>> on the model/* files. (Well, they should be merged with the "main"
>> model/* files, but that's another story ;-)
>>
>> postfixadmin-cli/model/UserHandler.php already contains functions to
>> create a mailbox. Your task will be to
>> a) implement admin login over XMLRPC (using a mailbox login is pointless
>> when it comes to creating mailboxes ;-)
>> b) integrate the mailbox creation in the XMLRPC interface
>> c) make sure that you don't create any security holes ;-)
>>
>> If you need some inspiration how to use the XMLRPC interface, check the
>> squirrelmail plugin in the ADDITIONS directory.
>
> It's not overly friendly in setup atm - I'm not sure how many people
> have moved to using it - I've got one open 'support request' where
> someone's emailed me for help, and i've put off doing anything as I
> don't have time / motivation.
>
>
>> Just take the SVN checkout (or your edited version of it) and make a
>> tarball from it with tar czf.
>> In theory you could exclude the .svn directories from the tarball, but
>> in practise they won't hurt except taking some disk space ;-)
> Yes; 'internally' for development, please point the web server to an svn
> checkout of the source code. Once you're happy with your changes, send
> us a 'diff' file (e.g. 'svn diff> patch.txt') and we'll merge it. Once
> we're vaguely happy that you're competent, we'll add you as a developer
> to the project, which will mean you can do what you like, when you like
> without an official approval stage.
>
>
>
>>> Finally, if you think eclipse is not the right tool to work with
>>> postfixadmin, I hope you can introduce me to "the official"
>>> alternatives to work with.
>> David and I use vi, but I wouldn't go as far as calling it the "Official
>> PostfixAdmin source code editor" ;-)
>> Seriously: take any editor or IDE you want and like.
> Any editor is fine - emacs, nano, vim, eclipse, netbeans .... use which
> ever one you're comfortable with.
>
>
>> We don't have something like coding guidelines, and for historical
>> reasons we even have some files with 3 and some with 4 spaces as tab
>> replacement. (New files should use 4 spaces.)
> I'd rather :
>
> spaces, not tabs
> 4 space indentation
>
> beyond that i'm not fussed.. I code like :
>
> public function fred($arg1, $arg2) {
> if($arg1 == false) {
> return true;
> }
> // etc.
> }
>
>
>
>
>
>>> I hope you people can guide me through this, maybe with tutorials or
>>> even by personal contact.
>> Personal contact as in "face to face meeting" might become difficult due
>> to long distances - your name doesn't sound german ;-)
>
> I'm in the UK. Meetings would be difficult for me.... at least normally
> (family/work etc)
>
>
>> Additionally you can join the #postfixadmin channel on the freenode IRC
>> network. I'm usually available there in the evening (as seen from CET
>> timezone), and David (nick "GingerDog") is there all the day. Be
>> "warned" that you won't get an answer within one or two minutes - there
>> are not too many people in the channel, and some of them (including
>> David) are there 24/7, but obviously not always awake ;-)
>
> If you want my attention, just say my name 'GingerDog' and i'll
> eventually realise and respond.
>
>
> thanks
> David.
Thank you guys, I really appreciate your help.
When I said personal contact I meant contact via "direct" email or maybe
chat, It was funny, Christian made laugh a lot with my name not sounding
german. In fact, I'm from Colombia and we here are not used to use IRC
as a usual communication media but I think it's time time learn
something about it.
@Christian: I couldn't find the command-line interface directory (not
even in google), just the cli files in the scripts folder and another
UserHandler.php file inside scripts/models-ext/. Is that the file you
meant for me to check? I'm feeling a bit dumb with this, all you said
sounds quite obvious but I'm still a bit loss here.
Thanks again.
|
|
From: Christian B. <pos...@cb...> - 2010-11-27 00:03:37
|
Hello, Am Freitag, 26. November 2010 schrieb Juan Carlos Gutiérrez Deliot: > On 25/11/2010 06:54 a.m., David Goodwin wrote: > > [Christian Boltz] > >> We don't have something like coding guidelines, and for historical > >> reasons we even have some files with 3 and some with 4 spaces as > >> tab replacement. (New files should use 4 spaces.) > > > > I'd rather : [...] I just summarized that on the under-utilized wiki @SF: https://sourceforge.net/apps/mediawiki/postfixadmin/index.php?title=Coding_guidelines Let's hope we can point lots of people there *g* BTW: If you want write access to the wiki, see https://sourceforge.net/apps/mediawiki/postfixadmin/index.php?title=Main_Page > When I said personal contact I meant contact via "direct" email or > maybe chat, It was funny, Christian made laugh a lot with my name > not sounding german. ;-) > @Christian: I couldn't find the command-line interface directory (not > even in google), just the cli files in the scripts folder and another > UserHandler.php file inside scripts/models-ext/. Is that the file you > meant for me to check? Yes, exactly. The commandline interface is quite new and unfortunately not mentioned in the documentation - and therefore more or less invisible for Google... The files in scripts/models-ext/ will hopefully be merged with those in model/ - but that should not stop you. The worst thing that can happen is that you have to change the include path ;-) If you want/need to change something inside scripts/models-ext/, please send a short mail before to avoid that we get a marge problem. @David: please see my other mail about merging the classes and comment there on the changes. > I'm feeling a bit dumb with this, all you said > sounds quite obvious but I'm still a bit loss here. I'd say you are on the right track ;-) Regards, Christian Boltz -- 'blah blahb lah' ... I have no idea where it's coming from, grepping rug and zmd sources does not have any matches. [from https://bugzilla.novell.com/show_bug.cgi?id=157405] |
