On 21:49, Wed 03 Sep 08, Christian Boltz wrote:
> Hello,
>
> @Michael: postfixadmin-svn is only for commits. If you want to commment
> on a commit, please send your mail to postfixadmin-devel. I'm forwarding
> your mail this time. (And sorry for being some days late - we had 4 days
> "Weinfest" (wine festival) here, so I didn't read my mails for some days.)
No problem.
It's just that I did not think and do what I do with the projects I'm
more active on: hit SHIFT-l
>
> @Gingerdog: Please see also my comment below. I think there's a better
> solution than having the configuration inside the script...
I think it's best to use something like vacation.conf as filename so
it's more clear it's a file you can edit.
>
> ---------- Forwarded message ----------
>
> Re: SF.net SVN: postfixadmin:[453] trunk/VIRTUAL_VACATION
> Date: Sun, August 31 2008
> From: Michiel van Baak
> To: pos...@li...
>
> On 20:17, Sun 31 Aug 08, Gin...@us... wrote:
> > Revision: 453
> > http://postfixadmin.svn.sourceforge.net/postfixadmin/?rev=453&view=rev
> > Author: GingerDog
> > Date: 2008-08-31 20:17:23 +0000 (Sun, 31 Aug 2008)
> >
> > Log Message:
> > -----------
> > vacation.pl: plenty of refactoring; I think this addresses all hte points at
> https://sourceforge.net/forum/message.php?msg_id=5205584
> >
> > Modified Paths:
> > --------------
> > trunk/VIRTUAL_VACATION/tests/asterisk-email.txt
> > trunk/VIRTUAL_VACATION/tests/test-email.txt
> > trunk/VIRTUAL_VACATION/tests/test.sh
> > trunk/VIRTUAL_VACATION/vacation.pl
> >
> <snip>
> > Modified: trunk/VIRTUAL_VACATION/vacation.pl
> > ===================================================================
> > --- trunk/VIRTUAL_VACATION/vacation.pl 2008-08-31 14:15:48 UTC (rev 452)
> > +++ trunk/VIRTUAL_VACATION/vacation.pl 2008-08-31 20:17:23 UTC (rev 453)
> > @@ -99,8 +99,8 @@
> > my $db_host = '';
> >
> > # connection details
> > -my $db_username = 'your_username';
> > -my $db_password = 'your_password';
> > +my $db_username = 'dg';
> > +my $db_password = 'gingerdog';
> > my $db_name = 'postfix';
>
> Are you sure you want to change those ? ;)
> --
>
> Michiel van Baak
> mi...@va...
> http://michiel.vanbaak.eu
> GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x71C946BD
>
> "Why is it drug addicts and computer aficionados are both called users?"
>
> -------------------------------------------------------
> [end forwarded message]
>
>
> I think we should find a better way than editing the script ;-)
>
> The following method should work:
>
> a) in vacation.pl, change the "my $whatever" lines to something like
>
> our $db_username = 'your_username';
> our $db_password = 'your_password';
>
> b) We can then advise users to put their config to /etc/postfixadmin/vacation
> which could read like
>
> $db_username = 'cboltz';
> $db_password = 'topsecret';
> 1; # must return true, see perldoc -f require
>
> c) In vacation.pl, add (below the "our $whatever" lines)
>
> $configfile = "/etc/postfixadmin/vacation";
> if (-f $configfile) require "$configfile";
>
>
> (I'll accept other/better proposals for the config filename if you don't
> like it.)
>
>
> Regards,
>
> Christian Boltz
> --
> >gehe zu 'http://www.linuxiso.org/'
> Zu Fu??
> [> Michael Meyer und Thorsten Haude in suse-linux]
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
--
Michiel van Baak
mi...@va...
http://michiel.vanbaak.eu
GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x71C946BD
"Why is it drug addicts and computer aficionados are both called users?"
|
