postfixadmin-devel

[Postfixadmin-devel] 2.2?

[David G. <da...@co...>]

Hi,

2.2.0rc5 packages/downloads are available on sf.net

I'd like to think we'll soon have a 2.2.0 release! Does anyone know of 
any blockers? Can some of you try testing it please?

(rc4 didn't include mysql table creation for new installs, which was a 
slight flaw!)


thanks
David.

-- 
David Goodwin

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Re: [Postfixadmin-devel] 2.2?

[Matt R. <li...@ma...>]

On Wed, April 23, 2008 2:52 pm, David Goodwin wrote:
> Hi,
>
> 2.2.0rc5 packages/downloads are available on sf.net
>
> I'd like to think we'll soon have a 2.2.0 release! Does anyone know of
> any blockers? Can some of you try testing it please?
>
> (rc4 didn't include mysql table creation for new installs, which was a
> slight flaw!)
>
>
> thanks
> David.
>
> --
> David Goodwin
>
> [ david at codepoets dot co dot uk ]
> [ http://www.codepoets.co.uk       ]
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
> Don't miss this year's exciting event. There's still time to save $100.
> Use priority code J8TL2D2.
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>

Was the fetchmail table added to the install?
I just tried to build a new install to see if the fetchmail table would
now be build but it wasn't.  This was a fresh install of postfixadmin
from the svn
(https://postfixadmin.svn.sourceforge.net/svnroot/postfixadmin/trunk)

The setup.php ran without any errors.

The error I received in my web browser was:

DEBUG INFORMATION:
Invalid query: Table 'postfix.fetchmail' doesn't exist

Please check the documentation and website for more information.

Postfix Admin
Forums

Thanks
-Matt
-- 
Matt Rude
www.mattrude.com

Re: [Postfixadmin-devel] 2.2?

[David G. <da...@co...>]

Matt Rude wrote :
> 
> Was the fetchmail table added to the install?

Historically the tables etc for this were always in fetchmail.php; it
probably makes sense for it to move into upgrade.php

Does the fetchmail stuff work with PostgreSQL?

Thanks for the feedback,

David.

-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Re: [Postfixadmin-devel] 2.2?

[Christian B. <pos...@cb...>]

Hello,

Am Freitag, 25. April 2008 schrieb David Goodwin:
> Matt Rude wrote :
> > Was the fetchmail table added to the install?
>
> Historically the tables etc for this were always in fetchmail.php; it
> probably makes sense for it to move into upgrade.php

Right. Done for MySQL.

Please add the CREATE TABLE statements for PgSQL - I have already 
included an empty function at the end of upgrade.php.

> Does the fetchmail stuff work with PostgreSQL?

I have never tested it with PostgreSQL, but the fetchmail.php code looks 
good. IMHO it should work or only need very small fixes.

I have no idea if ADDITIONS/fetchmail.pl is prepared for PostgreSQL.


Regards,

Christian Boltz
-- 
Die SuSE 9.2 ist ein gutes Argument 20 Euro in die Hand zu nehmen
und ein DVD-Laufwerk zu kaufen.   [Manfred Tremmel in suse-linux]

Re: [Postfixadmin-devel] 2.2?

[Christian B. <pos...@cb...>]

Hello,

Am Mittwoch, 23. April 2008 schrieb David Goodwin:
> 2.2.0rc5 packages/downloads are available on sf.net
>
> I'd like to think we'll soon have a 2.2.0 release! Does anyone know
> of any blockers? Can some of you try testing it please?

I installed it on a production server (which was using an early svn 
version before) and instantly found a blocker bug: common.php redirects 
to setup.php if config.inc.php doesn't exist or $CONF['configured'] is 
FALSE.
There's nothing wrong with that - unless you include() upgrade.php, 
which include()s common.php in setup.php ;-)  The result was a nice 
redirect loop from and to setup.php.

Good news: I already fixed this in SVN some hours ago (r343).


I also entered some possible enhancements for the colored markers to the 
tracker - for post-2.2.


> (rc4 didn't include mysql table creation for new installs, which was
> a slight flaw!)

Are you sure? I doubt ;-)

The tables are created in upgrade_5_mysql, which is basically a copy of 
SVN r1 DATABASE_MYSQL.TXT. (Yes, it is intentional that there are some 
ALTER statements before - they cover pre-sourceforge SVN r1 changes.)

And yes, I just tested this with a completely fresh install on a fresh 
database without any existing tables, while having upgrade_1_mysql 
completely commented out.


To be exact, upgrade_2_pgsql should be renamed to upgrade_5_pgsql (I 
assume you used SVN r1 as base?)


I just found out that create mailbox and create admin don't enforce the 
min_password_length - but this isn't a blocker for 2.2. We should 
probably fix this by merging create and edit (see fetchmail for an 
example) after 2.2 is out.


BTW: Don't forget to change the "check for updates" URL when creating 
the 2.2 tarball ;-)

Apropos... - http://postfixadmin.sourceforge.net/update-check.php 
results in a 404 :-(  I have created one that at least redirects to the 
home page - please run SVN up on the webspace (and implement 
update-check.php if you have some time).


Regards,

Christian Boltz
-- 
wer Windows in irgendeiner Form verwendet (ausser
als abschreckendes Beispiel) ist selbst schuld.
[Carsten Becher in suse-linux]

Re: [Postfixadmin-devel] 2.2?

[Christian B. <pos...@cb...>]

Hello,

(I assume your mail should have gone to the mailinglist? ;-)

Am Samstag, 26. April 2008 schrieb David Goodwin:
> > BTW: Don't forget to change the "check for updates" URL when
> > creating the 2.2 tarball ;-)
>
> So, I can release 2.2 once that's done then?

If it istn't too much work, please add the "CREATE TABLE fetchmail" for 
PgSQL to upgrade.php.

Other minor things (more or less optional):
- update /CHANGELOG.TXT  (if you remember which SVN revision each rc 
  was, please note it there)
- update contributors in /LICENSE.TXT (at least the main contributors)
- DOCUMENTS/POSTFIXADMIN.txt is outdated (still refers to /admin)

Otherwise: yes, I think we can finally release 2.2 :-)


Regards,

Christian Boltz
-- 
[ Yes ] [ No ]
... used for harmless errors or simple questions: "It's high time you
had your cup of coffee! Would you like your KDE to prepare one for you?"
[Lukas Ocilka in opensuse-factory - YaST2 button styleguide]