postfixadmin-devel — Postfix Admin development talk - users are also welcome

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

By the way...

I though the vacation.pl in trunk had the new options in it for start 
and stop dates? I didn't see that in there anywhere...

On 2013-03-26 4:47 PM, Tanstaafl <tan...@li...> wrote:
> On 2013-03-26 7:20 AM, David Goodwin <da...@co...> wrote:
>> Hi,
>>
>> I'd probably merge it for you
>>
>> Ideally make the patch against the vacation.pl which is in trunk.
>> That would make my life easiest.
>
> Ok, great, thanks David.
>
> Actually, I see that Rudi did already merge the prior version that had
> both a new option, a new variable, and added a third test.
>
> I changed this to just a single new variable, and a single test.
>
> See what you think (patch attached, diffed against vacation.pl in trunk)...
>
> Thanks,
>
> Charles

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

On 2013-03-26 7:20 AM, David Goodwin <da...@co...> wrote:
> Hi,
>
> I'd probably merge it for you
>
> Ideally make the patch against the vacation.pl which is in trunk.
> That would make my life easiest.

Ok, great, thanks David.

Actually, I see that Rudi did already merge the prior version that had 
both a new option, a new variable, and added a third test.

I changed this to just a single new variable, and a single test.

See what you think (patch attached, diffed against vacation.pl in trunk)...

Thanks,

Charles

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[David G. <da...@co...>]

Hi,

I'd probably merge it for you

Ideally make the patch against the vacation.pl which is in trunk. That would make my life easiest.


David.

On 26 Mar 2013, at 11:17, Tanstaafl <tan...@li...> wrote:

> Well, I guess Rudi went on vacation or something...
> 
> I'm sure glad he stayed long enough for me to get this working. :)
> 
> So, if I were to attempt to create a patch for this (shudder - I'm not 
> the best one to be doing this)), which vacation.pl should the path be 
> made against (I currently have 2.3.6 installed)? And if I got it right, 
> would anyone other than Rudi be inclined to accept it and incorporate it 
> into the core vacation.pl?
> 
> The change is fairly minor, and it greatly (imho) improves (reduces the 
> number of messages that the vacation message should *not* respond to), 
> as well as makes it fairly trivial for admins to add their own strings 
> to the list of strings to test for.
> 
> Thanks...
> 
> On 2013-03-18 4:00 PM, Tanstaafl <tan...@li...> wrote:
>> Ok, its been almost a week, and this is working perfectly...
>> 
>> Rudi, did you get a chance to look at this yet? It (just the one new
>> variable, only one test performed in the 'sub
>> check_and_clean_from_address' function) is so much simpler than what we
>> had before (a new option and new variable, and 3 tests in the 'sub
>> check_and_clean_from_address' function)...
>> 
>> Thanks again for your help!
>> 
>> Charles
>> 
>> Quoting the relevant part of my last email on this, showing what I am
>> using now)...
>> 
>> On 2013-03-13 11:43 AM, Tanstaafl <tan...@li...> wrote:
>> <snip>
>>> Wouldn't it make more sense to adjust the defaults for the custom
>>> pattern to include all of the values in the immediately prior two tests,
>>> and change this to just the one test, instead of basically having three
>>> separate tests (one to test the local part, the next to test the domain
>>> part, and finally our new custom one to test the whole thing?
>>> 
>>> And if this is ultimately the desired goal, we could rename the
>>> variables one last time, and end up with something like:
>>> 
>>> # This is the list of strings that is checked against both the
>>> # envelope sender and any/all From header addresses that, if
>>> # matched, results in the vacation message not being sent.
>>> our $noreply_pattern =
>>> 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter';
>>> 
>>> Then the new 'sub check_and_clean_from_address' function would be
>>> something like:
>>> 
>>>> sub check_and_clean_from_address {
>>>>      my ($address) = @_;
>>>>      my $logger = get_logger();
>>>> 
>>>>      if($address =~ /^.*($noreply_pattern).*/i) ) {
>>>>          $logger->debug("sender $address contains $1 - will not send vacation message");
>>>>          exit(0);
>>>>      }
>>>>      $address = strip_address($address);
>>>>      if($address eq '') {
>>>>          $logger->error("Address $address is not valid; exiting");
>>>>          exit(0);
>>>>      }
>>>>      #$logger->debug("Address cleaned up to $address");
>>>>      return $address;
>>>> }
>> 
>> 
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_mar
>> _______________________________________________
>> Postfixadmin-devel mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>> 
> 
> 
> ------------------------------------------------------------------------------
> Own the Future-Intel&reg; Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest.
> Compete for recognition, cash, and the chance to get your game 
> on Steam. $5K grand prize plus 10 genre and skill prizes. 
> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

Well, I guess Rudi went on vacation or something...

I'm sure glad he stayed long enough for me to get this working. :)

So, if I were to attempt to create a patch for this (shudder - I'm not 
the best one to be doing this)), which vacation.pl should the path be 
made against (I currently have 2.3.6 installed)? And if I got it right, 
would anyone other than Rudi be inclined to accept it and incorporate it 
into the core vacation.pl?

The change is fairly minor, and it greatly (imho) improves (reduces the 
number of messages that the vacation message should *not* respond to), 
as well as makes it fairly trivial for admins to add their own strings 
to the list of strings to test for.

Thanks...

On 2013-03-18 4:00 PM, Tanstaafl <tan...@li...> wrote:
> Ok, its been almost a week, and this is working perfectly...
>
> Rudi, did you get a chance to look at this yet? It (just the one new
> variable, only one test performed in the 'sub
> check_and_clean_from_address' function) is so much simpler than what we
> had before (a new option and new variable, and 3 tests in the 'sub
> check_and_clean_from_address' function)...
>
> Thanks again for your help!
>
> Charles
>
> Quoting the relevant part of my last email on this, showing what I am
> using now)...
>
> On 2013-03-13 11:43 AM, Tanstaafl <tan...@li...> wrote:
> <snip>
>> Wouldn't it make more sense to adjust the defaults for the custom
>> pattern to include all of the values in the immediately prior two tests,
>> and change this to just the one test, instead of basically having three
>> separate tests (one to test the local part, the next to test the domain
>> part, and finally our new custom one to test the whole thing?
>>
>> And if this is ultimately the desired goal, we could rename the
>> variables one last time, and end up with something like:
>>
>> # This is the list of strings that is checked against both the
>> # envelope sender and any/all From header addresses that, if
>> # matched, results in the vacation message not being sent.
>> our $noreply_pattern =
>> 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter';
>>
>> Then the new 'sub check_and_clean_from_address' function would be
>> something like:
>>
>>> sub check_and_clean_from_address {
>>>       my ($address) = @_;
>>>       my $logger = get_logger();
>>>
>>>       if($address =~ /^.*($noreply_pattern).*/i) ) {
>>>           $logger->debug("sender $address contains $1 - will not send vacation message");
>>>           exit(0);
>>>       }
>>>       $address = strip_address($address);
>>>       if($address eq '') {
>>>           $logger->error("Address $address is not valid; exiting");
>>>           exit(0);
>>>       }
>>>       #$logger->debug("Address cleaned up to $address");
>>>       return $address;
>>> }
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

Ok, its been almost a week, and this is working perfectly...

Rudi, did you get a chance to look at this yet? It (just the one new 
variable, only one test performed in the 'sub 
check_and_clean_from_address' function) is so much simpler than what we 
had before (a new option and new variable, and 3 tests in the 'sub 
check_and_clean_from_address' function)...

Thanks again for your help!

Charles

Quoting the relevant part of my last email on this, showing what I am 
using now)...

On 2013-03-13 11:43 AM, Tanstaafl <tan...@li...> wrote:
<snip>
> Wouldn't it make more sense to adjust the defaults for the custom
> pattern to include all of the values in the immediately prior two tests,
> and change this to just the one test, instead of basically having three
> separate tests (one to test the local part, the next to test the domain
> part, and finally our new custom one to test the whole thing?
>
> And if this is ultimately the desired goal, we could rename the
> variables one last time, and end up with something like:
>
> # This is the list of strings that is checked against both the
> # envelope sender and any/all From header addresses that, if
> # matched, results in the vacation message not being sent.
> our $noreply_pattern =
> 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter';
>
> Then the new 'sub check_and_clean_from_address' function would be
> something like:
>
>> sub check_and_clean_from_address {
>>      my ($address) = @_;
>>      my $logger = get_logger();
>>
>>      if($address =~ /^.*($noreply_pattern).*/i) ) {
>>          $logger->debug("sender $address contains $1 - will not send vacation message");
>>          exit(0);
>>      }
>>      $address = strip_address($address);
>>      if($address eq '') {
>>          $logger->error("Address $address is not valid; exiting");
>>          exit(0);
>>      }
>>      #$logger->debug("Address cleaned up to $address");
>>      return $address;
>> }

Re: [Postfixadmin-devel] Dynamic alias

[Milos K. <mil...@ta...>]

Will do, still working on it :)



On 03/15/2013 12:48 AM, Christian Boltz wrote:
> Hello,
> 
> Am Dienstag, 12. März 2013 schrieb Milos Kaurin:
>> Is there an easy way to enable an alias , like
>> "eve...@so..." that will check if the domain is active, and
>> send the mail to all active users?
> 
> Not on the PostfixAdmin side. The only thing I've seen is a feature 
> request about it, but nobody implemented it yet.
> 
>> I know that the manual way includes altering the alias maps sql query
>> to have an "if" statement with a hardcoded address such ass
>> "eve...@so...", but I'm looking for a more elegant solution
>> first.
> 
> That might be a working solution, and doing it in sql when querying the 
> database has the advantage that the list of alias targets will never be 
> outdated.
> 
> If you implement it this way, please post the query you use - other 
> users might also need it ;-)
> 
> 
> Regards,
> 
> Christian Boltz
> 

Re: [Postfixadmin-devel] Dynamic alias

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 12. März 2013 schrieb Milos Kaurin:
> Is there an easy way to enable an alias , like
> "eve...@so..." that will check if the domain is active, and
> send the mail to all active users?

Not on the PostfixAdmin side. The only thing I've seen is a feature 
request about it, but nobody implemented it yet.

> I know that the manual way includes altering the alias maps sql query
> to have an "if" statement with a hardcoded address such ass
> "eve...@so...", but I'm looking for a more elegant solution
> first.

That might be a working solution, and doing it in sql when querying the 
database has the advantage that the list of alias targets will never be 
outdated.

If you implement it this way, please post the query you use - other 
users might also need it ;-)


Regards,

Christian Boltz
-- 
Wer braucht z.B. einen 3 GHz - getakteten PC mit 1 GByte DDR-RAM, wenn
dann daran nur eine lahme DMA-133-IDE-Festplatte rödelt, aber auch ein
geiles Modem für superschnelles Surfvergnügen und eine analoge TV-Karte
integriert sind? Das ist wie ein Ferrari auf Holzspeichenrädern und mit
2 x 15 Watt Lenco-Auto-Kassettenradio im Handschuhfach.
[Matthias Houdek in suse-linux]

Re: [Postfixadmin-devel] SOLVED - Re: Please help getting my multi-string from header check matching...

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 12. März 2013 schrieb Tanstaafl:
> What are the chances of getting these changes added to the core 
> vacation.pl code?

Rudi has commit access, so I'd say the chances are quite good ;-))

(Rudi, I'm not sure if you also have the permissions to close tracker 
items etc. If not, please tell me.)


Regards,

Christian Boltz
-- 
Was schlagen sie vor, Prof. Dr. cvs. Boltz? :-)
[Ratti in fontlinge-devel]

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Christian B. <pos...@cb...>]

Hello,

Am Mittwoch, 13. März 2013 schrieb Tanstaafl:
> There is one typo for sure: line 599, $adress should be $address

Fixed in SVN r1444 (but only this typo - I didn't do anything on the 
other things you mentioned).

> And finally, last question...
> 
> What is the practical limit on the number of characters that can be
> included in this variable?

This is only limited by perl, and from what I found via google, you'll 
hit the limit of readability before you even need to think about the 
perl limit ;-)

Details: http://mushclient.com/pcre/pcre.html#SEC3


Regards,

Christian Boltz
-- 
> http://www.bahn.de hat auch einen Routenplaner [...] für
> Fahrrad und zu Fuß, wenn die Entfernung nicht zu weit ist.
Nur, was bedeutet "2. Klasse" auf dem Fahrrad? ;-)
[> Bernd Brodesser und Ralf Cirksena in suse-linux]

Re: [Postfixadmin-devel] Adding the users Real Name to the vacation From: response - WAS Re: Please help getting my multi-string from header check matching...

[Christian B. <pos...@cb...>]

Hello,

first: wow, I really like to see so much traffic on the mailinglist! :-)

Unfortunately this also means my personal mailq (as in "read the mails") 
is more than full, so my answer is a bit late.

Am Montag, 11. März 2013 schrieb Rudi Floren:
> In line 546 the RFC 822 Style (e.g. "Real NAME" <us...@ex...> )
> is  converted to RFC 821 (us...@ex...)
> I don't know why actually.
> 
> @christian do know something about that?

Most of vacation.pl is "grown code" from the times before I started to 
work on PostfixAdmin, and I focus more on the PHP side of things. (Maybe 
David knows more?)

I had a short look at vacation.pl. strip_address() is called in various 
places, and if you check the code around the calls, it is needed in most 
cases to check or validate the mail address etc.

OTOH, keeping the original value in another variable (and using it as 
needed) shouldn't be hard. Nevertheless keep in mind that the realname 
could contain funny[tm] stuff, so please keep an eye on security ;-)


Regards,

Christian Boltz
-- 
> Manfred, Du solltest so spaet keine Emails mehr schreiben :-)
Danke für die Berichtigung, werd mir den Tipp hinter die Ohren schreiben
und nur noch Mailen, wenn ich die Augen zumindestens zu einem drittel 
aufkriege. [> Thomas Hertweck und Manfred Tremmel in suse-linux]

Re: [Postfixadmin-devel] Using the 'Real Name' in the autoreply message

[Tanstaafl <tan...@li...>]

Hi Jan,

Ouch... this patch touches a lot of files...

Is this code included in 2.3.6? Or maybe trunk?

I'd rather not apply this many changes myself (I know just enough 
programming to be very dangerous - but at least I know it)... ;)

I'm still on 2.3.4 (not too worried about security issues, as 
postfixadmin is on a secured box with no access from outside), but if 
this code is available in 2.3.6, that would be a huge reason for me to 
upgrade now.

If it is available in trunk (soon to be 3.0?), then I guess I'll just 
have to wait...

On that note... does anyone know if 3.0 will ship anytime in the near 
future (ie, next few months, or at least this year)?

Thanks again Jan, even if I can't take advantage of it now, I really do 
appreciate you getting the code done...

Charles

On 2013-03-14 11:43 AM, Jan Kruis <pf...@cr...> wrote:
> Hi Charles,
>
> this is the url to the patch
>
> http://sourceforge.net/p/postfixadmin/patches/116/
>
> http://sourceforge.net/p/postfixadmin/patches/115/
>
> Jan
>
>
> Op 14 mrt 2013, om 12:04 heeft Tanstaafl het volgende geschreven:
>
>> Hi Jan,
>>
>> Where did you post these patches?
>>
>> Any chance you could post a reply to mu bug/Feature Request, and include
>> a link to the patches?
>>
>> Were they accepted into the core code?
>>
>> Thanks very much
>>
>> Charles
>>
>> On 2013-03-13 4:18 PM, Jan Kruis <pf...@cr...> wrote:
>>> Hi,
>>>
>>> I post a patch 155 & 116 "real name" on 2012-05-24 to do that
>>>
>>> a part of this patch reads out of the pfa_database and replace this in the from string by vacation.pl
>>>
>>> Regards Jan Kruis
>>>
>>>
>>> Op 12 mrt 2013, om 19:53 heeft Tanstaafl het volgende geschreven:
>>>
>>>> Hello all,
>>>>
>>>> I have a Feature Request for this at:
>>>>
>>>> https://sourceforge.net/p/postfixadmin/feature-requests/30/
>>>>
>>>> To put it simply, I want the vacation message to show as:
>>>>
>>>> From: "Real Name" <em...@ex...>
>>>>
>>>> not just
>>>>
>>>> em...@ex...

Re: [Postfixadmin-devel] Using the 'Real Name' in the autoreply message

[Jan K. <pf...@cr...>]

Hi Charles,

this is the url to the patch

http://sourceforge.net/p/postfixadmin/patches/116/

http://sourceforge.net/p/postfixadmin/patches/115/

Jan


Op 14 mrt 2013, om 12:04 heeft Tanstaafl het volgende geschreven:

> Hi Jan,
> 
> Where did you post these patches?
> 
> Any chance you could post a reply to mu bug/Feature Request, and include 
> a link to the patches?
> 
> Were they accepted into the core code?
> 
> Thanks very much
> 
> Charles
> 
> On 2013-03-13 4:18 PM, Jan Kruis <pf...@cr...> wrote:
>> Hi,
>> 
>> I post a patch 155 & 116 "real name" on 2012-05-24 to do that
>> 
>> a part of this patch reads out of the pfa_database and replace this in the from string by vacation.pl
>> 
>> Regards Jan Kruis
>> 
>> 
>> Op 12 mrt 2013, om 19:53 heeft Tanstaafl het volgende geschreven:
>> 
>>> Hello all,
>>> 
>>> I have a Feature Request for this at:
>>> 
>>> https://sourceforge.net/p/postfixadmin/feature-requests/30/
>>> 
>>> To put it simply, I want the vacation message to show as:
>>> 
>>> From: "Real Name" <em...@ex...>
>>> 
>>> not just
>>> 
>>> em...@ex...
>>> 
>>> ------------------------------------------------------------------------------
>>> Everyone hates slow websites. So do we.
>>> Make your web apps faster with AppDynamics
>>> Download AppDynamics Lite for free today:
>>> http://p.sf.net/sfu/appdyn_d2d_mar
>>> _______________________________________________
>>> Postfixadmin-devel mailing list
>>> Pos...@li...
>>> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>> 
>> 
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_mar
>> _______________________________________________
>> Postfixadmin-devel mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>> 
> 
> 
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel

Re: [Postfixadmin-devel] Using the 'Real Name' in the autoreply message

[Tanstaafl <tan...@li...>]

Hi Jan,

Where did you post these patches?

Any chance you could post a reply to mu bug/Feature Request, and include 
a link to the patches?

Were they accepted into the core code?

Thanks very much

Charles

On 2013-03-13 4:18 PM, Jan Kruis <pf...@cr...> wrote:
> Hi,
>
> I post a patch 155 & 116 "real name" on 2012-05-24 to do that
>
> a part of this patch reads out of the pfa_database and replace this in the from string by vacation.pl
>
> Regards Jan Kruis
>
>
> Op 12 mrt 2013, om 19:53 heeft Tanstaafl het volgende geschreven:
>
>> Hello all,
>>
>> I have a Feature Request for this at:
>>
>> https://sourceforge.net/p/postfixadmin/feature-requests/30/
>>
>> To put it simply, I want the vacation message to show as:
>>
>> From: "Real Name" <em...@ex...>
>>
>> not just
>>
>> em...@ex...
>>
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_mar
>> _______________________________________________
>> Postfixadmin-devel mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>

Re: [Postfixadmin-devel] Using the 'Real Name' in the autoreply message

[Jan K. <pf...@cr...>]

Hi,

I post a patch 155 & 116 "real name" on 2012-05-24 to do that

a part of this patch reads out of the pfa_database and replace this in the from string by vacation.pl

Regards Jan Kruis


Op 12 mrt 2013, om 19:53 heeft Tanstaafl het volgende geschreven:

> Hello all,
> 
> I have a Feature Request for this at:
> 
> https://sourceforge.net/p/postfixadmin/feature-requests/30/
> 
> To put it simply, I want the vacation message to show as:
> 
> From: "Real Name" <em...@ex...>
> 
> not just
> 
> em...@ex...
> 
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

Ok, I got curious and went ahead and tried this, and it seems to be 
working just fine.

I tested with various strings (at the beginning, in the middle and the 
end of the defined variable), and everything that should have matched, 
did, and everything else produced a proper vacation response...

So, I now have the following in vacation.pl:

> # $noreply_pattern is the list of strings that is checked against both the
> # envelope sender and any/all From header addresses that, if matched,
> # results in the vacation message not being sent.
> # By default, vacation messages will be sent to all senders that can not
> # definitively be determined to be email lists or other senders that should
> # not be replied to, like messages from social networking sites.
> # Defaults are: 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter'
> # MODIFY AT YOUR OWN RISK!
> our $noreply_pattern = 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter'

then the check_and_clean_from_address function:

> # Check sender against the new configurable $noreply_pattern to make sure
> # the email wasn't sent by a mailing list or some other kind of automated
> # messaging system; if it was, then we abort after appropriate logging.
> sub check_and_clean_from_address {
>     my ($address) = @_;
>     my $logger = get_logger();
>
>     if($address =~ /^.*($noreply_pattern).*/i) {
>         $logger->debug("sender '$address' contains '$1'; will not send vacation message; aborting");
>         exit(0);
>     }
>     $address = strip_address($address);
>     if($address eq "") {
>         $logger->error("Address $address is not valid; exiting");
>         exit(0);
>     }
>     #$logger->debug("Address cleaned up to $address");
>     return $address;
> }

Thanks again to Rudi for doing the heavy lifting and getting this working!

Charles

On 2013-03-13 12:45 PM, Tanstaafl <tan...@li...> wrote:
> Corrections to previous post below, and also an additional question...
>
> On 2013-03-13 11:43 AM, Tanstaafl <tan...@li...> wrote:
>> 1. only ONE new variable that contains all of the predetermined strings,
>> and
>
> Sorry, sent that too soon without proofing. This should have all read:
>
> There are two advantages to this...
>
> 1. Only the new variable (with pre-determined defaults) is needed
> instead of a new option and a new variable with just a comment
> explaining how to modify this variable to include new strings or tweak
> existing ones or even remove them if they are causing too many false
> positives:,
>
> So we'd now have (which can also optionally go into vacation.conf):
>
>> # This is the list of strings that is checked against both the
>> # envelope sender and any/all From header addresses that, if
>> # matched, results in the vacation message not being sent.
>   > # MODIFY AT YOUR OWN RISK!
>> our $noreply_pattern =
>> 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter';
>
> Then the new 'sub check_and_clean_from_address' function would be
> something like:
>
>> sub check_and_clean_from_address {
>>       my ($address) = @_;
>>       my $logger = get_logger();
>>
>>       if($address =~ /^.*($noreply_pattern).*/i) ) {
>>           $logger->debug("sender $address contains $1 - will not send vacation message");
>>           exit(0);
>>       }
>>       $address = strip_address($address);
>>       if($address eq '') {
>>           $logger->error("Address $address is not valid; exiting");
>>           exit(0);
>>       }
>>       #$logger->debug("Address cleaned up to $address");
>>       return $address;
>> }
>>
>> And finally, last question...
>>
>> What is the practical limit on the number of characters that can be
>> included in this variable?
>
> One other question, already asked in a prior email, is...
>
> Am I correct in my comments, that BOTH the envelope sender and any other
> From headers are tested? Or does this check_and_clean_from_address
> function only test the envelope sender? If so (and I think it might),
> then we may need to have two new variables:
>
> $noreply_pattern_envelope
> $noreply_pattern_header
>
> and appropriate comment changes.
>
>> So, before I enable these changes, what do you think? If this looks
>> correct, I'll enable it and test it live for the next few weeks on my
>> server...
>>
>> Thanks again Rudi!

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

On 2013-03-13 12:45 PM, Tanstaafl <tan...@li...> wrote:
> Corrections to previous post below, and also an additional question...
>
> On 2013-03-13 11:43 AM, Tanstaafl<tan...@li...>  wrote:
>> >1. only ONE new variable that contains all of the predetermined strings,
>> >and
> Sorry, sent that too soon without proofing. This should have all read:
>
> There are two advantages to this...

Crap, did it again...

The second advantage is, of course, the *simplified* 'sub 
check_and_clean_from_address' function...

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

Corrections to previous post below, and also an additional question...

On 2013-03-13 11:43 AM, Tanstaafl <tan...@li...> wrote:
> 1. only ONE new variable that contains all of the predetermined strings,
> and

Sorry, sent that too soon without proofing. This should have all read:

There are two advantages to this...

1. Only the new variable (with pre-determined defaults) is needed 
instead of a new option and a new variable with just a comment 
explaining how to modify this variable to include new strings or tweak 
existing ones or even remove them if they are causing too many false 
positives:,

So we'd now have (which can also optionally go into vacation.conf):

> # This is the list of strings that is checked against both the
> # envelope sender and any/all From header addresses that, if
> # matched, results in the vacation message not being sent.
 > # MODIFY AT YOUR OWN RISK!
> our $noreply_pattern =
> 'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter';

Then the new 'sub check_and_clean_from_address' function would be
something like:

> sub check_and_clean_from_address {
>      my ($address) = @_;
>      my $logger = get_logger();
>
>      if($address =~ /^.*($noreply_pattern).*/i) ) {
>          $logger->debug("sender $address contains $1 - will not send vacation message");
>          exit(0);
>      }
>      $address = strip_address($address);
>      if($address eq '') {
>          $logger->error("Address $address is not valid; exiting");
>          exit(0);
>      }
>      #$logger->debug("Address cleaned up to $address");
>      return $address;
> }
>
> And finally, last question...
>
> What is the practical limit on the number of characters that can be
> included in this variable?

One other question, already asked in a prior email, is...

Am I correct in my comments, that BOTH the envelope sender and any other 
 From headers are tested? Or does this check_and_clean_from_address 
function only test the envelope sender? If so (and I think it might), 
then we may need to have two new variables:

$noreply_pattern_envelope
$noreply_pattern_header

and appropriate comment changes.

> So, before I enable these changes, what do you think? If this looks
> correct, I'll enable it and test it live for the next few weeks on my
> server...
>
> Thanks again Rudi!

Re: [Postfixadmin-devel] Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

On 2013-03-12 5:06 PM, Tanstaafl <tan...@li...> wrote:
> On 2013-03-12 4:47 PM, Rudi Floren <rud...@go...> wrote:
>> Am Dienstag, 12. März 2013 21:45:18 schrieb Tanstaafl:
>>> Wait... are you saying that one-liner change takes the place of the
>>> other block of code?
>>>
>>> hmmmm......

 >> should.

 > Ok, thanks, I'll experiment in the morning...

Ok, a few issues/questions...

There is one typo for sure: line 599, $adress should be $address

Next...

Shouldn't

'$custom_noreply_pattern == 1'

actually be

'$custom_noreply == 1' ?

Also, I am naming my two options

$custom_noreply
and
$custom_noreply_pattern

It just seems more correct to me.

So, I now have this line as:

> ($custom_noreply == 1 && $address =~ /^.*($custom_noreply_pattern).*/i) ) {

So, assuming you accept my modified variable name for the pattern, is 
this correct?

Next to last question...

Wouldn't it make more sense to adjust the defaults for the custom 
pattern to include all of the values in the immediately prior two tests, 
and change this to just the one test, instead of basically having three 
separate tests (one to test the local part, the next to test the domain 
part, and finally our new custom one to test the whole thing?

And if this is ultimately the desired goal, we could rename the 
variables one last time, and end up with something like:

>     if($address =~ /^(noreply|postmaster|mailer\-daemon|listserv|majordomo|owner\-|request\-|bounces\-)/i ||
>         $address =~ /\-(owner|request|bounces)\@/i ) {
> #        $address =~ /\-(owner|request|bounces)\@/i ||



1. only ONE new variable that contains all of the predetermined strings, 
and just a comment explaining how to modify this variable to include new 
strings or tweak existing ones or even remove them if they are causing 
too many false positives:

# This is the list of strings that is checked against both the
# envelope sender and any/all From header addresses that, if
# matched, results in the vacation message not being sent.
our $noreply_pattern =
'bounce|do-not-reply|facebook|linkedin|list-|listserv|mailer\-daemon|majordomo|myspace|noreply|owner\-|\-(owner|request|bounces)|postmaster|request\-|twitter';

Then the new 'sub check_and_clean_from_address' function would be 
something like:

> sub check_and_clean_from_address {
>     my ($address) = @_;
>     my $logger = get_logger();
>
>     if($address =~ /^.*($noreply_pattern).*/i) ) {
>         $logger->debug("sender $address contains $1 - will not send vacation message");
>         exit(0);
>     }
>     $address = strip_address($address);
>     if($address eq '') {
>         $logger->error("Address $address is not valid; exiting");
>         exit(0);
>     }
>     #$logger->debug("Address cleaned up to $address");
>     return $address;
> }

And finally, last question...

What is the practical limit on the number of characters that can be 
included in this variable?

So, before I enable these changes, what do you think? If this looks 
correct, I'll enable it and test it live for the next few weeks on my 
server...

Thanks again Rudi!

Charles

Re: [Postfixadmin-devel] Adding the users Real Name to the vacation From: response - WAS Re: Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

Ok, thanks, I'll experiment in the morning...

On 2013-03-12 4:47 PM, Rudi Floren <rud...@go...> wrote:
> should.
>
> Am Dienstag, 12. März 2013 21:45:18 schrieb Tanstaafl:
>> Wait... are you saying that one-liner change takes the place of the
>> other block of code?
>>
>> hmmmm......
>>
>> On 2013-03-12 2:09 PM, Rudi Floren <rud...@go...> wrote:
>>> ah. my thunderbird shows all of this as the same thread. no. there is
>>> such a function for noreply check.
>>> lets start a new thread for the From field.
>>>
>>> Am Dienstag, 12. März 2013 19:06:17 schrieb Tanstaafl:
>>>> On 2013-03-12 11:01 AM, Rudi Floren <rud...@go...> wrote:
>>>>> btw. in line 597, there is such a functionality.
>>>>> I moved the new code into this function. (commit 5e9d4d7)
>>>>
>>>> Hmmm...
>>>>
>>>> Trying to figure this out...
>>>>
>>>> So, you're saying that by adding this one-liner change, it will change
>>>> the 'From:' of the vacation message to RFC 822 style?
>>>>
>>>> As soon as you get the repo back on line I'll look at this more closely.
>>>>
>>>> I must say that with your helping to get the custom_noreply stuff
>>>> working right, if we can get this last item working, I'll basically have
>>>> no more complaints about the vacation module... :)
>>>>
>>>> Thanks again

Re: [Postfixadmin-devel] Adding the users Real Name to the vacation From: response - WAS Re: Please help getting my multi-string from header check matching...

[Rudi F. <rud...@go...>]

should.

Am Dienstag, 12. März 2013 21:45:18 schrieb Tanstaafl:
> Wait... are you saying that one-liner change takes the place of the
> other block of code?
>
> hmmmm......
>
> On 2013-03-12 2:09 PM, Rudi Floren <rud...@go...> wrote:
>> ah. my thunderbird shows all of this as the same thread. no. there is
>> such a function for noreply check.
>> lets start a new thread for the From field.
>>
>> Am Dienstag, 12. März 2013 19:06:17 schrieb Tanstaafl:
>>> On 2013-03-12 11:01 AM, Rudi Floren <rud...@go...> wrote:
>>>> btw. in line 597, there is such a functionality.
>>>> I moved the new code into this function. (commit 5e9d4d7)
>>>
>>> Hmmm...
>>>
>>> Trying to figure this out...
>>>
>>> So, you're saying that by adding this one-liner change, it will change
>>> the 'From:' of the vacation message to RFC 822 style?
>>>
>>> As soon as you get the repo back on line I'll look at this more closely.
>>>
>>> I must say that with your helping to get the custom_noreply stuff
>>> working right, if we can get this last item working, I'll basically have
>>> no more complaints about the vacation module... :)
>>>
>>> Thanks again
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_mar
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel

Re: [Postfixadmin-devel] Adding the users Real Name to the vacation From: response - WAS Re: Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

Wait... are you saying that one-liner change takes the place of the 
other block of code?

hmmmm......

On 2013-03-12 2:09 PM, Rudi Floren <rud...@go...> wrote:
> ah. my thunderbird shows all of this as the same thread. no. there is
> such a function for noreply check.
> lets start a new thread for the From field.
>
> Am Dienstag, 12. März 2013 19:06:17 schrieb Tanstaafl:
>> On 2013-03-12 11:01 AM, Rudi Floren <rud...@go...> wrote:
>>> btw. in line 597, there is such a functionality.
>>> I moved the new code into this function. (commit 5e9d4d7)
>>
>> Hmmm...
>>
>> Trying to figure this out...
>>
>> So, you're saying that by adding this one-liner change, it will change
>> the 'From:' of the vacation message to RFC 822 style?
>>
>> As soon as you get the repo back on line I'll look at this more closely.
>>
>> I must say that with your helping to get the custom_noreply stuff
>> working right, if we can get this last item working, I'll basically have
>> no more complaints about the vacation module... :)
>>
>> Thanks again

Re: [Postfixadmin-devel] Using the 'Real Name' in the autoreply message

[Tanstaafl <tan...@li...>]

On 2013-03-12 2:53 PM, Tanstaafl <tan...@li...> wrote:
> Hello all,
>
> I have a Feature Request for this at:
>
> https://sourceforge.net/p/postfixadmin/feature-requests/30/
>
> To put it simply, I want the vacation message to show as:
>
> From: "Real Name" <em...@ex...>
>
> not just
>
> em...@ex...

To clarify...

First it should test for whether or not there is a real name in the DB. 
If there is, use RFC 822 style (per above), if there isn't, use RFC 821 
style.

Re: [Postfixadmin-devel] SOLVED - Re: Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

On 2013-03-12 2:28 PM, Tanstaafl <tan...@li...> wrote:
> # By default vacation messages will be sent to all senders that can not
>># definitively be determined to be email lists or other senders that
>># should not be replied to. You can enable $custom_noreply option, then
>># modify the list of strings in $custom_noreply_pattern. These strings
>># are tested against both the envelope sender and all from headers, and
>># if a match is found, no message is sent.

Rudi (or anyone),

Is my above comment accurate in that BOTH the envelope sender AND any 
other From headers are examined during this test? Or is this only a test 
of the envelope sender?

Thanks

[Postfixadmin-devel] Using the 'Real Name' in the autoreply message

[Tanstaafl <tan...@li...>]

Hello all,

I have a Feature Request for this at:

https://sourceforge.net/p/postfixadmin/feature-requests/30/

To put it simply, I want the vacation message to show as:

From: "Real Name" <em...@ex...>

not just

em...@ex...

Re: [Postfixadmin-devel] Adding the users Real Name to the vacation From: response - WAS Re: Please help getting my multi-string from header check matching...

[Tanstaafl <tan...@li...>]

On 2013-03-12 2:09 PM, Rudi Floren <rud...@go...> wrote:
> ah. my thunderbird shows all of this as the same thread. no. there is
> such a function for noreply check.
> lets start a new thread for the From field.

Ok... thanks...