postfixadmin-devel — Postfix Admin development talk - users are also welcome

[Postfixadmin-devel] Vacation roundcube plugin

[Luigi R. <li...@lu...>]

Hi,
what is the best vacation plugin for roundcube that integrates postfixadmin SQL 
schema and start/end date?


Thanks

-- 


Ciao,
luigi

/
+--[Luigi Rosa]--
\

Hackers do it with all sorts of characters.

Re: [Postfixadmin-devel] postfixadmin with ldap

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 25. November 2014 schrieb Tanstaafl:
> Eh? What rumblings? MariaDB is billed as a 'drop-in replacement' for
> MySQL. Are you saying there are issues with it?

Basically it is a drop-in replacement, but we managed to write a query 
in a way that triggered an optimization bug in MariaDB, resulting in 
wrong query results. 

This bug is fixed in 2.92 (aka 3.0 beta2) by adding a workaround - if 
you are interested in details, have a look at bug#313 and bug#325 in the 
sourceforge tracker.
 

Regards,

Christian Boltz
-- 
> [...] is currently down due to a failure in the NAS system.
> [...]
> your NAS (network attached storage)
Oh. I thought it stood for Networked Adrian Schröter :D
[> Adrian Schröter and Jean Delvare in opensuse-buildservice]

Re: [Postfixadmin-devel] postfixadmin with ldap

[Christian B. <pos...@cb...>]

Hello,

Am Donnerstag, 12. Februar 2015 schrieb Vikas Parashar:
> Did you get the chance to look in it, as of now, i get stuck somewhere
> due to fear(or you might say conflict that would come). My fear is
> that more code more problem. So, i don't want to complete my code in
> one run.
> 
> Guide me if i am driving on wrong way.

I'm currently busy _and_ ill :-/ - but I'll give you a short review 
nevertheless (based on your git commits). Please don't expect this 
review to be complete, but you should at least get the most important 
points.

Also note that I don't know much about LDAP, so please correct me if one 
of my comments is wrong and/or crazy ;-)


In ldap.php, you have several lines like

+		if ($key == "domain" )
+		{		
+			$new_array["vd"] = str_replace("'", '', $value);
+		}

This approach will break if for example someone adds a field.
Please do the escaping based on the field type specified in 
$this->struct (see initStruct() in model/*Handler.php) or, if you want a 
simple way, on every field.

(Speaking of escaping - does LDAP really allow all chars except ' as 
valid? If not, using a char whitelist with allowed chars would be a 
better option.)


Instead of 

+	global $CONF;

please use Config::Read (or Config::bool etc. if it fits better)


Also, instead of having functions like ldap_domain_add() (what about 
adding a mailbox or an admin? you'll need another function) it's much 
better to use PFAHandler.php as a base. This probably isn't as easy as 
it sounds because SQL and LDAP queries are much different, but I'm sure 
it's possible.


For your local config changes, please create a file config.local.php 
instead of editing config.inc.php. (You can of course add ldap examples 
to config.inc.php.)

Also, please keep out templates_c/* out of git - those files are cache 
files you can delete at any time without breaking something.


I see that you parse SELECT queries to convert them to LDAP at least in 
some cases. Let me warn you that this will explode with the more 
interesting SQL queries (for example, test list.php?table=domain is in 
SNV, but not used yet - and does interesting SQL magic ;-)

Better modify the functions that generate the SQL queries. (I know that 
list-$whatever.php still uses hardcoded queries - feel free to try 
list.php instead).

> On Fri, Feb 6, 2015 at 12:57 PM, Vikas Parashar <par...@gm...>
> wrote:
> > On Tue, Feb 3, 2015 at 5:43 PM, Christian Boltzwrote:
> >> Am Montag, 2. Februar 2015 schrieb Vikas Parashar:

> > Ahh!, here i am using git, i can continue with svn as well.
> > Personally, i think svn is too old fashion and very heavy. May be,
> > we can think to move on git. Anyway, i can commit it to svn as
> > well..

That's an old discussion we had more than once ;-)
The advantage of SVN is that we can use the release number in 
upgrade.php function names, which means adding a function is enough 
(without the need to adjust a "highest function number" somewhere).

I'f open for ideas how to do this with git ;-)

That said - while you are writing your patch, using git is fine.

> > I would like to request to you kindly see my code on my git repo
> > when will you get the chance. Right from the beginning, i am
> > looking for some guidelines. I know only one rule KISS(Keep it
> > simply stupid). :)

Well, the other rules more or less base on KISS ;-)

If you think that we should add something less obvious to the coding 
guidelines, just propose it ;-)

> > Please check it here
> > https://vic...@gi.../vickally/postfixadmin.git> 


Regards,

Christian Boltz
-- 
> Also, Hosen runter:
Hose*n*! Du hast nur "die" Hose runtergelassen und die Unterhose
anbehalten. Nix da!
[> Stefan G. Weichinger und Peer Heinlein in postfixbuch-users]

Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hi Christian,

Did you get the chance to look in it, as of now, i get stuck somewhere due
to fear(or you might say conflict that would come). My fear is that more
code more problem. So, i don't want to complete my code in one run.

Guide me if i am driving on wrong way.

Rg:
Vikas Parashar

On Fri, Feb 6, 2015 at 12:57 PM, Vikas Parashar <par...@gm...>
wrote:

> Hi Christian,
>
> Thanks you very much for your kind support.
>
> On Tue, Feb 3, 2015 at 5:43 PM, Christian Boltz <pos...@cb...>
> wrote:
>
>> Hello,
>>
>> Am Montag, 2. Februar 2015 schrieb Vikas Parashar:
>> > Can someone guide me?
>>
>> Yes, of course. Sorry for the delay!
>>
> There is nothing to say sorry, thank you for your valuable points.
>
>>
>> > On Tue, Jan 27, 2015 at 8:29 PM, Vikas Parashar wrote:
>> > > I have written some thing as per our discussion, Could you please
>> > > guide me how & where i can show you that functionality and my code?
>>
>> I think you are talking about uploading your changed files or patches.
>> The tracker on Sourceforge is probably the best place for this:
>>     http://sourceforge.net/p/postfixadmin/patches/
>> (Feel free to use a tarball if you want to upload multiple files.)
>>
>
> Ahh!, here i am using git, i can continue with svn as well. Personally, i
> think svn is too old fashion and very heavy. May be, we can think to move
> on git. Anyway, i can commit it to svn as well..
>
> I would like to request to you kindly see my code on my git repo when will
> you get the chance. Right from the beginning, i am looking for some
> guidelines. I know only one rule KISS(Keep it simply stupid). :)
>
> Please check it here https://vic...@gi.../vickally/postfixadmin.git
>
>
>
>
>> > > As i am not a core programmer, could you please guide me(or give me
>> > > some pointer) to write good code. So that, i can execute my idea in
>> > > better way.
>>
>> That's an interesting question ;-)
>> Short answer: for coding style, have a look at
>>     http://sourceforge.net/p/postfixadmin/wiki/Coding_guidelines/
>> which lists some basic rules.
>>
>> Besides that, we don't have written rules. Maybe the best question to
>> answer is : if someone forces you to change your code in a year, would
>> you happily do that or would you heavily protest? ;-)
>>
>
> That depends on requirement, situation and community feedback. Yes, i
> would happily do that if required.
>
>
>> If you are looking for some examples,
>> - model/*, edit.php and list.php are what I'd call "good" code
>> - most of the files in the main directory are, well, not so good. With
>>   the exception of edit.php and list.php, those files contain "grown"
>>   code which also collected quite some issues over the years that make
>>   maintenance harder.
>> - also, older versions of PostfixAdmin contain some interesting[tm]
>>   stuff I don't want to see again - especially lots of code duplication
>>   with different bugs in each copy :-/
>>
>>
>> Regards,
>>
>> Christian Boltz
>> --
>> Oh großer Meister! Darf man euch untertänigst darauf aufmerksam
>> machen, daß das diff'en von Postscriptfonts komplette Unterordner
>> synchronisiert und diff't, unter Berücksichtigung von Links? :-)
>> [Ratti in fontlinge-devel]
>>
>>
>

[Postfixadmin-devel] export mailbox feature (patch)

[stefano s. <sco...@gm...>]

hello,

in my environment domain admins need to export mailboxes, either if they
are mbox or maildir or whatever.

i wrote a simple patch to add this feature, it has not all exception
checking and it dies instead of showing nice messages, but it is acceptable
as a first release on my system.

Notes:
1. it works only if postfixadmin is local with your mail server.
2. it depends on http://php.net/manual/en/book.zip.php php module.
3. webserver's user has to have access permissions on mailboxes files and
folders.
4. the working language is only english at the moment.
5. i am using debian 7, that's why the patch is for postfixadmin-2.3.5
6. it doesnt support '~' paths yet.

i can fix those 3 last lacks if you say you are interested in this.

thanks for your attention.

Re: [Postfixadmin-devel] Message count quotas

[Christian B. <pos...@cb...>]

Hello,

Am Montag, 9. Februar 2015 schrieb Robert Moskowitz:
> I am running postfixadmin 2.91

You might want to update to 2.92 which contains some fixes ;-)

> I just got hit with the message count quota in dovecot:

> user_query = SELECT concat('/home/vmail/', maildir) as home,
> concat('maildir:/home/vmail/', maildir) as mail, 101 AS uid, 12 AS
> gid, CONCAT('*:messages=10000:bytes=', quota) as quota_rule FROM
> mailbox WHERE username = '%u' AND active = '1'
> 
> Note that messages=10000 is hard coded, where as bytes is pulled out
> of the postfixadmin database.
> 
> Has this been added since 2.91?  If not could it be?  I upped my
> message limit to 30000...

The current DOCUMENTS/DOVECOT.txt contains:

user_query = SELECT CONCAT('/var/vmail/mail/', maildir) AS home, 
    1001 AS uid, 1001 AS gid, 
    CONCAT('*:bytes=', quota) AS quota_rule 
    FROM mailbox WHERE username = '%u' AND active='1'

so there's nothing that restricts the number of messages.

I'm quite sure we never had the messages= part in the query (I'd have to 
change the SVN history to be really sure).

Maybe you got your query from somewhere else and should just switch to 
the query I quoted above?


Regards,

Christian Boltz
-- 
There's such a thing as real life? Is it packages for openSUSE yet? 
Will there be a YaST2 module for easy configuration? Is it going to be
included in 11.2 or is it so complex it's going to have to wait until
11.3? More importantly, will it be on the DVD, or would people need to
use one of the online repos to download it?
[David Bolt in opensuse-packaging]

[Postfixadmin-devel] Message count quotas

[Robert M. <rg...@ht...>]

I am running postfixadmin 2.91

I just got hit with the message count quota in dovecot:

driver = mysql
connect = host=localhost dbname=postfix user=postfix password=*******
default_pass_scheme = MD5-CRYPT
password_query = SELECT username as user, password, 
concat('/home/vmail/', maildir) as userdb_home, 
concat('maildir:/home/vmail/', maildir) as userdb_mail, 101 as 
userdb_uid, 12 as userdb_gid FROM mailbox WHERE username = '%u' AND 
active = '1'
user_query = SELECT concat('/home/vmail/', maildir) as home, 
concat('maildir:/home/vmail/', maildir) as mail, 101 AS uid, 12 AS gid, 
CONCAT('*:messages=10000:bytes=', quota) as quota_rule FROM mailbox 
WHERE username = '%u' AND active = '1'

Note that messages=10000 is hard coded, where as bytes is pulled out of 
the postfixadmin database.

Has this been added since 2.91?  If not could it be?  I upped my message 
limit to 30000...

Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hi Christian,

Thanks you very much for your kind support.

On Tue, Feb 3, 2015 at 5:43 PM, Christian Boltz <pos...@cb...>
wrote:

> Hello,
>
> Am Montag, 2. Februar 2015 schrieb Vikas Parashar:
> > Can someone guide me?
>
> Yes, of course. Sorry for the delay!
>
There is nothing to say sorry, thank you for your valuable points.

>
> > On Tue, Jan 27, 2015 at 8:29 PM, Vikas Parashar wrote:
> > > I have written some thing as per our discussion, Could you please
> > > guide me how & where i can show you that functionality and my code?
>
> I think you are talking about uploading your changed files or patches.
> The tracker on Sourceforge is probably the best place for this:
>     http://sourceforge.net/p/postfixadmin/patches/
> (Feel free to use a tarball if you want to upload multiple files.)
>

Ahh!, here i am using git, i can continue with svn as well. Personally, i
think svn is too old fashion and very heavy. May be, we can think to move
on git. Anyway, i can commit it to svn as well..

I would like to request to you kindly see my code on my git repo when will
you get the chance. Right from the beginning, i am looking for some
guidelines. I know only one rule KISS(Keep it simply stupid). :)

Please check it here https://vic...@gi.../vickally/postfixadmin.git




> > > As i am not a core programmer, could you please guide me(or give me
> > > some pointer) to write good code. So that, i can execute my idea in
> > > better way.
>
> That's an interesting question ;-)
> Short answer: for coding style, have a look at
>     http://sourceforge.net/p/postfixadmin/wiki/Coding_guidelines/
> which lists some basic rules.
>
> Besides that, we don't have written rules. Maybe the best question to
> answer is : if someone forces you to change your code in a year, would
> you happily do that or would you heavily protest? ;-)
>

That depends on requirement, situation and community feedback. Yes, i would
happily do that if required.


> If you are looking for some examples,
> - model/*, edit.php and list.php are what I'd call "good" code
> - most of the files in the main directory are, well, not so good. With
>   the exception of edit.php and list.php, those files contain "grown"
>   code which also collected quite some issues over the years that make
>   maintenance harder.
> - also, older versions of PostfixAdmin contain some interesting[tm]
>   stuff I don't want to see again - especially lots of code duplication
>   with different bugs in each copy :-/
>
>
> Regards,
>
> Christian Boltz
> --
> Oh großer Meister! Darf man euch untertänigst darauf aufmerksam
> machen, daß das diff'en von Postscriptfonts komplette Unterordner
> synchronisiert und diff't, unter Berücksichtigung von Links? :-)
> [Ratti in fontlinge-devel]
>
>

Re: [Postfixadmin-devel] postfixadmin with ldap

[Christian B. <pos...@cb...>]

Hello,

Am Montag, 2. Februar 2015 schrieb Vikas Parashar:
> Can someone guide me?

Yes, of course. Sorry for the delay!

> On Tue, Jan 27, 2015 at 8:29 PM, Vikas Parashar wrote:
> > I have written some thing as per our discussion, Could you please
> > guide me how & where i can show you that functionality and my code?

I think you are talking about uploading your changed files or patches. 
The tracker on Sourceforge is probably the best place for this:
    http://sourceforge.net/p/postfixadmin/patches/
(Feel free to use a tarball if you want to upload multiple files.)

> > As i am not a core programmer, could you please guide me(or give me
> > some pointer) to write good code. So that, i can execute my idea in
> > better way.

That's an interesting question ;-)
Short answer: for coding style, have a look at   
    http://sourceforge.net/p/postfixadmin/wiki/Coding_guidelines/
which lists some basic rules.

Besides that, we don't have written rules. Maybe the best question to 
answer is : if someone forces you to change your code in a year, would 
you happily do that or would you heavily protest? ;-)

If you are looking for some examples,
- model/*, edit.php and list.php are what I'd call "good" code
- most of the files in the main directory are, well, not so good. With 
  the exception of edit.php and list.php, those files contain "grown" 
  code which also collected quite some issues over the years that make 
  maintenance harder.
- also, older versions of PostfixAdmin contain some interesting[tm] 
  stuff I don't want to see again - especially lots of code duplication 
  with different bugs in each copy :-/


Regards,

Christian Boltz
-- 
Oh großer Meister! Darf man euch untertänigst darauf aufmerksam
machen, daß das diff'en von Postscriptfonts komplette Unterordner
synchronisiert und diff't, unter Berücksichtigung von Links? :-)
[Ratti in fontlinge-devel]

Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hello,

Can someone guide me?

On Tue, Jan 27, 2015 at 8:29 PM, Vikas Parashar <par...@gm...>
wrote:

> Hi Christian,
>
> I have written some thing as per our discussion, Could you please guide me
> how & where i can show you that functionality and my code?
> As i am not a core programmer, could you please guide me(or give me some
> pointer) to write good code. So that, i can execute my idea in better way.
>
> On Mon, Dec 8, 2014 at 11:10 AM, Vikas Parashar <par...@gm...>
> wrote:
>
>> Hello,
>>
>>
>> On Mon, Dec 1, 2014 at 11:50 PM, Christian Boltz <pos...@cb...>
>> wrote:
>>
>>> Hello,
>>>
>>> Am Montag, 24. November 2014 schrieb Vikas Parashar:
>>> > Actually, i have done it for one of my client in which i have put a
>>> > elif condition and call the ldap query there. i don't think so it's a
>>> > right thing to go ahead. Personally, i want to write a plugin that we
>>> > can easily attached just like a patch.
>>>
>>> That sounds even more interesting :-)
>>>
>>> Can you send a patch with your current changes to give us an impression
>>> what changes you needed to do? Even if this probably won't be the final
>>> code, it could be helpful to help you converting it to a plugin.
>>>
>>
>> Give me couple of weeks, will send you soon.
>>
>>>
>>> BTW: I don't know much about LDAP, and AFAIK the other PostfixAdmin
>>> developers also know SQL much better than LDAP. If we include LDAP
>>> support in PostfixAdmin, would you be willing to maintain it?
>>>
>>
>> Yes, i will maintain it.
>>
>>
>>>
>>>
>>> Regards,
>>>
>>> Christian Boltz
>>> --
>>> <jdstrand> jjohansen: curious-- is there a reason why child profiles
>>>            can't contain a '-' in their name?
>>> <jjohansen> jdstrand: yes, because its not in the regex :P
>>> <jdstrand> jjohansen: is there a reason why '-' is not in the child
>>>            profile regex? ;P   [from #apparmor]
>>>
>>>
>>
>

Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hi Christian,

I have written some thing as per our discussion, Could you please guide me
how & where i can show you that functionality and my code?
As i am not a core programmer, could you please guide me(or give me some
pointer) to write good code. So that, i can execute my idea in better way.

On Mon, Dec 8, 2014 at 11:10 AM, Vikas Parashar <par...@gm...>
wrote:

> Hello,
>
>
> On Mon, Dec 1, 2014 at 11:50 PM, Christian Boltz <pos...@cb...>
> wrote:
>
>> Hello,
>>
>> Am Montag, 24. November 2014 schrieb Vikas Parashar:
>> > Actually, i have done it for one of my client in which i have put a
>> > elif condition and call the ldap query there. i don't think so it's a
>> > right thing to go ahead. Personally, i want to write a plugin that we
>> > can easily attached just like a patch.
>>
>> That sounds even more interesting :-)
>>
>> Can you send a patch with your current changes to give us an impression
>> what changes you needed to do? Even if this probably won't be the final
>> code, it could be helpful to help you converting it to a plugin.
>>
>
> Give me couple of weeks, will send you soon.
>
>>
>> BTW: I don't know much about LDAP, and AFAIK the other PostfixAdmin
>> developers also know SQL much better than LDAP. If we include LDAP
>> support in PostfixAdmin, would you be willing to maintain it?
>>
>
> Yes, i will maintain it.
>
>
>>
>>
>> Regards,
>>
>> Christian Boltz
>> --
>> <jdstrand> jjohansen: curious-- is there a reason why child profiles
>>            can't contain a '-' in their name?
>> <jjohansen> jdstrand: yes, because its not in the regex :P
>> <jdstrand> jjohansen: is there a reason why '-' is not in the child
>>            profile regex? ;P   [from #apparmor]
>>
>>
>

Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hello,


On Mon, Dec 1, 2014 at 11:50 PM, Christian Boltz <pos...@cb...>
wrote:

> Hello,
>
> Am Montag, 24. November 2014 schrieb Vikas Parashar:
> > Actually, i have done it for one of my client in which i have put a
> > elif condition and call the ldap query there. i don't think so it's a
> > right thing to go ahead. Personally, i want to write a plugin that we
> > can easily attached just like a patch.
>
> That sounds even more interesting :-)
>
> Can you send a patch with your current changes to give us an impression
> what changes you needed to do? Even if this probably won't be the final
> code, it could be helpful to help you converting it to a plugin.
>

Give me couple of weeks, will send you soon.

>
> BTW: I don't know much about LDAP, and AFAIK the other PostfixAdmin
> developers also know SQL much better than LDAP. If we include LDAP
> support in PostfixAdmin, would you be willing to maintain it?
>

Yes, i will maintain it.


>
>
> Regards,
>
> Christian Boltz
> --
> <jdstrand> jjohansen: curious-- is there a reason why child profiles
>            can't contain a '-' in their name?
> <jjohansen> jdstrand: yes, because its not in the regex :P
> <jdstrand> jjohansen: is there a reason why '-' is not in the child
>            profile regex? ;P   [from #apparmor]
>
>

Re: [Postfixadmin-devel] postfixadmin with ldap

[Christian B. <pos...@cb...>]

Hello,

Am Montag, 24. November 2014 schrieb Vikas Parashar:
> Actually, i have done it for one of my client in which i have put a
> elif condition and call the ldap query there. i don't think so it's a
> right thing to go ahead. Personally, i want to write a plugin that we
> can easily attached just like a patch.

That sounds even more interesting :-)

Can you send a patch with your current changes to give us an impression 
what changes you needed to do? Even if this probably won't be the final 
code, it could be helpful to help you converting it to a plugin.

BTW: I don't know much about LDAP, and AFAIK the other PostfixAdmin 
developers also know SQL much better than LDAP. If we include LDAP 
support in PostfixAdmin, would you be willing to maintain it?


Regards,

Christian Boltz
-- 
<jdstrand> jjohansen: curious-- is there a reason why child profiles
           can't contain a '-' in their name?
<jjohansen> jdstrand: yes, because its not in the regex :P
<jdstrand> jjohansen: is there a reason why '-' is not in the child
           profile regex? ;P   [from #apparmor]

Re: [Postfixadmin-devel] postfixadmin with ldap

[Tanstaafl <tan...@li...>]

On 11/24/2014 12:58 PM, Robert Moskowitz <rg...@ht...> wrote:
> Though one might say that there are already instructions for different 
> sql backends for most of these, so an ldap backend would just be one 
> more.  As it is, I have heard some rumblings about mariadb.

Eh? What rumblings? MariaDB is billed as a 'drop-in replacement' for
MySQL. Are you saying there are issues with it?

I;m asking because we are currently running it, and without issues, but
I've been a bit nervous about updates since apparently it is still
considered a 'red-headed step-child'.

I'd really, really like to see MariaDB become a formally, officially
supported DB back end (where current release versions are tested against).

Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hi Robert/Boltz,

Thanks for your support.

Actually, i have done it for one of my client in which i have put a elif
condition and call the ldap query there. i don't think so it's a right
thing to go ahead. Personally, i want to write a plugin that we can easily
attached just like a patch.

Hope, i shall give you some good news soon.

On Mon, Nov 24, 2014 at 12:58 PM, Robert Moskowitz <rg...@ht...>
wrote:

>
> On 11/24/2014 12:49 PM, Christian Boltz wrote:
>
>> Hello,
>>
>> Am Dienstag, 18. November 2014 schrieb Vikas Parashar:
>>
>>> Some days back i have written some code to use postfixadmin with ldap
>>> backend. But i think before put it on the repo. I want to write a
>>> plugin that will help to add the ldap backend with postfixadmin.
>>>
>> Adding LDAP support sounds like lots of work - basically you need to
>> replace all db_*() functions and also need to "translate" the SQL
>> queries to something that LDAP understands.
>>
>> Most queries are built in PFAHandler.php and some db_*() functions
>> nowadays, but we still have some hand-written queries here and there.
>>
>
> Oh it is more than that.  All the subsystems that are expecting an sql db
> for the domain and users and vacations and,  would have to be changed.  All
> the postfix, spamassasin, dovecot, amavis-new, roundcube,...  Need I go on?
>
> Though one might say that there are already instructions for different sql
> backends for most of these, so an ldap backend would just be one more.  As
> it is, I have heard some rumblings about mariadb.
>
>
>
>> To make things interesting, LDAP is quite different from SQL.
>>
>> Don't get me wrong - I don't want to stop you. I just want to warn you
>> that this won't be an easy ride ;-)
>>
>> BTW: list-admin.php, list-domain.php, fetchmail.php and vacation.php
>> will be replaced by list.php and edit.php sooner or later, so better
>> don't invest time on them.
>>
>>  Could any body please give me some suggestion or guidelines on it.
>>>
>> I'm afraid I can't offer a simple receipe ;-) - maybe the easiest way is
>> to join the #postfixadmin IRC channel on freenode and to ask there.
>> I'm usually there in the (CET) evening (username "cboltz").
>>
>>
>> Regards,
>>
>> Christian Boltz
>>
>
>

Re: [Postfixadmin-devel] postfixadmin with ldap

[Robert M. <rg...@ht...>]

On 11/24/2014 12:49 PM, Christian Boltz wrote:
> Hello,
>
> Am Dienstag, 18. November 2014 schrieb Vikas Parashar:
>> Some days back i have written some code to use postfixadmin with ldap
>> backend. But i think before put it on the repo. I want to write a
>> plugin that will help to add the ldap backend with postfixadmin.
> Adding LDAP support sounds like lots of work - basically you need to
> replace all db_*() functions and also need to "translate" the SQL
> queries to something that LDAP understands.
>
> Most queries are built in PFAHandler.php and some db_*() functions
> nowadays, but we still have some hand-written queries here and there.

Oh it is more than that.  All the subsystems that are expecting an sql 
db for the domain and users and vacations and,  would have to be 
changed.  All the postfix, spamassasin, dovecot, amavis-new, 
roundcube,...  Need I go on?

Though one might say that there are already instructions for different 
sql backends for most of these, so an ldap backend would just be one 
more.  As it is, I have heard some rumblings about mariadb.

>
> To make things interesting, LDAP is quite different from SQL.
>
> Don't get me wrong - I don't want to stop you. I just want to warn you
> that this won't be an easy ride ;-)
>
> BTW: list-admin.php, list-domain.php, fetchmail.php and vacation.php
> will be replaced by list.php and edit.php sooner or later, so better
> don't invest time on them.
>
>> Could any body please give me some suggestion or guidelines on it.
> I'm afraid I can't offer a simple receipe ;-) - maybe the easiest way is
> to join the #postfixadmin IRC channel on freenode and to ask there.
> I'm usually there in the (CET) evening (username "cboltz").
>
>
> Regards,
>
> Christian Boltz

Re: [Postfixadmin-devel] postfixadmin with ldap

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 18. November 2014 schrieb Vikas Parashar:
> Some days back i have written some code to use postfixadmin with ldap
> backend. But i think before put it on the repo. I want to write a
> plugin that will help to add the ldap backend with postfixadmin.

Adding LDAP support sounds like lots of work - basically you need to 
replace all db_*() functions and also need to "translate" the SQL 
queries to something that LDAP understands.

Most queries are built in PFAHandler.php and some db_*() functions 
nowadays, but we still have some hand-written queries here and there.

To make things interesting, LDAP is quite different from SQL.

Don't get me wrong - I don't want to stop you. I just want to warn you 
that this won't be an easy ride ;-)

BTW: list-admin.php, list-domain.php, fetchmail.php and vacation.php 
will be replaced by list.php and edit.php sooner or later, so better 
don't invest time on them.

> Could any body please give me some suggestion or guidelines on it.

I'm afraid I can't offer a simple receipe ;-) - maybe the easiest way is 
to join the #postfixadmin IRC channel on freenode and to ask there. 
I'm usually there in the (CET) evening (username "cboltz").


Regards,

Christian Boltz
-- 
looks like you have some special code in yast for password "x", maybe I
should use the even more secure new password "y" in the future  ?! ;-)
[Harald Koenig in https://bugzilla.novell.com/show_bug.cgi?id=148464]

[Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hi,

Some days back i have written some code to use postfixadmin with ldap
backend. But i think before put it on the repo. I want to write a plugin
that will help to add the ldap backend with postfixadmin.

Could any body please give me some suggestion or guidelines on it.

Re: [Postfixadmin-devel] Error 404 with vacation module

[Jean-Max R. <jmr...@fr...>]

Le 17/11/2014 18:56, Christian Boltz a écrit :
> Hello,
>
> Am Montag, 17. November 2014 schrieb Jean-Max Reymond:
>> I am using postfixadmin 2.3.5 with Ubuntu server LTS 14.04. All is
>> fine but I have some troubles with the vacation module. If a user set
>> a vacation message, the quit button provide a 404 error for the
>> following link:
>> http://postfixadmin.normaal.fr/postfixadmin/list-virtual.php?domain=no
>> rmaal.fr
>>
>> Of, course, the correct link should be
>> http://postfixadmin.normaal.fr/list-virtual.php?domain=normaal.fr
>>
>> How to fix the error ?
>
> Sounds like $CONF['postfix_admin_url'] contains a wrong value - in your
> case, it should be 'http://postfixadmin.normaal.fr' (I'm quite sure you
> have an additional "/postfixadmin" in it ;-)
>
>
> Regards,
>
> Christian Boltz
>
that's correct and it is fixed. Thanks a lot :-)

-- 
Jean-Max Reymond
Éruption de l'Etna: http://jmreymond.free.fr/Etna2002

Re: [Postfixadmin-devel] Error 404 with vacation module

[Christian B. <pos...@cb...>]

Hello,

Am Montag, 17. November 2014 schrieb Jean-Max Reymond:
> I am using postfixadmin 2.3.5 with Ubuntu server LTS 14.04. All is
> fine but I have some troubles with the vacation module. If a user set
> a vacation message, the quit button provide a 404 error for the
> following link:
> http://postfixadmin.normaal.fr/postfixadmin/list-virtual.php?domain=no
> rmaal.fr
> 
> Of, course, the correct link should be
> http://postfixadmin.normaal.fr/list-virtual.php?domain=normaal.fr
> 
> How to fix the error ?

Sounds like $CONF['postfix_admin_url'] contains a wrong value - in your 
case, it should be 'http://postfixadmin.normaal.fr' (I'm quite sure you 
have an additional "/postfixadmin" in it ;-)


Regards,

Christian Boltz
-- 
a) Du schickst keine Config
b) Du schickst kein Logfile
Da (a) und (b) nicht da ist, kann ich also nur mit (c) antworten:
(c) müßte aber gehen
[Peer Heinlein in postfixbuch-users]

[Postfixadmin-devel] Error 404 with vacation module

[Jean-Max R. <jmr...@fr...>]

Hi,
I am using postfixadmin 2.3.5 with Ubuntu server LTS 14.04. All is fine 
but I have some troubles with the vacation module. If a user set a 
vacation message, the quit button provide a 404 error for the following 
link:
http://postfixadmin.normaal.fr/postfixadmin/list-virtual.php?domain=normaal.fr

Of, course, the correct link should be 
http://postfixadmin.normaal.fr/list-virtual.php?domain=normaal.fr

How to fix the error ?
thanks for your tips,

-- 
Jean-Max Reymond
Éruption de l'Etna: http://jmreymond.free.fr/Etna2002

[Postfixadmin-devel] lastlogin

[Luigi R. <li...@lu...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dovecot 2.2.14 added last-login plugin that can record the time/date of last login

I wrote a procedure to integrate the lastlofin record in a Postfix Admin
installation:

http://dovecot.org/pipermail/dovecot/2014-October/098316.html

Can it be added in Postfix Admin standard interface? It would be a `lastlogin`
UNSIGNED INT field in `mailbox` table and the display of time date convertin
it from time() format.



Ciao,
luigi

- -- 
/
+--[Luigi Rosa]--
\

God made integers, all the rest is human work.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUQzQBAAoJEO5WT/qgw4yKJgQP/jHSBJ8eKWpNAMD8Ay+uVhTl
nAGHornbPFPtHcuB/PzJT12wRl2Uw0ykfVW+Xi1N6AftsybyZezts0GWgFr4bVAX
k9GXyVMggYA/MM0q8ZAdJaV7w/AVI+j2JetSKn+FSzmuXIK7MPbwAlD9d2FU/RNU
xC9pn3Xbgx+aRvMFPwiz+xFsSCdePylSG7Be0XBceffnX9YYS/HSOnfXyFukM2xQ
06R4MWCv8lMHbeL2nxCUSyY04u8M76/msr9tQ+Lc5IC2R2XKzgr8oVm2QcYFfLFe
RQbwg6dUOvuqNSTZHPP9tXdPJbJhNVrlGVz6ZTPZeshwPOAU5SCgdrdgb2Jc8KUI
bwLkRMiZShVq7/qxCo7umQbmLi3X/YLZHYcuwujfbCy5PbvhkmOBedhDJSf28YkA
B+t25KCDeyjo5eTWPjBqYJY86EsWtyhG+4jJr6BuIxLgwS2xWKgTkMgLgxGkh53N
MC/3TwoKnCPb7g8pGpcMFW5FiJQwKtewjXis+2V6OKgO3pkBzwjGECax9ydDIFT7
8DgLNoMfUz1440SgfTRSjqdLjzA30xQ7Xp2EerbJze9csU+okmKA8bePue1MOCQb
9XhCK3FbNUOuBAHHSZdjos7ryympWvB5szEsh43dgLqK/xSmAdHWTwTOclvFIvOh
8Kg81hMG9049c/b1bnHy
=j4FR
-----END PGP SIGNATURE-----

Re: [Postfixadmin-devel] Invalid domain name , fails regexp check

[Gabriel F. <ga...@le...>]

Hey there,

On 02/06/14 10:42 AM, Per Qvindesland wrote:
> Does anyone know how to disable the regexp check? I am trying to add or
> change anything in PFA but to no avail, I can add in domains but the
> second i try to add in a mail account I get stopped with this error,
> what is the regex check for?
> 
> Centos 6.5 X64 Postfix 2.6.6 dovecot 2.0.9 latest PFA

judging from the code:

 200 function check_domain ($domain) {
 201     if (!preg_match ('/^([-0-9A-Z]+\.)+' . '([0-9A-Z]){2,13}$/i',
($domain))) {
 202         return sprintf(Config::lang('pInvalidDomainRegex'),
htmlentities($domain));
 203     }

the error refers to the domain not being seen as valid according to the
above regexp
so a number of groups that consist of numbers, dashes, letters and
ending with a dot -- if I'm not mistaken, the i at the end of the regexp
means that it's case insensitive, so the A-Z block means capital and
lower case letters. then followed by a group of numbers and/or letters
that should be 2 to 13 letters long (so the TLD).

so because of the above check, you can't for example create a domain
like "localhost".

-- 
Gabriel Filion

[Postfixadmin-devel] Invalid domain name , fails regexp check

[Per Q. <per...@gm...>]

Hi All

Does anyone know how to disable the regexp check? I am trying to add or
change anything in PFA but to no avail, I can add in domains but the second
i try to add in a mail account I get stopped with this error, what is the
regex check for?

Centos 6.5 X64 Postfix 2.6.6 dovecot 2.0.9 latest PFA

Regards
Per Qvindesland

Re: [Postfixadmin-devel] Postfixadmin vs Iredmail

[Zhang H. <zh...@ir...>]

On May 20, 2014, at 6:13 AM, Christian Boltz <pos...@cb...> wrote:

> @Iredmail support:
> There's nothing wrong with comparisons - but if you put them online, 
> they should at least be correct ;-)

I removed this web page moment ago since i cannot keep the features of PostfixAdmin
up to date.

If it causes any inconvenience, i'm so sorry.

----
Zhang Huangbin, Founder of iRedMail project: http://www.iredmail.org/
Available on BBM.