postfixadmin-devel — Postfix Admin development talk - users are also welcome

Re: [Postfixadmin-devel] SF.net SVN: postfixadmin:[660] branches/postfixadmin-smarty/smarty

[Christian B. <pos...@cb...>]

Hello,

Am Montag, 18. Mai 2009 schrieb Seb...@us...:
> Update Smarty version (2.6.22 -> 2.6.24)
>
> Added Paths:
> -----------
>     branches/postfixadmin-smarty/smarty/libs/

Just a small technical note for the next smarty (or $other_lib) update: 
I'd prefer updates to be done as "real" updates (read: replace the 
files and let SVN find out the changes) instead of removing the old and 
adding the new files.

This will avoid needless SVN traffic (the update 2.6.22 -> 2.6.24 sounds 
more like bugfixes in some files than like a complete rewrite ;-) and 
preserve the SVN history.


Regards,

Christian Boltz
-- 
"Does your computer ever crash?"
"Oh definitely, believe me. We want to make a tool that we can use
ourselves and we know from our own use we can make it a lot better
and a lot more reliable."          [Bill Gates in a BBC interview]

Re: [Postfixadmin-devel] Unable to display mailboxes.

[<me...@td...>]

On Wed, 29 Apr 2009, Christian Boltz wrote:

> Hello,
>
> Am Mittwoch, 29. April 2009 schrieb me...@td...:
>
>> Invalid query: Unknown column 'quota.current' in 'field list'
>
>> $query = "SELECT $table_mailbox.*, $table_vacation.active AS
>> v_active, $table_quota.current FROM $table_mailbox [...]
>
> If I get it right, the current quota usage is tracked in the "bytes"
> column.

Yes and the messages column tracks the number of messages in the users
mailbox. As you can see in the dump below, te...@ex... has 
2 messages totaling 1980 bytes. te...@ex... and te...@ex...
each have 1 message totaling 995 bytes in each mailbox.

> You can probably fix the problem by modifying the SELECT query.
> Replace
>    $table_quota.current
> with
>    $table_quota.bytes as current
> and it should work (untested).

Looks like that worked. I put different values in the bytes field and
pfa seems to return a reasonable value in MB.

>> AND $table_quota.path='quota/storage' ORDER BY [...]
>
> See David's comment for this section of the query.

I removed the AND $table_quota.path='quota/storage' as per David's comment.
So now I have the following:

$query = "SELECT $table_mailbox.*, $table_vacation.active AS v_active,
 	$table_quota.bytes as current FROM $table_mailbox
 	LEFT JOIN $table_vacation ON $table_mailbox.username=$table_vacation.email
 	LEFT JOIN $table_quota ON $table_mailbox.username=$table_quota.username
 	WHERE $table_mailbox.domain='$fDomain' ORDER BY $table_mailbox.username
 	LIMIT $page_size OFFSET $fDisplay";

> Can you please send some example entries from your quota table? Without
> knowing what is in the table, it's hard to tell how the query should
> look like ;-)

The quota table currently looks like the following:

## Begin quota table dump ##

SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";

-- Database: `postfix1`
-- --------------------------------------------------------
--
-- Table structure for table `quota`
--

CREATE TABLE IF NOT EXISTS `quota` (
   `username` varchar(100) NOT NULL,
   `bytes` bigint(20) NOT NULL default '0',
   `messages` int(11) NOT NULL default '0',
   PRIMARY KEY  (`username`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8;

--
-- Dumping data for table `quota`
--

INSERT INTO `quota` (`username`, `bytes`, `messages`) VALUES
('te...@ex...', 1980, 2),
('te...@ex...', 995, 1),
('te...@ex...', 995, 1);

## End quota table dump ##

Just to be clear the quota table is maintained by dovecot.

Thanks for looking into this.

Regards,

-- 
Tom			me...@td...		Spamtrap address	 		me...@td...

Re: [Postfixadmin-devel] Unable to display mailboxes.

[Christian B. <pos...@cb...>]

Hello,

Am Mittwoch, 29. April 2009 schrieb me...@td...:
> According to the notes in config.inc.php, pfa is supposed to "Show
> used quotas from Dovecot dictionary backend in virtual mailbox
> listing." This is what is not working as far as I can tell. It
> appears to me that this was added by this patch:
> https://sourceforge.net/tracker/index.php?func=detail&aid=2060309&gro
>up_id=191583&atid=937966

Exactly.
(And I have to admit that I don't use dovecot, so I didn't test this.)

> Invalid query: Unknown column 'quota.current' in 'field list'

> $query = "SELECT $table_mailbox.*, $table_vacation.active AS
> v_active, $table_quota.current FROM $table_mailbox [...]

If I get it right, the current quota usage is tracked in the "bytes" 
column.

You can probably fix the problem by modifying the SELECT query.
Replace
    $table_quota.current
with
    $table_quota.bytes as current
and it should work (untested).

> AND $table_quota.path='quota/storage' ORDER BY [...]

See David's comment for this section of the query.

Can you please send some example entries from your quota table? Without 
knowing what is in the table, it's hard to tell how the query should 
look like ;-)

> Should I file a bug in the tracker for this?

For now, just tell me if my fix in the SQL query works ;-)


Regards,

Christian Boltz
-- 
PS: Ich denke, wir unterhalten uns hier
lieber mit Menschen statt mit Mohnbroetchen...
[Thomas Hertweck zu fo_mohnbroetchen(AT)gmx.de in suse-linux]

Re: [Postfixadmin-devel] Unable to display mailboxes.

[David G. <da...@co...>]

>> If you remove the 'AND $table_quota.path='quota/storage' it will work
>> as expected.
>
> Cool except that under my current config, I am getting a different error.
> pfa does not seem to like the $table_quota.current entry above.
>
> When I sent the first message, I did not realize just how different the
> old style and new style dovecot quotas were. :(
>
> I modified the above query as per your suggestion above and I also changed
> $table_quota.current to $table_quota.username and now I get Quota used 0/50.
> I think I am wrong with what I did though. If I increase the the bytes value
> in the quota table and refresh pfa, I would expect the number 0 in 0/50 to get
> larger to reflect what I added to the db but it still says 0/50. Do you have
> any idea what I need to set the query above to to get things working?
>
>>
>> Unfortunately your quota table has no information within it, so I
>> can't tell whether the above is 'valid' or not.
>
> The dump I sent in my previous message contains 1 line of data that was
> inserted by dovecot. Does this help or do you need more data?
>
>> Does this help?
>
> The fact that you are willing to help me is a big help but we are not quite
> there yet. :) I appreciate your time.
>

1) Please file a bug in the tracker for this.

2) Does the new quota table get automatically updated by dovecot when
messages are delivered?

thanks
David.



-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Re: [Postfixadmin-devel] Unable to display mailboxes.

[<me...@td...>]

HI David,

Sorry I did not see this until after I sent my previous message.

On Wed, 29 Apr 2009, David Goodwin wrote:

> David Goodwin wrote :
>>>>
>>>> Hmm. Would it be possible for me to get a DB dump?
>>>>
>>>> (Specifically the alias and mailbox tables)
>>>
>>> Sure. I have attached 3 tables, mailbox, alias, and quota.
>>>
>>> I did a little more investigation and found that if I set $CONF['used_quotas']
>>> to no then the mailbox data shows up. If I reset it to yes then the mailbox
>>> data goes away.
>>
>> Ah. That's interesting.
>
>
> Right, I can replicate this - but (as before) I don't use quotas or
> dovecot.
>
> In list-virtual.php there's a query that reads somewhat like :
>
> "SELECT $table_mailbox.*, $table_vacation.active AS v_active,
> $table_quota.current FROM $table_mailbox
>    LEFT JOIN $table_vacation ON $table_mailbox.username=$table_vacation.email
>    LEFT JOIN $table_quota ON $table_mailbox.username=$table_quota.username
>    WHERE $table_mailbox.domain='$fDomain'
>    AND $table_quota.path='quota/storage'
>        ORDER BY $table_mailbox.username
>        LIMIT $page_size
>        OFFSET $fDisplay"
>
> If you remove the 'AND $table_quota.path='quota/storage' it will work
> as expected.

Cool except that under my current config, I am getting a different error.
pfa does not seem to like the $table_quota.current entry above.

When I sent the first message, I did not realize just how different the
old style and new style dovecot quotas were. :(

I modified the above query as per your suggestion above and I also changed
$table_quota.current to $table_quota.username and now I get Quota used 0/50.
I think I am wrong with what I did though. If I increase the the bytes value
in the quota table and refresh pfa, I would expect the number 0 in 0/50 to get
larger to reflect what I added to the db but it still says 0/50. Do you have
any idea what I need to set the query above to to get things working?

>
> Unfortunately your quota table has no information within it, so I
> can't tell whether the above is 'valid' or not.

The dump I sent in my previous message contains 1 line of data that was
inserted by dovecot. Does this help or do you need more data?

> Does this help?

The fact that you are willing to help me is a big help but we are not quite
there yet. :) I appreciate your time.

Regards,

-- 
Tom			me...@td...		Spamtrap address	 		me...@td...

Re: [Postfixadmin-devel] Unable to display mailboxes.

[<me...@td...>]

On Tue, 28 Apr 2009, David Goodwin wrote:

>> I did a little more investigation and found that if I set $CONF['used_quotas']
>> to no then the mailbox data shows up. If I reset it to yes then the mailbox
>> data goes away.
>
> Ah. That's interesting.
>
>>
>> While I am talking about quotas, assuming a reasonable dovecot config, is it
>> reasonable to expect that dovecot v1.2+ quotas will work with pfa?
>> http://wiki.dovecot.org/Quota/Dict indicates that the 1.2+ quotas are
>> different. If I use something like below to create the quota table, will
>> pfa know how to use the data that gets put in there?
>>
>
> As much as PFA can use the data in there; I suspect so.
>
>> CREATE TABLE quota (
>>   username varchar(100) not null,
>>   bytes bigint not null default 0,
>>   messages integer not null default 0,
>>   primary key (username)
>> );
>>
>> When I created the quota table I attached, I used what is in the DOVECOT.txt
>> file included with pfa. My intent is to use pfa with dove 1.2 so if I can do
>> something to get quotas working, that would be a good thing.
>>
>
> I've never used dovecot; or quotas... so I don't really know anything

I never used dovecot quotas either!! I am still learning how they work. :)

> about it. I'm guessing that table is used to keep a track of the
> current quota usage - as opposed to the limit (which is all PFA cares
> about).

According to the notes in config.inc.php, pfa is supposed to "Show used quotas
from Dovecot dictionary backend in virtual mailbox listing." This is what
is not working as far as I can tell. It appears to me that this was added
by this patch:
https://sourceforge.net/tracker/index.php?func=detail&aid=2060309&group_id=191583&atid=937966

Anyway upon further investigation it appears that the Dovecot V1.2 quota
setup is completely different from previous versions. I followed the
instructions at http://wiki.dovecot.org/Quota/Dict. According to this
document there was a problem with quota calculations in previous versions
under certain conditions. The new way to track quotas fixes this.

So, I configured dovecot as per the instructions for dovecot V1.2 on the 
dovecot wiki. Dovecot and quotas appear to work except that I cannot display
the used quotas. If I enable $CONF['used_quotas'] and try to display the
mailboxes I get the following errors:

DEBUG INFORMATION:
Invalid query: Unknown column 'quota.current' in 'field list'

This error appears to come from list-virtual.php on about line 171.

I think the problem is with the line:

$query = "SELECT $table_mailbox.*, $table_vacation.active AS v_active, $table_quota.current FROM $table_mailbox LEFT JOIN $table_vacation ON $table_mailbox.username=$table_vacation.email LEFT JOIN $table_quota ON $table_mailbox.username=$table_quota.username WHERE $table_mailbox.domain='$fDomain' AND $table_quota.path='quota/storage' ORDER BY $table_mailbox.username LIMIT $page_size OFFSET $fDisplay";

but I am not sure since I am not a programmer.

Below are the relevant config files.

############### Begin MySQL Quota table ##########################################

-- Generation Time: Apr 29, 2009 at 03:13 PM

SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";


/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
/*!40101 SET NAMES utf8 */;

--
-- Database: `postfix1`
--

-- --------------------------------------------------------

--
-- Table structure for table `quota`
--

CREATE TABLE IF NOT EXISTS `quota` (
   `username` varchar(100) NOT NULL,
   `bytes` bigint(20) NOT NULL default '0',
   `messages` int(11) NOT NULL default '0',
   PRIMARY KEY  (`username`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8;

--
-- Dumping data for table `quota`
--

INSERT INTO `quota` (`username`, `bytes`, `messages`) VALUES
('te...@ex...', 1980, 2);

############### End MySQL Quota table ##########################################

################### Begin dovecot-dict-quota.conf ##########################

# v1.2+ only:
connect = host=localhost dbname=postfix user=postfix password=my_pass
map {
   pattern = priv/quota/storage
   table = quota
   username_field = username
   value_field = bytes
}
map {
   pattern = priv/quota/messages
   table = quota
   username_field = username
   value_field = messages
}

################### End dovecot-dict-quota.conf ##########################

When I send a message to a valid mailbox, the quota table gets populated with
the correct info.

Can someone look at this and give me an idea what I need to do to get this
working?

Should I file a bug in the tracker for this?

Regards,

-- 
Tom			me...@td...		Spamtrap address	 		me...@td...

Re: [Postfixadmin-devel] Unable to display mailboxes.

[David G. <da...@co...>]

David Goodwin wrote :
> >>
> >> Hmm. Would it be possible for me to get a DB dump?
> >>
> >> (Specifically the alias and mailbox tables)
> >
> > Sure. I have attached 3 tables, mailbox, alias, and quota.
> >
> > I did a little more investigation and found that if I set $CONF['used_quotas']
> > to no then the mailbox data shows up. If I reset it to yes then the mailbox
> > data goes away.
> 
> Ah. That's interesting.


Right, I can replicate this - but (as before) I don't use quotas or
dovecot.

In list-virtual.php there's a query that reads somewhat like :

"SELECT $table_mailbox.*, $table_vacation.active AS v_active,
$table_quota.current FROM $table_mailbox 
    LEFT JOIN $table_vacation ON $table_mailbox.username=$table_vacation.email 
    LEFT JOIN $table_quota ON $table_mailbox.username=$table_quota.username 
    WHERE $table_mailbox.domain='$fDomain'  
    AND $table_quota.path='quota/storage'
        ORDER BY $table_mailbox.username
        LIMIT $page_size
        OFFSET $fDisplay"

If you remove the 'AND $table_quota.path='quota/storage' it will work
as expected.

Unfortunately your quota table has no information within it, so I
can't tell whether the above is 'valid' or not.

Does this help?

David.
-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Re: [Postfixadmin-devel] database connection (not using std. port

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 28. April 2009 schrieb David Goodwin:
> Bird wrote:
> > I do NOT use the standard port 55xx for postgresql.
> >
> > How can I add the selected port in confic.inc.php ?
> > $CONF['port'] = 'xxxxx'
>
> See functions.inc.php - there is a function called 'db_connect()'
> which contains something like :

>             $connect_string = "host=" . $CONF['database_host'] . "
> dbname=" . $CONF['database_name'] . " user=" . $CONF['database_user']
> . " password=" . $CONF['database_password'];
>             $link = @pg_pconnect ($connect_string) or $error_text .=

> http://php.net/pg_connect which will show you how you can change the
> pg_pconnect line. (I suspect you just need "port=1234 " in the
> $connect_string somewhere.

Some small hints:
- You don't need to change the functions.inc.php code. Just use 
  something like $CONF['database_password'] = "topsecret port=1234" ;-)
- You can also connect to a socket - try 
  $CONF['database_host'] = "/path/to/the/socket"

Reading tips:
- php.net/pg_connect (as already suggested by David) and especially the 
  user comments on this page
- http://www.postgresql.org/docs/8.3/static/libpq-connect.html for 
  details what you can specify in the connection string

Note: This answer is based on reading the listed documentation. I did 
not test it myself.


Regards,

Christian Boltz
-- 
Ich bin nicht stolz auf das unnoetige Icon "Arbeitsplatz" auf
dem Desktop. Irgendwann sieht man nur noch per "uname -a", ob
das richtige System laeuft...   [Thomas Moritz in suse-linux]

Re: [Postfixadmin-devel] database connection (not using std. port

[David G. <da...@co...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bird wrote:
> Message body follows:
> 
> Hi,
> 
> I do NOT use the standard port 55xx for postgresql.
> 
> How can I add the selected port in confic.inc.php ?
> $CONF['port'] = 'xxxxx'
> 
> this did not work:
> $CONF['database_port'] = 'xxxxx';
> 
> I use NOT the standard port for postgresql because
> I do not want to reveal the type of database
> with a portscan by nmap for an application.
> 
> Thank you !


Hi,

See functions.inc.php - there is a function called 'db_connect()' which
contains something like :


    elseif ($CONF['database_type'] == "pgsql")
    {
        if (function_exists ("pg_pconnect"))
        {
            $connect_string = "host=" . $CONF['database_host'] . "
dbname=" . $CONF['database_name'] . " user=" . $CONF['database_user'] .
" password=" . $CONF['database_password'];
            $link = @pg_pconnect ($connect_string) or $error_text .=
("<p />DEBUG INFORMATION:<br />Connect: failed to connect to database.
$DEBUG_TEXT");
            if ($link) pg_set_client_encoding($link, 'UNICODE');
        }
        else
        {
            $error_text .= "<p />DEBUG INFORMATION:<br />PostgreSQL
functions not available!<br />database_type = 'pgsql' in config.inc.php,
are you using a different database? $DEBUG_TEXT";
        }
    }



http://php.net/pg_connect which will show you how you can change the
pg_pconnect line. (I suspect you just need "port=1234 " in the
$connect_string somewhere.

thanks
David.
- --
David Goodwin

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkn2wwYACgkQ/ISo3RF5V6aIFgCg8Hnm3+7phBlRoWi2dPz52heR
TQAAniciUIBZapRGcDoV3cZb+GY5EApk
=NJ3n
-----END PGP SIGNATURE-----

Re: [Postfixadmin-devel] Unable to display mailboxes.

[David G. <da...@co...>]

>>
>> Hmm. Would it be possible for me to get a DB dump?
>>
>> (Specifically the alias and mailbox tables)
>
> Sure. I have attached 3 tables, mailbox, alias, and quota.
>
> I did a little more investigation and found that if I set $CONF['used_quotas']
> to no then the mailbox data shows up. If I reset it to yes then the mailbox
> data goes away.

Ah. That's interesting.

>
> While I am talking about quotas, assuming a reasonable dovecot config, is it
> reasonable to expect that dovecot v1.2+ quotas will work with pfa?  
> http://wiki.dovecot.org/Quota/Dict indicates that the 1.2+ quotas are
> different. If I use something like below to create the quota table, will
> pfa know how to use the data that gets put in there?
>

As much as PFA can use the data in there; I suspect so.

> CREATE TABLE quota (
>   username varchar(100) not null,
>   bytes bigint not null default 0,
>   messages integer not null default 0,
>   primary key (username)
> );
>
> When I created the quota table I attached, I used what is in the DOVECOT.txt
> file included with pfa. My intent is to use pfa with dove 1.2 so if I can do
> something to get quotas working, that would be a good thing.
>

I've never used dovecot; or quotas... so I don't really know anything
about it. I'm guessing that table is used to keep a track of the
current quota usage - as opposed to the limit (which is all PFA cares
about).


Thanks
David.

Re: [Postfixadmin-devel] Unable to display mailboxes.

[<me...@td...>]

Hi David,

On Mon, 27 Apr 2009, David Goodwin wrote:

>>> 2) It seems to work for me - see attached .jpg.
>>
>> OK, I agree it is working for you but please look at the attached screen shot.
>> As you can see, the info in the green bar says there is 1 mailbox but the gray
>> bar that normally says mailboxes is missing as well as the mailbox info.
>>
>> Do you have any idea how I can troubleshoot this problem? Is there anything in
>> the config.inc.php that I could be setting that would cause this? I do not see
>> anything but I am not a programmer.
>>
>
> Hmm. Would it be possible for me to get a DB dump?
>
> (Specifically the alias and mailbox tables)

Sure. I have attached 3 tables, mailbox, alias, and quota.

I did a little more investigation and found that if I set $CONF['used_quotas']
to no then the mailbox data shows up. If I reset it to yes then the mailbox
data goes away.

While I am talking about quotas, assuming a reasonable dovecot config, is it
reasonable to expect that dovecot v1.2+ quotas will work with pfa? 
http://wiki.dovecot.org/Quota/Dict indicates that the 1.2+ quotas are
different. If I use something like below to create the quota table, will
pfa know how to use the data that gets put in there?

CREATE TABLE quota (
   username varchar(100) not null,
   bytes bigint not null default 0,
   messages integer not null default 0,
   primary key (username)
);

When I created the quota table I attached, I used what is in the DOVECOT.txt
file included with pfa. My intent is to use pfa with dove 1.2 so if I can do
something to get quotas working, that would be a good thing.

Thanks for the help,

Regards,

-- 
Tom			me...@td...		Spamtrap address	 		me...@td...

Re: [Postfixadmin-devel] Unable to display mailboxes.

[David G. <da...@co...>]

>> 2) It seems to work for me - see attached .jpg.
>
> OK, I agree it is working for you but please look at the attached screen shot.
> As you can see, the info in the green bar says there is 1 mailbox but the gray
> bar that normally says mailboxes is missing as well as the mailbox info.
>
> Do you have any idea how I can troubleshoot this problem? Is there anything in
> the config.inc.php that I could be setting that would cause this? I do not see
> anything but I am not a programmer.
>

Hmm. Would it be possible for me to get a DB dump?

(Specifically the alias and mailbox tables)

thanks
David.

Re: [Postfixadmin-devel] Unable to display mailboxes.

[<me...@td...>]

HI David,

On Mon, 27 Apr 2009, David Goodwin wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> me...@td... wrote:
>> Hi,
>>
>> In testing svn 627 I noticed that if I add a mailbox it gets added but when
>> I click on the "virtual List" link I see the aliases but no mailboxes. Is
>> this a bug or am I missing something?
>>
>> FWIW, if I look at the mysql db, I see the mailboxes I added. I am not sure
>> when this stopped working.
>>
>> I updated to svn 646 and there was no change in behavior. Setup.php shows
>> no errors.
>>
>> Also in the green header bar it says "Aliases: 4 / 30 Mailboxes: 1 / 30" This
>> is correct but no mailboxes are displayed.
>>
>> Regards,
>>
>
> Err.
>
> 1) Latest version is 646

Upgrading to 646 did not make a difference.

>
> 2) It seems to work for me - see attached .jpg.

OK, I agree it is working for you but please look at the attached screen shot.
As you can see, the info in the green bar says there is 1 mailbox but the gray
bar that normally says mailboxes is missing as well as the mailbox info.

Do you have any idea how I can troubleshoot this problem? Is there anything in
the config.inc.php that I could be setting that would cause this? I do not see
anything but I am not a programmer.

Regards,

-- 
Tom			me...@td...		Spamtrap address	 		me...@td...

Re: [Postfixadmin-devel] Unable to display mailboxes.

[David G. <da...@co...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

me...@td... wrote:
> Hi,
> 
> In testing svn 627 I noticed that if I add a mailbox it gets added but when
> I click on the "virtual List" link I see the aliases but no mailboxes. Is
> this a bug or am I missing something?
> 
> FWIW, if I look at the mysql db, I see the mailboxes I added. I am not sure
> when this stopped working.
> 
> I updated to svn 646 and there was no change in behavior. Setup.php shows
> no errors.
> 
> Also in the green header bar it says "Aliases: 4 / 30 Mailboxes: 1 / 30" This
> is correct but no mailboxes are displayed.
> 
> Regards,
> 

Err.

1) Latest version is 646

2) It seems to work for me - see attached .jpg.

thanks
David.

- --
David Goodwin

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkn1wOAACgkQ/ISo3RF5V6a1QgCdFx9gqGsSdHPLxTmaPowk9swS
qpQAoJQrtIfj/qPdpBzvGdbriXun79MA
=Mj0C
-----END PGP SIGNATURE-----

[Postfixadmin-devel] Unable to display mailboxes.

[<me...@td...>]

Hi,

In testing svn 627 I noticed that if I add a mailbox it gets added but when
I click on the "virtual List" link I see the aliases but no mailboxes. Is
this a bug or am I missing something?

FWIW, if I look at the mysql db, I see the mailboxes I added. I am not sure
when this stopped working.

I updated to svn 646 and there was no change in behavior. Setup.php shows
no errors.

Also in the green header bar it says "Aliases: 4 / 30 Mailboxes: 1 / 30" This
is correct but no mailboxes are displayed.

Regards,

-- 
Tom			me...@td...		Spamtrap address	 		me...@td...

Re: [Postfixadmin-devel] config.local.php not being read.

[Christian B. <pos...@cb...>]

Hello,

Am Mittwoch, 22. April 2009 schrieb David Goodwin:
> > I've just seen that you have removed the check if the
> > setup_password is "changeme" - but you have kept the check if it is
> > set at all.
> >
> > I'd vote to remove this check also (because it will cause problems
> > [aka lock postfixadmin] on upgrade if the old config.inc.php is
> > still used) and adds no security.
>
> No objections.

Done.

> > > > I also think that we no longer need to use the "developer hack"
> > > >     $CONF['configured'] =
> > > > 'I_know_the_risk_of_not_deleting_setup.php' and should remove
> > > > the code sections checking for it (index.php, login.php).
> >
> > (still ToDo)
>
> Thought this had been dropped.. .ho hum.

Done.

This also fixes a bug that was well-hidden for developers. The old code 
was:

if (!file_exists (realpath ("./setup.php")) || $CONF['configured'] ==
        'I_know_the_risk_of_not_deleting_setup.php') {
     header ("Location: login.php");

-> No redirect was done for $CONF[configured] == TRUE because setup.php 
is not deleted anymore.

> > > I'll try and review the code shortly; I did wonder if the
> > > setup_password would be better off stored in the database, and we
> > > just supply a trivial 'passwd' type script which (when run)
> > > allows 'root' to set/change it?
>
> I had a look at it - and could see no obvious problems.

OK, good to hear.

> > Entering the wanted password in setup.php and copying the config
> > sniplet to config.inc.php is easy enough IMHO ;-)
>
> Yes. It would be nice if it was more user friendly - e.g. one form to
> generate the setup password, another to do the admin bit.

Sounds like a good idea. I'll see when I find the time to implement it.

> > BTW: Any news on the "alias magic and domain admins" bug?
> > http://sourceforge.net/tracker/?func=detail&aid=2745147&group_id=19
> >1583&atid=937964 (That's the only release blocker I'm currently
> > aware of...)
>
> I know how to solve it; I just haven't yet.

OK, then I don't need to waste time for searching for the solution ;-)


Regards,

Christian Boltz
-- 
I have the ideal solution for you to speed up the writing of
the manuals: http://www.lipsum.com/ - I am sure almost nobody
will notice the difference. ;-)   [houghi in opensuse-wiki]

Re: [Postfixadmin-devel] config.local.php not being read.

[David G. <da...@co...>]

> I've just seen that you have removed the check if the setup_password 
> is "changeme" - but you have kept the check if it is set at all.
> 
> I'd vote to remove this check also (because it will cause problems [aka 
> lock postfixadmin] on upgrade if the old config.inc.php is still used) 
> and adds no security.
> 
> Any objections?

No objections.

> 
> > > I also think that we no longer need to use the "developer hack"
> > >     $CONF['configured'] =
> > > 'I_know_the_risk_of_not_deleting_setup.php' and should remove the
> > > code sections checking for it (index.php, login.php).
> 
> (still ToDo)

Thought this had been dropped.. .ho hum.

> 
> > I'll try and review the code shortly; I did wonder if the
> > setup_password would be better off stored in the database, and we
> > just supply a trivial 'passwd' type script which (when run) allows
> > 'root' to set/change it?
> 

I had a look at it - and could see no obvious problems.


> 
> Entering the wanted password in setup.php and copying the config sniplet 
> to config.inc.php is easy enough IMHO ;-)
> 

Yes. It would be nice if it was more user friendly - e.g. one form to
generate the setup password, another to do the admin bit.

> 
> BTW: Any news on the "alias magic and domain admins" bug?
> http://sourceforge.net/tracker/?func=detail&aid=2745147&group_id=191583&atid=937964
> (That's the only release blocker I'm currently aware of...)

I know how to solve it; I just haven't yet.

David.
-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Re: [Postfixadmin-devel] config.local.php not being read.

[Christian B. <pos...@cb...>]

Hello,

Am Donnerstag, 16. April 2009 schrieb David Goodwin:
> Christian Boltz wrote :
> > Am Dienstag, 14. April 2009 schrieb David Goodwin:

> > Note: I'll remove the check for $CONF['setup_password'] from
> > common.php again because:

I've just seen that you have removed the check if the setup_password 
is "changeme" - but you have kept the check if it is set at all.

I'd vote to remove this check also (because it will cause problems [aka 
lock postfixadmin] on upgrade if the old config.inc.php is still used) 
and adds no security.

Any objections?

> > I also think that we no longer need to use the "developer hack"
> >     $CONF['configured'] =
> > 'I_know_the_risk_of_not_deleting_setup.php' and should remove the
> > code sections checking for it (index.php, login.php).

(still ToDo)

> I'll try and review the code shortly; I did wonder if the
> setup_password would be better off stored in the database, and we
> just supply a trivial 'passwd' type script which (when run) allows
> 'root' to set/change it?

IMHO: No, please keep it in config.inc.php - that's the easiest and most 
secure solution I can think of.

> At the very least, I suspect we need to make it easy for people to
> generate the hashed value.... else we'll have zillions of forum
> posts.

Entering the wanted password in setup.php and copying the config sniplet 
to config.inc.php is easy enough IMHO ;-)


BTW: Any news on the "alias magic and domain admins" bug?
http://sourceforge.net/tracker/?func=detail&aid=2745147&group_id=191583&atid=937964
(That's the only release blocker I'm currently aware of...)


Regards,

Christian Boltz
-- 
> The issue here is the one of disk space... How do you know before hand
> there is enough disk space in /boot and /lib?
Err, ask Mr. Filesystem and, given your hd has turned ROM because it's
full, fail gracefully?
[> Marcus Meissner and Wolfgang Woehl in opensuse-factory]

Re: [Postfixadmin-devel] vacation.pl 3.1 and multiple messages

[David G. <da...@co...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Luigi Rosa wrote:
> Hi,
> I am expecting that when a user sets a vacation, the vacation system sends only
> one message per recipient.
> 
> My actual installation sends a reply for each message it receive. Is this a bug
> or an expected behaviour?
> 
> Thank you!
> 


Hello Luigi,

Yes, by default it will send the "I'm on vacation" message only once to
each sender. However, it is possible to edit the vacation.pl script and
tell it to send the message again - after a set time has passed. Perhaps
you've changed this?


I'd suggest you look in the debug log file
(/var/spool/vacation/vacation.log?) to see if that helps.


Thanks
David.

- --
David Goodwin

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknnIuwACgkQ/ISo3RF5V6YVogCg1e4s1rsRdnxRyzOMCv9qxEon
VucAoMnn//GzF8aDl8/xdqh0mLL67n77
=auUx
-----END PGP SIGNATURE-----

[Postfixadmin-devel] vacation.pl 3.1 and multiple messages

[Luigi R. <li...@lu...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
I am expecting that when a user sets a vacation, the vacation system sends only
one message per recipient.

My actual installation sends a reply for each message it receive. Is this a bug
or an expected behaviour?

Thank you!


Ciao,
luigi

- --
/
+--[Luigi Rosa]--
\

A rolling stone gathers momentum.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknm1XQACgkQ3kWu7Tfl6ZQEzACfd98kMfYVCooSeiz0m722KcC1
umYAoMSgAGKKtuT6mP+sdp7xuXx1tF90
=zcm9
-----END PGP SIGNATURE-----

Re: [Postfixadmin-devel] config.local.php not being read.

[David G. <da...@co...>]

Christian Boltz wrote :
> Hello,
> 
> Am Dienstag, 14. April 2009 schrieb David Goodwin:
> > > OK. Change to use md5/sha1/whatever (perhaps embed sha1: at the
> > > start of the string??)
> >
> > Having a reasonable salt might be a good idea too - even if it is
> > just something stupid like 'postfixadmin'
> 
> Indeed, using a salt is always a good idea. However, I don't like the 
> static value.
> 
> I just commited a modified version of setup.php (r629) which uses hashed 
> and salted passwords (sorry, no pepper ;-)
> 
> The salt is a md5-hash computed from the remote IP, the time and a 
> random value. This might not be cyrptically perfect, but I doubt there 
> will be two postfixadmin installations using the same salt ;-)
> (Of course, when checking against the password in config.inc.php, the 
> salt is read from $CONF.)
> 
> The salt and the password are then hashed with sha1.
> 
> If someone enters a wrong setup password, he will get the hash of 
> his/her password displayed copy&paste ready for inclusion in 
> config.inc.php.
> 
> 
> Please proofread my code - this is highly security relevant, therefore 
> another pair of eyes are a good idea. Also test setup.php with valid 
> and invalid setup passwords.
> 
> Note: I'll remove the check for $CONF['setup_password'] from common.php 
> again because:
> - it's no longer really needed - no hashed password will result in 
>   something simple like "changeme" or an empty string
> - checking the setup_password in setup.php (the only place where it is 
>   used) is enough
> - blocking the whole postfixadmin just because the setup password has 
>   not been set (= current behaviour) will cause lots of needless 
>   problems if someone upgrades from a previous version.
> - The admin _will_ setup a password for sure as soon as he needs to 
>   create a super-admin via setup.php ;-)
> - (if I missed an argument why to keep the check in common.php, please 
>   speak up!)
> 
> I also think that we no longer need to use the "developer hack"
>     $CONF['configured'] = 'I_know_the_risk_of_not_deleting_setup.php'
> and should remove the code sections checking for it (index.php, 
> login.php).

I agree.

I'll try and review the code shortly; I did wonder if the
setup_password would be better off stored in the database, and we just
supply a trivial 'passwd' type script which (when run) allows 'root'
to set/change it?

At the very least, I suspect we need to make it easy for people to
generate the hashed value.... else we'll have zillions of forum posts.

David.

-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Re: [Postfixadmin-devel] config.local.php not being read.

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 14. April 2009 schrieb David Goodwin:
> > OK. Change to use md5/sha1/whatever (perhaps embed sha1: at the
> > start of the string??)
>
> Having a reasonable salt might be a good idea too - even if it is
> just something stupid like 'postfixadmin'

Indeed, using a salt is always a good idea. However, I don't like the 
static value.

I just commited a modified version of setup.php (r629) which uses hashed 
and salted passwords (sorry, no pepper ;-)

The salt is a md5-hash computed from the remote IP, the time and a 
random value. This might not be cyrptically perfect, but I doubt there 
will be two postfixadmin installations using the same salt ;-)
(Of course, when checking against the password in config.inc.php, the 
salt is read from $CONF.)

The salt and the password are then hashed with sha1.

If someone enters a wrong setup password, he will get the hash of 
his/her password displayed copy&paste ready for inclusion in 
config.inc.php.


Please proofread my code - this is highly security relevant, therefore 
another pair of eyes are a good idea. Also test setup.php with valid 
and invalid setup passwords.

Note: I'll remove the check for $CONF['setup_password'] from common.php 
again because:
- it's no longer really needed - no hashed password will result in 
  something simple like "changeme" or an empty string
- checking the setup_password in setup.php (the only place where it is 
  used) is enough
- blocking the whole postfixadmin just because the setup password has 
  not been set (= current behaviour) will cause lots of needless 
  problems if someone upgrades from a previous version.
- The admin _will_ setup a password for sure as soon as he needs to 
  create a super-admin via setup.php ;-)
- (if I missed an argument why to keep the check in common.php, please 
  speak up!)

I also think that we no longer need to use the "developer hack"
    $CONF['configured'] = 'I_know_the_risk_of_not_deleting_setup.php'
and should remove the code sections checking for it (index.php, 
login.php).


Regards,

Christian Boltz
-- 
>und was ist "Winter"?
Ein Zeitraum, in dem von der Decke des grossen blauen Raum gelegentlich
groessere oder kleinere Mengen kalten weissen Drecks fallen, der aus
kristallinem Dihydrogenmonoxid besteht.        [Alexander Schreiber]

Re: [Postfixadmin-devel] config.local.php not being read.

[Christian B. <pos...@cb...>]

Hello,

Am Dienstag, 14. April 2009 schrieb tan...@li...:
> See what I get for unleashing my fingers on a dev mail list? ;)

You get answers, nothing else ;-)

And I'm glad you have a look at what we are doing and point out possible 
problems before they can hit someone. Even if the problem is "just" an 
unclear mail, it's better to ask.


Regards,

Christian Boltz
-- 
"Microsoft spel chekar worgs grate!"

Re: [Postfixadmin-devel] config.local.php not being read.

[<tan...@li...>]

On 4/13/2009 5:39 PM, Christian Boltz wrote:
> The $CONF['setup_password'] is the super-super-admin ;-) password needed 
> to create new super-admins via setup.php. This is what I want to store 
> in a hashed format (md5, sha1).

Oh, right... should have seen that... sorry... :)

> This change won't affect the passwords you have in your database for 
> (super-)admins and mailboxes.
> 
> To make the story short: You'll (only) have to edit 
> $CONF['setup_password'].

Right... thanks, and sorry for the noise...

See what I get for unleashing my fingers on a dev mail list? ;)

Re: [Postfixadmin-devel] config.local.php not being read.

[David G. <da...@co...>]

> OK. Change to use md5/sha1/whatever (perhaps embed sha1: at the start
> of the string??)
> 

Having a reasonable salt might be a good idea too - even if it is just
something stupid like 'postfixadmin'

David.


-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]