postfixadmin-devel — Postfix Admin development talk - users are also welcome

Re: [Postfixadmin-devel] Request help/comment on Feature Requests-2813224 : End user customization of header strings for vacation

[David G. <da...@co...>]

> 
> Above that section where the headers get examined, there is this section:
> 
> # Make sure the email wasn't sent by someone who could be a mailing
> # list etc; if it was, then we abort after appropriate logging.
> sub check_and_clean_from_address {
>     my ($address) = @_;
>     my $logger = get_logger();
> 
>     if($address =~ 
> /^(noreply|postmaster|mailer\-daemon|listserv|majordomo|owner\-|request\-|bounces\-)/i 
> ||
>         $address =~ /\-(owner|request|bounces)\@/i ) {
>         $logger->debug("sender $address contains $1 - will not send 
> vacation message");
>         exit(0);
>     }
> 



> First question: would the from= address that I saw in my postfix log be 
> matched by the $address variable above?
> 

Yes.

> Anyway, my overall goal here is concerning the huge growth in these 
> social networking sites - shouldn't vacation.pl specifically take these 
> systems into account? Meaning, rather than us sysadmins just trying to 
> keep up with these individually, shouldn't official support be added to 
> vacation.pl for these services?
> 


Yes, it probably should. I suspect not many people are using it - hence there haven't been many patches/bugs/whatever reported.



> Next question: do you agree that this is the more appropriate place for 
> checks for these kinds of services? I think these social networking 
> services definitely fall into the category of 'etc' in the comments.
> 
> So, I'm thinking we could modify that text to:
> 
> # Make sure the email wasn't from a mailing list, an automated message
> # from a social networking site, etc; if it was, then we abort after
> # appropriate logging.
> 
> Then, modify the code appropriately with as many known examples as possible.
> 


Yes.


> 
> So, with this in mind, if I modified the above to, say, something like:
> 
>     if($address =~ 
> /^(noreply|postmaster|mailer\-daemon|listserv|majordomo|owner\-|request\-|bounces\-)/i 
> ||
>         $address =~ /\-(owner|request|bounce|bounces)\@/i ) {
>         $logger->debug("sender $address contains $1 - will not send 
> vacation message");
>         exit(0);
>     }
> 
> (I simply added 'bounce' before 'bounces')
> 
> Would that catch the example I gave from linkedin, since it is 
> from=blahblah.bounce.linkedin.com (bounce is singular, not plural)?
> 

What you've added is looking for -bounce@

Which will not match bla...@bo...


> Also - is that a 'contains' search? If so, I'm guessing I could remove 
> the plural form (bounces), since that would also be matched by 'bounce'?
> 

No. The @ has to follow one of the things in the brackets (owner|request|bouce|bounces)



thanks,

David.

Re: [Postfixadmin-devel] Request help/comment on Feature Requests-2813224 : End user customization of header strings for vacation

[Tanstaafl <tan...@li...>]

Hi David,

Many thanks for your response, but a few follow-up questions...

I actually think I just noticed that there may be a more appropriate 
place in vacation.pl for what I'm trying to do...

Above that section where the headers get examined, there is this section:

# Make sure the email wasn't sent by someone who could be a mailing
# list etc; if it was, then we abort after appropriate logging.
sub check_and_clean_from_address {
     my ($address) = @_;
     my $logger = get_logger();

     if($address =~ 
/^(noreply|postmaster|mailer\-daemon|listserv|majordomo|owner\-|request\-|bounces\-)/i 
||
         $address =~ /\-(owner|request|bounces)\@/i ) {
         $logger->debug("sender $address contains $1 - will not send 
vacation message");
         exit(0);
     }
     $address = strip_address($address);
     if($address eq "") {
         $logger->error("Address $address is not valid; exiting");
         exit(0);
     }
     #$logger->debug("Address cleaned up to $address");
     return $address;
}

This appears to be a much better section to do what I really think needs 
to be done....

First question: would the from= address that I saw in my postfix log be 
matched by the $address variable above?

Anyway, my overall goal here is concerning the huge growth in these 
social networking sites - shouldn't vacation.pl specifically take these 
systems into account? Meaning, rather than us sysadmins just trying to 
keep up with these individually, shouldn't official support be added to 
vacation.pl for these services?

There is Facebook, Twitter, LinkedIn, MySpace, and now Google+ (did I 
miss any?)...

Next question: do you agree that this is the more appropriate place for 
checks for these kinds of services? I think these social networking 
services definitely fall into the category of 'etc' in the comments.

So, I'm thinking we could modify that text to:

# Make sure the email wasn't from a mailing list, an automated message
# from a social networking site, etc; if it was, then we abort after
# appropriate logging.

Then, modify the code appropriately with as many known examples as possible.

There should also be a formal process for us (users) to submit new 
strings for official inclusion, but these should absolutely be approved 
by someone who knows what they are doing and how these code sections in 
vacation.pl actually work.

So, with this in mind, if I modified the above to, say, something like:

     if($address =~ 
/^(noreply|postmaster|mailer\-daemon|listserv|majordomo|owner\-|request\-|bounces\-)/i 
||
         $address =~ /\-(owner|request|bounce|bounces)\@/i ) {
         $logger->debug("sender $address contains $1 - will not send 
vacation message");
         exit(0);
     }

(I simply added 'bounce' before 'bounces')

Would that catch the example I gave from linkedin, since it is 
from=blahblah.bounce.linkedin.com (bounce is singular, not plural)?

Also - is that a 'contains' search? If so, I'm guessing I could remove 
the plural form (bounces), since that would also be matched by 'bounce'?

Again, thanks for taking the time to discuss this, my only goal is to 
make vacation.pl better...

Charles

Re: [Postfixadmin-devel] Request help/comment on Feature Requests-2813224 : End user customization of header strings for vacation

[David G. <da...@co...>]

On 21 Feb 2012, at 11:06, Tanstaafl wrote:

> On 2012-02-19 3:19 PM, Tanstaafl <tan...@li...> wrote:
>> Here is another example of one I just saw go out (was watching the logs
>> for something else):
> 
> This is the line that I want to test for:
> 
>> Feb 19 15:03:26 myhost postfix/qmgr[11885]: CCD158B3D5B:
>> from=<m-g...@bo...>,
>> size=6660, nrcpt=2 (queue active)
> 

No… the filter script is operating on the contents of the email - not the postfix mail log.

I'd suggest you open the linked in email, and view it's source - that's what the filter script runs on.

You could probably just do a regexp on e.g.

elsif(/^X-LinkedIn-/) {
    $logger->debug("linked in spam stuff");
     exit(0);
}

Considering a random email I have here from LinkedIn contains :


Subject: Add skills and expertise like …….
X-LinkedIn-Template: suggested_skills
X-LinkedIn-Class: TIK
X-LinkedIn-fbl: m-vwEVIlxpMe6S2lEblahblahblahblahblahblahblahblahaU4gyFze1CwQBhcj4Nq_
From: LinkedIn <mes...@li...>
Sender: mes...@bo...



If you want to do a match on from, then :

elsif(/^from:\sLinkedIn.*messages-noreply\@linkedin.com.*/i) {
     ….
}

would probably work (I've not tested this); the X-LinkedIn looks easiest to me :) as the from variant is longer.


thanks,

David.

Re: [Postfixadmin-devel] Request help/comment on Feature Requests-2813224 : End user customization of header strings for vacation

[Tanstaafl <tan...@li...>]

On 2012-02-19 3:19 PM, Tanstaafl <tan...@li...> wrote:
> Here is another example of one I just saw go out (was watching the logs
> for something else):

This is the line that I want to test for:

> Feb 19 15:03:26 myhost postfix/qmgr[11885]: CCD158B3D5B:
> from=<m-g...@bo...>,
> size=6660, nrcpt=2 (queue active)

Seeing as it contains a from= (this is the mail-from, not just some 
random from header, right?), I have tried the following, which doesn't 
seem to work:

     elsif (/^from:\s*(.*)\n$/i) {
          $logger->debug("linkedin.com found; exiting");
          exit (0);
      }

I need to know what expression to use for "from:\s*(.*)\n$/i)" to make 
this work so that if the from contains the string 'linkedin.com' 
anywhere, it will exit (0)...

If I can get just one working example, then I can add a new line 
whenever I see one like this that I don't want to respond to.

Appreciate any help anyone can provide...

Re: [Postfixadmin-devel] Request help/comment on Feature Requests-2813224 : End user customization of header strings for vacation

[Tanstaafl <tan...@li...>]

On 2011-12-15 3:27 PM, Christian Boltz <pos...@cb...> wrote:
>> I'd appreciate some comments/replies on this Feature Request for a
>> documented way to easily add new from/mailfrom strings that will cause
>> the vacation message to NOT be sent...
>>
>> I have seen numerous vacation messages sent that should NOT be sent

> Have a look at vacation.pl around line 558 to 569. There are lines like
> (broken into multiple lines for better readability)
>
>      elsif (/^List\-(Id|Post|Unsubscribe):/i) {
>          $logger->debug("List-$1: found; exiting");
>          exit (0);
>      }
>
> You can add similar lines there, for example
>
>      elsif (/^autoresponders-are:\s+evil/i) {
>          $logger->debug("autoresponders-are: evil found; exiting");
>          exit (0);
>      }
>
> would not respond to mails which have this header:
>      Autoresponders-are: evil

Ok, one problem is, I don't usually get these emails, others do, so all 
I have are the log entries, not the full headers - yeah, I could ask the 
user to forward it to me or go look at it, but I'd like to be able to do 
this simply from the log entry, and also not provide a full header 
match, just a 'contains' match, see below...

Here is another example of one I just saw go out (was watching the logs 
for something else):

Feb 19 15:03:25 myhost postfix-25/smtpd[12575]: CCD158B3D5B: 
client=sv4-mta-52b.emailfiltering.com[208.87.137.233]
Feb 19 15:03:26 myhost postfix/cleanup[12580]: CCD158B3D5B: 
message-id=<175...@el...d>
Feb 19 15:03:26 myhost postfix/qmgr[11885]: CCD158B3D5B: 
from=<m-g...@bo...>, 
size=6660, nrcpt=2 (queue active)
Feb 19 15:03:26 myhost postfix/virtual[12581]: CCD158B3D5B: 
to=<val...@me...>, relay=virtual, delay=0.38, 
delays=0.37/0/0/0.01, dsn=2.0.0, status=sent (delivered to maildir)
Feb 19 15:03:26 myhost postfix-25/smtpd[12575]: disconnect from 
sv4-mta-52b.emailfiltering.com[208.87.137.233]
Feb 19 15:03:26 myhost postfix-25/smtpd[12575]: connect from 
myhost.media-brokers.com[127.0.0.1]
Feb 19 15:03:26 myhost postfix-25/smtpd[12575]: 9B082973CC9: 
client=myhost.media-brokers.com[127.0.0.1]
Feb 19 15:03:26 myhost postfix/cleanup[12580]: 9B082973CC9: 
message-id=<201...@me...>
Feb 19 15:03:26 myhost postfix/qmgr[11885]: 9B082973CC9: 
from=<val...@me...>, size=1133, nrcpt=1 (queue active)
Feb 19 15:03:26 myhost postfix-25/smtpd[12575]: disconnect from 
myhost.media-brokers.com[127.0.0.1]
Feb 19 15:03:26 myhost postfix/pipe[12591]: CCD158B3D5B: 
to=<validuser#med...@au...>, 
orig_to=<val...@me...>, relay=vacation, delay=0.92, 
delays=0.37/0.03/0/0.52, dsn=2.0.0, status=sent (delivered via vacation 
service)
Feb 19 15:03:26 myhost postfix/qmgr[11885]: CCD158B3D5B: removed
Feb 19 15:03:27 myhost postfix/qmgr[11885]: 9B082973CC9: removed
Feb 19 15:03:27 myhost postfix/smtp[12594]: 9B082973CC9: 
to=<m-g...@bo...>, 
relay=post52.us.emailfiltering.com[208.87.137.137]:25, delay=1.2, 
delays=0.05/0.01/0.84/0.34, dsn=2.0.0, status=sent (250 accepted 
(1186764686))

What I would like is a simple way to add additional lines to 
vacation.pl, that would - ie, in this case - not respond to anything 
that had 'linkedin.com' *anywhere* (ie, a *contains* filter, not 
requiring an exact match) in the header or mailfrom.

Or, maybe instead of linkedin.com, just anything with 'bounce' anywhere 
in the header or mailfrom (this is only the vacation responder, so I'm 
ok with not replying to some end-case message that maybe should have 
gotten replied to, if it stops all of these that should not get replied 
to)...

Can you help with that constructing a line item for that? Then I could 
simply clone that one and change the string.

Incidentally, the main reason I'm asking for help with this is testing 
it is hard, since it's not like we get these all the time, and nothing 
I've tried so far has worked (blocked these).

But regardless, if I can get one working example, that would be awesome.

Thanks Christian (or anyone else willing to help)!

Charles

Re: [Postfixadmin-devel] Official support for MariaDB?

[Oliver S. <ol...@sc...>]

While I don't want to start a postgres vs mysql thing here, I find them 
to be equally in usage. I've used both and the basic level are nearly 
identical?

On 16-02-12 15:02, Tanstaafl wrote:
> On 2012-02-16 7:57 AM, Oliver Schinagl<ol...@sc...>  wrote:
>> On 02/16/12 13:48, Tanstaafl wrote:
>>> I've been seriously questioning my continuing use of MySQL ever since
>>> Oracle bought Sun, and I'd really like to switch... however, since
>>> postfixadmin is my main use of mysql, I'd rather not do this
>>> unless/until postfixadmin officially adds support for it.
>   >  If not maria, postgresql support is excellent ;)
>
> Yeah, I know, I looked at doing that, but postgresql is *much* more
> difficult to work with (at least, after the couple of hours I played
> with it), and I'm not sure of what I'm doing, whereas I'm comfortable in
> mysql...
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel

Re: [Postfixadmin-devel] Feature Request - move config.local.php location to /etc/postfixadmin

[David G. <da...@co...>]

On 16 Feb 2012, at 21:08, Tanstaafl wrote:

> On 2012-02-16 3:52 PM, David Goodwin <da...@co...> wrote:
>> Hi,
>> 
>> No - your change would not work, as the include path would resolve through to :
>> 
>> 
>> if (file_exists(dirname(__FILE__) '/etc/postfixadmin/config.local.php')) {
>>     include(dirname(__FILE__) '/etc/postfixadmin/config.local.php');
>> 
>> /etc/postfixadmin/etc/postfixadmin/config.local.php or something like that.
>> 
>> You should remove the idrname(__FILE__) bit and it would be fine.
> 
> Ok, but would that be the recommended way?
> 

Yes.


> I'm still confused as to why/how to change this officially so that postfixadmin defaults to using this directory...

You shouldn't need to do anything by default - 

>> if (file_exists(dirname(__FILE__) '/etc/postfixadmin/config.local.php')) {
>>     include(dirname(__FILE__) . '/config.local.php');


Should be the default.


Alternatively, 

>> if (file_exists(dirname(__FILE__) '/etc/postfixadmin/config.local.php')) {
>>     include( '/etc/postfixadmin/config.local.php');




Thanks
David.

Re: [Postfixadmin-devel] Official support for MariaDB?

[Tanstaafl <tan...@li...>]

On 2012-02-16 9:34 AM, David Goodwin <da...@co...> wrote:
> On 16 Feb 2012, at 14:07, Tanstaafl wrote:
>> On 2012-02-16 7:58 AM, David Goodwin<da...@co...>  wrote:
>>> My ignorant understanding is that it really is a drop in replacement
>>> - so no changes are needed on the postfixadmin side - certainly not
>>> yet anyway.
>>>
>>> As in the protocol/php library etc are compatible … so it's just down
>>> to the sysadmin to swap out mysql for mariadb.

>> Ok, if that is true (great to here that it is), then it should be even
>> easier to provide what I was actually asking for - *official* support -
>> ie, mentioning its support specifically in the docs (installation, etc),
>> and in the examples provided in config.inc.php itself…

> Well - if we had reports from someone that it works without any
> changes, then I'd see no reason why not to mention it

Understood, but my request is not about just 'mentioning' it, it is 
about first adopting formal support for it, then eventually dropping 
support for mysql... personally I think it is important to do this 
sooner rather than later, seeing as how Oracle has such a bad reputation 
for destroying the quality of the software they acquire, which is the 
reason for my formal Feature Request...

Re: [Postfixadmin-devel] Official support for MariaDB?

[David G. <da...@co...>]

On 16 Feb 2012, at 14:07, Tanstaafl wrote:

> On 2012-02-16 7:58 AM, David Goodwin <da...@co...> wrote:
>> My ignorant understanding is that it really is a drop in replacement
>> - so no changes are needed on the postfixadmin side - certainly not
>> yet anyway.
>> 
>> As in the protocol/php library etc are compatible … so it's just down
>> to the sysadmin to swap out mysql for mariadb.
> 
> Ok, if that is true (great to here that it is), then it should be even 
> easier to provide what I was actually asking for - *official* support - 
> ie, mentioning its support specifically in the docs (installation, etc), 
> and in the examples provided in config.inc.php itself…

Well - if we had reports from someone that it works without any changes, then I'd see no reason why not to mention it

thanks
David.

Re: [Postfixadmin-devel] Official support for MariaDB?

[Tanstaafl <tan...@li...>]

On 2012-02-16 7:58 AM, David Goodwin <da...@co...> wrote:
> My ignorant understanding is that it really is a drop in replacement
> - so no changes are needed on the postfixadmin side - certainly not
> yet anyway.
>
> As in the protocol/php library etc are compatible … so it's just down
> to the sysadmin to swap out mysql for mariadb.

Ok, if that is true (great to here that it is), then it should be even 
easier to provide what I was actually asking for - *official* support - 
ie, mentioning its support specifically in the docs (installation, etc), 
and in the examples provided in config.inc.php itself...

Re: [Postfixadmin-devel] Official support for MariaDB?

[Tanstaafl <tan...@li...>]

On 2012-02-16 7:57 AM, Oliver Schinagl <ol...@sc...> wrote:
> On 02/16/12 13:48, Tanstaafl wrote:
>> I've been seriously questioning my continuing use of MySQL ever since
>> Oracle bought Sun, and I'd really like to switch... however, since
>> postfixadmin is my main use of mysql, I'd rather not do this
>> unless/until postfixadmin officially adds support for it.

 > If not maria, postgresql support is excellent ;)

Yeah, I know, I looked at doing that, but postgresql is *much* more 
difficult to work with (at least, after the couple of hours I played 
with it), and I'm not sure of what I'm doing, whereas I'm comfortable in 
mysql...

Re: [Postfixadmin-devel] Feature Request - move config.local.php location to /etc/postfixadmin

[Tanstaafl <tan...@li...>]

On 2012-02-16 7:56 AM, David Goodwin <da...@co...> wrote:
> Hi,
>
> dirname(__FILE__) works out the current directory of the file which
> is being executed.
>
> If config.inc.php is already in /etc/postfixadmin (i.e. __FILE__ is
> /etc/postfixadmin/config.inc.php) then dirname(__FILE__) will be set
> to /etc/postfixadmin THEREFORE, it will do as you want - namely load
> /etc/postfixadmin/config.local.php

I have not changed these locations, so they are set to whatever the 
default is.

Currently, config.inc.php is in my working directory (I thought that 
went for everyone?)...

ie:

/var/www/pfa.example.com/htdocs/db_version/config.inc.php

Re: [Postfixadmin-devel] Official support for MariaDB?

[David G. <da...@co...>]

My ignorant understanding is that it really is a drop in replacement - so no changes are needed on the postfixadmin side - certainly not yet anyway.

As in the protocol/php library etc are compatible … so it's just down to the sysadmin to swap out mysql for mariadb.


thanks
David.

Re: [Postfixadmin-devel] Official support for MariaDB?

[Oliver S. <ol...@sc...>]

If not maria, postgresql support is excellent ;)

On 02/16/12 13:48, Tanstaafl wrote:
> Hi all,
>
> (Formal Feature Request link:
>
> https://sourceforge.net/tracker/?func=detail&aid=3488194&group_id=191583&atid=937967)
>
> I've been seriously questioning my continuing use of MySQL ever since
> Oracle bought Sun, and I'd really like to switch... however, since
> postfixadmin is my main use of mysql, I'd rather not do this
> unless/until postfixadmin officially adds support for it.
>
> Are there any existing plans/efforts to do this? From what I've read
> about MariaDB, it is virtually a drop in replacement for MySQL, so I was
> hoping it wouldn't be too difficult to add official support for it, then
> maybe after a certain period, just drop official support for MySQL -
> unless of course the devs are ok with maintaining them both until such
> time as they diverge to the point that maintaining them both becomes too
> much work.
>
> Thanks to all who make postfixadmin the best way to maintain a mail server!
>
> Charles
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel

Re: [Postfixadmin-devel] Feature Request - move config.local.php location to /etc/postfixadmin

[David G. <da...@co...>]

Hi,

dirname(__FILE__) works out the current directory of the file which is being executed.


If config.inc.php is already in /etc/postfixadmin (i.e. __FILE__ is /etc/postfixadmin/config.inc.php) then dirname(__FILE__) will be set to /etc/postfixadmin THEREFORE, it will do as you want - namely load /etc/postfixadmin/config.local.php

thanks
David.

[Postfixadmin-devel] Official support for MariaDB?

[Tanstaafl <tan...@li...>]

Hi all,

(Formal Feature Request link:

https://sourceforge.net/tracker/?func=detail&aid=3488194&group_id=191583&atid=937967)

I've been seriously questioning my continuing use of MySQL ever since 
Oracle bought Sun, and I'd really like to switch... however, since 
postfixadmin is my main use of mysql, I'd rather not do this 
unless/until postfixadmin officially adds support for it.

Are there any existing plans/efforts to do this? From what I've read 
about MariaDB, it is virtually a drop in replacement for MySQL, so I was 
hoping it wouldn't be too difficult to add official support for it, then 
maybe after a certain period, just drop official support for MySQL - 
unless of course the devs are ok with maintaining them both until such 
time as they diverge to the point that maintaining them both becomes too 
much work.

Thanks to all who make postfixadmin the best way to maintain a mail server!

Charles

[Postfixadmin-devel] Feature Request - move config.local.php location to /etc/postfixadmin

[Tanstaafl <tan...@li...>]

Hi all,

I opened this Feature Request a while back:

https://sourceforge.net/tracker/?func=detail&aid=3150300&group_id=191583&atid=937967

I'm fairly certain it is a trivial change - can someone confirm that all 
that is needed is to change the path that is provided at the bottom of 
the config.inc.php file, ie, change:

if (file_exists(dirname(__FILE__) . '/config.local.php')) {
     include(dirname(__FILE__) . '/config.local.php');

to

if (file_exists(dirname(__FILE__) '/etc/postfixadmin/config.local.php')) {
     include(dirname(__FILE__) '/etc/postfixadmin/config.local.php');

I'd rather not test this on a live system without at least a nod from a 
dev that this should be all that is necessary...

So, if the devs agree that this makes sense (since that is one of the 
two default dirs for the custom vacation.conf file already), I'm hoping 
that someone can make this the default for future installs...

Hmmm... just had a thought... why not also add optional support for 
putting the custom vacation.conf settings into config.local.php too? 
That would make things even easier (only one file to worry about when 
changing local settings)... I've actually been bitten twice when I 
forgot to update the vacation.conf file to point to a new database when 
updating... having those settings in the config.local.php file would 
make it virtually impossible to 'forget'...

Thanks all!

Re: [Postfixadmin-devel] attached files for bulk folder

[Sonam P. <s_p...@ru...>]

Hello,
Thank you and I look forward for more recommendations and comments. I 
will upload the files once I incorporate all the suggestions and comments.

Sonam

On 2/9/2012 4:15 AM, Christian Boltz wrote:
> Hello,
>
> Am Mittwoch, 8. Februar 2012 schrieb Sonam Penjor:
>> I am attaching the complete files that I have been working on the bulk
>> email creation for the review.
> Thanks a lot!
>
>> Should you have any inquiries  on the
>> attached files, I would be happy to explain.
>>
>> I will appreciate for the comments, advices and recommendations.
> You will regret this offer ;-))
>
>
> Some questions first:
>
> - Do you have some example CSV files I could use for testing?
>    (That would be easier than creating them myself ;-)
>    Bonus points if you also have some CSV files with invalid data
>    (duplicate usernames, invalid mail addresses, whatever)
> - what's the biggest (in number of lines) CSV file you tested?
> - some documentation/description how the CSV file should look like
>    (allowed columns etc.) would be useful. I'd even place it next to the
>    form in the template file.
> - did I get it right that your only modification to en.lang is the
>    addition of 14 texts after this comment:
>    /* Newly added for the uploading Bulk email ID */
>    (just to avoid I overlooked something, it seems en.lang got some
>    changes since you copied it)
>    I'm attaching an updated en.lang - if you have to do more changes,
>    add more texts etc. please use the attached en.lang as base.
>
> Now to some notes on your code:
> - please don't play around with error_reporting - there's a good reason
>    I have a very strict setting for it on my development machine ;-)
>    I know notices can be annoying sometimes, but often they help to find
>    bugs like typos in a variable name which would be hard to find
>    otherwise
> - your class needs to be named model/UploadCsvFile.php - otherwise the
>    autoloader won't find it
> - better error handling would be nice. For example, if I upload an
>    invalid csv file, I get (only) an error message "Invalid Delimiter".
>    It would be better to display the error message using flash_error()
>    and to display the form again
> - the "Invalid Delimiter" error message seems to be misleading - I
>    uploaded a file with the correct delimiter but wrong column headers
>    (first line: "a,b,c,d") and it complained about "Invalid Delimiter".
>    From reading the code, I'd say you should print out the error message
>    you get from scanCsvfile() instead of just checking for failure.
> - I have attached a patch for create-bulkmailbox.php and
>    model/UploadCsvFile.php with some small changes and inline notes -
>    that's easier than including them in the mail. I also attached the
>    modified files, but reading the patches is probably easier.
> - in the class, please explicitely mark the functions as private or
>    public
>
> So much for the first review ;-)
> The above is what I noticed when reading the code. I didn't test much
> (except with an invalid CSV file ;-)  yet, but the above and the inline
> comments will already give you several ideas what you can improve ;-)
>
> And finally: I hope you aren't shocked too much about all the things I
> found in your code ;-))
>
>
> Regards,
>
> Christian Boltz
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
>
>
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Postfixadmin-devel] attached files for bulk folder

[Christian B. <pos...@cb...>]

Hello,

Am Mittwoch, 8. Februar 2012 schrieb Sonam Penjor:
> I am attaching the complete files that I have been working on the bulk
> email creation for the review. 

Thanks a lot!

> Should you have any inquiries  on the
> attached files, I would be happy to explain.
>
> I will appreciate for the comments, advices and recommendations.

You will regret this offer ;-))


Some questions first:

- Do you have some example CSV files I could use for testing? 
  (That would be easier than creating them myself ;-)
  Bonus points if you also have some CSV files with invalid data 
  (duplicate usernames, invalid mail addresses, whatever)
- what's the biggest (in number of lines) CSV file you tested?
- some documentation/description how the CSV file should look like
  (allowed columns etc.) would be useful. I'd even place it next to the
  form in the template file.
- did I get it right that your only modification to en.lang is the 
  addition of 14 texts after this comment:
  /* Newly added for the uploading Bulk email ID */
  (just to avoid I overlooked something, it seems en.lang got some
  changes since you copied it)
  I'm attaching an updated en.lang - if you have to do more changes,
  add more texts etc. please use the attached en.lang as base.

Now to some notes on your code:
- please don't play around with error_reporting - there's a good reason
  I have a very strict setting for it on my development machine ;-)
  I know notices can be annoying sometimes, but often they help to find 
  bugs like typos in a variable name which would be hard to find 
  otherwise
- your class needs to be named model/UploadCsvFile.php - otherwise the
  autoloader won't find it
- better error handling would be nice. For example, if I upload an
  invalid csv file, I get (only) an error message "Invalid Delimiter".
  It would be better to display the error message using flash_error()
  and to display the form again
- the "Invalid Delimiter" error message seems to be misleading - I 
  uploaded a file with the correct delimiter but wrong column headers 
  (first line: "a,b,c,d") and it complained about "Invalid Delimiter".
  From reading the code, I'd say you should print out the error message 
  you get from scanCsvfile() instead of just checking for failure.
- I have attached a patch for create-bulkmailbox.php and 
  model/UploadCsvFile.php with some small changes and inline notes - 
  that's easier than including them in the mail. I also attached the 
  modified files, but reading the patches is probably easier.
- in the class, please explicitely mark the functions as private or
  public

So much for the first review ;-)
The above is what I noticed when reading the code. I didn't test much 
(except with an invalid CSV file ;-)  yet, but the above and the inline 
comments will already give you several ideas what you can improve ;-)

And finally: I hope you aren't shocked too much about all the things I 
found in your code ;-))


Regards,

Christian Boltz
-- 
As usual, I'm voicing my opinion on this topic, not announcing "truth" 
;)
[Cristian Rodríguez in opensuse-factory]

[Postfixadmin-devel] attached files for bulk folder

[Sonam P. <s_p...@ru...>]

Hi,

I am attaching the complete files that I have been working on the bulk 
email creation for the review. Should you have any inquiries  on the 
attached files, I would be happy to explain.

I will appreciate for the comments, advices and recommendations.

Thank You

Sonam Penjor



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Postfixadmin-devel] final request for Creating Bulk email ID

[Christian B. <pos...@cb...>]

Hello,

sorry for not responding earlier - I was on vacation and then had some 
"fun" with crashing harddisks on a server...

Am Dienstag, 17. Januar 2012 schrieb Sonam Penjor:
> This is my last and final part of my bulk email uploading. I was just
> thinking whether it is really important to change character set
> encoding  as I am using data to be uploaded from CSV file. If so then,
> should I update column wise or table wise.

I'd ignore the charset for now and wait what happens ;-)

If you really want to implement charset handling, then you'll probably 
need a selectbox on the upload page:
    the uploaded file is encoded as [ choose your encoding   v ]
But as I said: I'd try without it first ;-)

> I was also wondering how to upload the my source code for the review.

That depends:
- if you modified existing files, please provide your changes as a patch 
  (easiest way: "svn diff > bulk-creation.diff").
- if you created new files, well, then we obviously need the complete 
  files ;-)

Depending on the number of changed and added files, you can put 
everything (patch + new files) in a tar.gz or zip - or not.

For the upload itsself, you can 
- append everything to a mail to this mailinglist   - or -
- choose the more formal way by creating a new item in the patches 
  tracker on sf.net/projects/postfixadmin and upload your file(s) there. 

For the records: You can only upload files to tracker items you created 
yourself, which is a somewhat annoying limitation on sourceforge.


Regards,

Christian Boltz
-- 
Such mal im Archiv dieser Liste nach 'reiserfs',  oder genauer,
nach 'rasierfs' und 'reisswolffs'. Reiserfs reagiert auf Fehler
(diverser Art) wie ne Diva...      [David Haller in suse-linux]

[Postfixadmin-devel] Undefined Index Notices

[Jens A. T. <je...@pe...>]

Hello,

i am using latest postfixadmin from SVN.

I get these notices:

Notice: Undefined index: maxquota in 
/srv/www/htdocs/tools/postfixadmin/list-virtual.php on line 297

Notice: Undefined index: tAliasDomains in 
/srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
on line 40
Notice: Trying to get property of non-object in 
/srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
on line 40
Notice: Undefined index: tTargetDomain in 
/srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
on line 40
Notice: Trying to get property of non-object in 
/srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
on line 40


Kind regards,

Jens

[Postfixadmin-devel] More Undefined Index Notices

[Jens A. T. <je...@pe...>]

Sorry,

forgot:

Notice: Undefined index: pPassword_password_current_text in 
/srv/www/htdocs/tools/postfixadmin/templates_c/122e9467d550572b97deb3e833b7fd3b5509646d.file.password.tpl.php 
on line 48 Notice: Trying to get property of non-object in 
/srv/www/htdocs/tools/postfixadmin/templates_c/122e9467d550572b97deb3e833b7fd3b5509646d.file.password.tpl.php 
on line 48


Notice: Undefined index: pPassword_password_text in 
/srv/www/htdocs/tools/postfixadmin/templates_c/122e9467d550572b97deb3e833b7fd3b5509646d.file.password.tpl.php 
on line 55 Notice: Trying to get property of non-object in 
/srv/www/htdocs/tools/postfixadmin/templates_c/122e9467d550572b97deb3e833b7fd3b5509646d.file.password.tpl.php 
on line 55

Language: German



Am 31.01.2012 18:41, schrieb Jens A. Tkotz:
> Hello,
>
> i am using latest postfixadmin from SVN.
>
> I get these notices:
>
> Notice: Undefined index: maxquota in 
> /srv/www/htdocs/tools/postfixadmin/list-virtual.php on line 297
>
> Notice: Undefined index: tAliasDomains in 
> /srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
> on line 40
> Notice: Trying to get property of non-object in 
> /srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
> on line 40
> Notice: Undefined index: tTargetDomain in 
> /srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
> on line 40
> Notice: Trying to get property of non-object in 
> /srv/www/htdocs/tools/postfixadmin/templates_c/22c4db683017d8b15b91e0bbf600e1e851a486b3.file.list-virtual_alias_domain.tpl.php 
> on line 40
>
>
> Kind regards,
>
> Jens

Re: [Postfixadmin-devel] apology

[Tanstaafl <tan...@li...>]

On 2012-01-24 10:53 PM, Sonam Penjor <s_p...@ru...> wrote:
> My sincere apology for creating confusion by posting my message under
> different threads.
>
> I will take extra care in future to avoid such misunderstanding.....

No problem, and sorry if my response was a bit harsh...

[Postfixadmin-devel] apology

[Sonam P. <s_p...@ru...>]

> Please do not hijack threads...
>
> Post a *new* message (do NOT reply to an existing one and just change
> the subject), and use a *meaningful* subject...
My sincere apology for creating confusion by posting my message under 
different threads.

I will take extra care in future to avoid such misunderstanding.....
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Postfixadmin-devel mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postfixadmin-devel
>


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.