Re: [Postfixadmin-devel] Bug in v3.0 vacation module

[Ullrich v. B. <uz...@mu...>]

[Send this email to Christian not realizing that the emails from the list
don't have a Reply-To header that points to the list. I'll try to be more
careful in the future.]

Good morning!

On Thu, Dec 22, 2016 at 01:23:32AM +0100, Christian Boltz wrote:
> Which database do you use? MySQL, PostgreSQL or SQLite?
> (I'd guess PostgreSQL ;-)

I have both, a postgresql setup for production and a mysql setup for testing.
The new vacation module works with the mysql setup without problems. I haven't
changed anything in the mysql installation, so I don't know if strict mode is
enabled or not.

> I'm asking because I'm quite sure [1] your patch broke the vacation
> module for MySQL users, at least those using strict mode. The "cache"
> column is a text (not varchar) field which doesn't allow to define a
> default value, therefore we need to specify a value as long as this
> column exists.

The existing vacation module does definitely not work with postgres. With my
patch, it works with postgres and with mysql (maybe not in strict mode). So I
would say, it's at least an improvement :)

> Opinions? ;-)

If the only purpose of the column is to let people run older versions of the
vacation module, then I would definitely suggest to drop it. Keeping old cruft
like this in each version will kill you in the long run. That's my two cent.
Your opinion may of course be different. :)

Regards


        Uz


-- 
Ullrich von Bassewitz                                  uz...@mu...
Encrypted email preferred                          PGP Key-Id: 29D93B10