[ postfixadmin-Patches-3508083 ] vacation with choice of reply

[SourceForge.net <no...@so...>]

Patches item #3508083, was opened at 2012-03-18 14:16
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3508083&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
>Status: Open
>Resolution: None
Priority: 5
Private: No
Submitted By: J.Kruis (jan-kruis)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation with choice of reply

Initial Comment:
This patch provides users and administrators the ability to choose between three types of reply.

one reply
autoreply
reply with delay

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-08-01 15:02

Message:
I know I'm late ;-) but unfortunately your patch contains several issues
:-(
(and you are lucky that David already commited it - I would have rejected
it in the current state ;-)


The patch introduces two unrelated (and unused?) config options:
$CONF['usercontol'] and $CONF['users_domain_controle'] which aren't used.

$CONF['vacation_replytype_control'] and $CONF['vacation_allow_user_reply']
aren't used/checked (the fields are always displayed)

the texts for $CONF['choice_of_reply'] are hardcoded in several places -
does it really make sense to make them configurable? (Besides that, I'd
prefer to have them translateable.)

if I get the comment in vacation.pl right, only the reply interval is
checked ( 0 = onereply, 1 = autoreply, >1 = Delay reply ) - what's the
reason for storing the "reply_type" as text in the database? It looks
superfluous to me.

(BTW: Does it really make sense to let the user enter the interval? IMHO
providing the dropdown with some options would be enough, but I don't know
your usecase.)

upgrade_1345_mysql should use the _db_add_field() function of upgrade.php

the upgrade for postgresql users is missing (hint: _db_add_field() can
cover both)

in vacation.pl, the interval stored in the database silently overrides the
config option $interval - this might make sense, but it should at least be
documented (and/or the config option removed)


Can you please provide an additional patch to solve those issues?

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2012-04-19 14:56

Message:
Thank you for the patch; I've not tested it yet.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3508083&group_id=191583