[ postfixadmin-Patches-3523124 ] Enhance XMLRPC support.

[SourceForge.net <no...@so...>]

Patches item #3523124, was opened at 2012-05-02 15:18
Message generated for change (Comment added) made by norm_brandinger
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3523124&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Vacation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Norm Brandinger (norm_brandinger)
Assigned to: Nobody/Anonymous (nobody)
Summary: Enhance XMLRPC support.

Initial Comment:
xmlrpc.php:

Add support for reply_type, interval_time, activeFrom, activeUntil for the set_away() function.
Update returned variable names in other function calls so they match dh->init() calls.

functions.inc.php:

Add authentication support for $_SESSION['username']

----------------------------------------------------------------------

>Comment By: Norm Brandinger (norm_brandinger)
Date: 2012-05-30 10:32

Message:
The motivation for this patch, along with some other updates that I haven't
submitted yet is to get the squirrelmail postfixadmin plugin operational. 
Note that at this time I do have full integration between postfixadmin and
squirrelmail using the XMLRPC interface.

I suppose that the extra parameters (or perhaps all of the parameters) for
setAway() can have default values.  That would make the call more backward
compatible.

For example:

public function setAway($subject, $body, $reply_type="Auto_Reply",
$interval_time=86400,
$activeFrom="2000-01-01 00:00:00", $activeUntil="2500-12-31 23:59:59") {

The reason for adding $_SESSION['username'] was to fix an authentication
problem. On this debian system implementation, both postfixadmin AND
squirrelmail are co-resident (which is what I think is the root of the
problem).  The first XMLRPC call appeared to succeed but subsequent calls
failed with authorization errors.

I'm running: PHP 5.3.3-7+squeeze9 with Suhosin-Patch (cli) (built: May  8
2012 10:41:34) with a mostly standard php.ini file.

Regards,
Norm

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2012-05-27 10:40

Message:
From the xmlrpc.php patch:

-    public function setAway($subject, $body) {
+    public function setAway($subject, $body, $reply_type, $interval_time,
$activeFrom, $activeUntil) {

I'm not sure if changing the xmlrpc interface is a good idea - what happens
if an "old" client connects and only provides subject and body?

David, what's your opinion on this?

(see also the recent discussion on the mailinglist - maybe we'll (have to)
add another parameter for the realname)


> functions.inc.php:
>
> Add authentication support for $_SESSION['username']

Norm, what's the reason for / advantage of this change? (it seems unrelated
to the xmlrpc interface)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3523124&group_id=191583