[ postfixadmin-Bugs-3502195 ] UTF-8 string display problem

[SourceForge.net <no...@so...>]

Bugs item #3502195, was opened at 2012-03-11 16:24
Message generated for change (Settings changed) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3502195&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface (example)
Group: v2.3.5
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Laddobar (laddobar)
Assigned to: Nobody/Anonymous (nobody)
Summary: UTF-8 string display problem

Initial Comment:
In two places (as I discovered so far) PA has trouble displaying UTF-8 characters - in both cases these are "description" fields. From the superadmin point of view:
- description of the domain when listing all the domains in /postfixadmin/list-domain.php
- name of the mailbox owner when listing aliases and mailboxes of a domain in /postfixadmin/list-virtual.php?domain=example.com

I found the problem in the usage of HTMLEntities function, which is missing the encoding parameter.
Change in templates admin_list-domain.php and list_virtual.php seems sufficient:
original: print "<td>" . htmlentities($domain_properties[$i]['description']) . "</td>";
resolved:  print "<td>" . htmlentities($domain_properties[$i]['description'],ENT_QUOTES,'UTF-8') . "</td>";

Thanks for your good work!
Laddobar

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2012-03-12 17:26

Message:
That's a known regression in 2.3.5 :-( - but it's still better than the XSS
issues those files had before.

I already fixed it in SVN, but just that fix isn't worth a new release
IMHO. If you need the fixed files, you can download them directly from SVN
at
http://postfixadmin.svn.sourceforge.net/viewvc/postfixadmin/branches/postfixadmin-2.3/templates/
or apply the patch that I'll attach to this bugreport.

And BTW, you found both places that are affected by this bug ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3502195&group_id=191583