Re: [Postfixadmin-devel] fetchmail support

[Christian B. <pos...@cb...>]

Hello,

as you might have seen, I have done some changes on fetchmail.php and=20
fetchmail.tpl tonight.

Status:
=2D all SQL queries use escape_string
=2D the layout now looks more postfixadmin-like :-)  (separate editing=20
  page instead of "embedding" it in the list view)
=2D no more "undefined index" warnings (see below)
=2D known bug: adding a new entry is totally broken right now :-(  -=20
  probably I applied too much quoting to the SQL query...
=2D ToDo: insert a domain dropdown to only display fetchmail setup of a=20
  specific domain
=2D ToDo: fetchmail.php and fetchmail.tpl contain lots of tabs which need=20
  to be converted to spaces. I'll do a separate commit just for these=20
  whitespace changes.

Note 1:
=46eel free to use the safeget/safepost/safeserver functions at other=20
places too ;-)

    $var =3D safeget('var');
is easier to use than
    $var =3D "";
    if (isset($_GET['var'])) $var =3D $_GET['var'];

Optionally you can specify a default value which will be returned if the=20
$_GET variable is not set:
    $var =3D safeget('var', 'default');


Note 2:
$fm_struct in fetchmail.php is a really useful array once you understand=20
how to use it. We should consider to use similar arrays for the other=20
tables (something for after the 2.2 release).


Regards,

Christian Boltz
=2D-=20
PS: Achja, Du schuldest mir eine neue Tischplatte... Warum mu=DFte ich=20
heute morgen nur den SuSE-Ordner =F6ffnen? [Helga Fischer in suse-linux]