|
From: David G. <da...@co...> - 2007-10-09 06:19:09
|
> > > Would be an idea. However, we'll need a way to handle existing > > > unencrypted passwords. > > > > That could be done through some sort of generic 'upgrade' script - > > which it appears we'll need.... >=20 > Let's declare this problem minor when compared with database updates in= =20 > general ;-) Indeed, and that specific problem is a non-issue now anyway. > > > > My grievance with this is that when ever an admin is edited, I > > > > think your previous patch, implied that a users password had to > > > > be changed/set. Which is horrible. > > > > > > No, the password does not need to be touched. See my change in > > > r123: > > > > OK. >=20 > Will you commit this or shall I do it? I've made the change in my checked out copy, but need to test it (I didn't get a chance last night). So, if you beat me to it, so be it. > > > > Well, we could always bundle mdb2 / pear db with postfixadmin - this > > would remove any requirement for admins to set it up etc. >=20 > I'd like to split this to two questions: > a) do we want to use a database abstraction layer? > b) which one >=20 > a) Well, if there's a good and lightweight one available... >=20 > Let's sum up our database usage: > - INSERT and UPDATE queries > - DELETE queries > - SELECT queries with WHERE and LIMIT > - begin/end transaction > (did I miss something?) >=20 > So for me the question is if we need a full-featured abstraction layer=20 > or only some simple functions that generate the query. >=20 > If the abstraction layer adds some hundred kB to the tarball, then we=20 > need really good arguments for it IMHO ;-) =20 I'm not particuarly bothered by the 'size of the tarball' issue. Hundreds of kb are pretty in significant. My requirements are : 1) Support for prepared statements 2) Support for a url-like database connection (postfixadmin doesn't (yet) use sequences, so I think these are a non issue - but normally something an abstraction layer handles) > b) Good question... >=20 > Candidates are: (feel free to add missing ones) > - mdb2 (requires PEAR, together 420k as .tar.gz) Most people will already have PEAR. Did you include a specific driver in this figure? > - pear db (http://pear.php.net/package/DB says it is obsolete and mdb2=20 > should be used) > - adodb (470 kB .tar.gz) (proposed by Viktor Gotwig) > - adodb lite (370 kB .tar.gz) Not used adodb. > - the S9Y (www.s9y.org) database routines, which are simple > (only 8 kB .tar.gz) but effective. > If you want to have a look at it: > http://php-blog.cvs.sourceforge.net/php-blog/serendipity/include/db/ I'll try and take a look later; my web browser seems to be acting up at the moment for some unknown reason :-/ David. --=20 David Goodwin=20 [ david at codepoets dot co dot uk ] [ http://www.codepoets.co.uk ] |
