[ postfixadmin-Bugs-3421296 ] patch for sf: 1861812

[SourceForge.net <no...@so...>]

Bugs item #3421296, was opened at 2011-10-10 22:22
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3421296&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Interface (example)
Group: SVN (please specify revision!)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dale Blount (lnxus)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch for sf: 1861812

Initial Comment:
Since I can't seem to figure out how to attach this to ID 1861812, I'll attach it here.

This adds allowed_quota() calls around every $tQuota in create-mailbox.php

Tested a number of cases and it appears to behave fine for me.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-10-11 00:08

Message:
Since you didn't respond on #postfixadmin, I'll paste my questions/feedback
here:

[23:23] <cboltz> supa_user: I'm just reading your patch
[23:23] <cboltz> and found something that looks like a bug to me
[23:24] <cboltz> you should probably use = allowed_quota($fDomain, 0)
everywhere
[23:24] <cboltz> because a not-yet created mailbox does not use any quota
yet ;-)
[23:27] <cboltz> I also think you should not change the "$tQuota =
$fQuota" in line 139
[23:27] <cboltz> because that line is meant to give the user the values he
entered so he can correct them
[23:28] <cboltz> IMHO it shouldn't be changed magically
[23:29] <cboltz> (we also don't change other fields if they contain
invalid values)
[23:30] <cboltz> do you agree or did I overlook something? ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3421296&group_id=191583