|
From: SourceForge.net <no...@so...> - 2011-06-20 12:38:48
|
Bugs item #3047744, was opened at 2010-08-18 15:26 Message generated for change (Comment added) made by maharaja You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3047744&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Vacation Group: SVN (please specify revision!) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Colin Viebrock (cviebrock) Assigned to: Nobody/Anonymous (nobody) Summary: Vacation removal doesn't clear out old notifications Initial Comment: When you turn off vacation, PFA doesn't remove the list of people who were notified. The next time you enable vacation, those people won't receive the new notifications. The solution (I think) is to clear the list of notifications each time vacation is enabled. Here's a patch to do that against SVN rev. 856. ---------------------------------------------------------------------- Comment By: maharaja (maharaja) Date: 2011-06-20 14:38 Message: other possible solutions include: 1. re-notify if notified_at < activefrom 2. use vacation.pl to delete all vacation_notified entries where notified_at < activefrom btw - this should happen even if interval = 0 ! ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2010-08-22 23:37 Message: I just had a quick look at the code - there's already a DELETE query in line 121 (2.3 branch) / line 126 (trunk) that should in theory do that. Your bugreport shows that practise seems to be different ;-) - we'll have to check that... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3047744&group_id=191583 |
