|
From: SourceForge.net <no...@so...> - 2011-04-10 14:36:49
|
Bugs item #2958698, was opened at 2010-02-25 14:29 Message generated for change (Comment added) made by mrfrenzy You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2958698&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core Group: v 2.3 Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Pierre Fagrell (mrfrenzy) Assigned to: Nobody/Anonymous (nobody) Summary: Generated passwords are all lowercase and ignore passlength Initial Comment: Autogenerated passwords are all lowercase and 8 characters long regardless of $CONF['min_password_length']. Attached patch creates a password equal in lenght to min_password_length, using numbers, upper and lowercase letters. ---------------------------------------------------------------------- Comment By: Pierre Fagrell (mrfrenzy) Date: 2011-04-10 16:36 Message: Thanks! I never got around to resubmitting the patch, and since it was working I had forgotten about this until today. ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2011-04-10 16:32 Message: I finally found some time to manually apply your patch. I also did some small modifications to your code to avoid the additional parameter (generate_password() can read $CONF itself) and replaced $i with usage of strlen(). Commited to SVN r1026 (trunk) and r1027 (2.3 branch). ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2010-03-02 16:18 Message: Thanks for the patch. Unfortunately I get an error message when applying it: patch: **** unexpected end of file in patch at line 49 Can you please re-attach it in unified format (diff -u)? BTW: I'd prefer to make the parameter of generate_password optional instead of changing each file that calls it, but that are details ;-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2958698&group_id=191583 |
