Re: [Postfixadmin-devel] 2.3.3 release?

[Christian B. <pos...@cb...>]

Hello,

Am Sonntag, 6. März 2011 schrieb Rudi Floren:
> look at rev. 981
> I think i have fixed the logging problem.

Yes, but that's SVN trunk.

Your change is very good as long-term solution, but too intrusive for 
backporting it to the 2.3 branch IMHO.

@Tanstaafl: The change basically is to drop large parts of 
edit-vacation.php and use the code from model/VacationHandler (which is 
already used by users/vacation.php).

I had a look at the 2.3 code and added code to fix
    3148692 - Modifying a users vacation as admin is not logged
The changes were not too difficult, and should not cause any 
regressions.

If you want to test my changes, try SVN r987 from the 2.3 branch.

Be warned that 
    3148694 - Modifying a users vacation as user is DOUBLE logged
also applies to the code I added - I'd say that's better than no 
logging ;-)
See my comment in the bugreport for the technical details.


Regards,

Christian Boltz
-- 
Nein, es geht nicht um eine Sammlung von Pornobildern. Ich sag's
lieber gleich, weil die Leute immer breit grinsen, wenn ich von
"vielen winzigen Dateien" spreche. :-))) 
[Ratti in suse-linux über seine Fontsammlung]