[ postfixadmin-Bugs-3161493 ] create mailbox: use call_user_func

[SourceForge.net <no...@so...>]

Bugs item #3161493, was opened at 2011-01-19 08:11
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3161493&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: v2.3.2
Status: Open
Resolution: None
>Priority: 5
Private: No
Submitted By: Bilal Ahmed (bilalalig)
Assigned to: Nobody/Anonymous (nobody)
>Summary: create mailbox: use call_user_func

Initial Comment:
Dear Sir,
create-mailbox.php has an error at line no 162 that has a if statement 

if($CONF['maildir_name_hook'] != 'NO' && function_exists($CONF['maildir_name_hook'])) {
  $hook_func = $CONF['maildir_name_hook'];
  $maildir = $hook_func ($fDomain, $fUsername);
}

that should be changed as below

if($CONF['maildir_name_hook'] != 'NO' && function_exists('maildir_name_hook')) {
   $maildir = call_user_func('maildir_name_hook', $fDomain, $fUsername);
}

Thanks
Bilal Ahmed


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2011-02-17 20:33

Message:
I wouldn't call this an error with highest priority (= release blocker) ;-)
- it's just another (maybe not-so-good, but working) method to call the
user function.

Nevertheless, thanks for pointing this out!

I just see on http://de.php.net/call_user_func a user comment (from Dec
2008) saying 
"<?php call_user_func()?> and <?php call_user_func_array()?> hide some
errors (notices, warnings and maybe errors), even if is display_errors
turned on and error_Reporting is set to E_ALL|E_STRICT"

This doesn't sound like what we want. I'll have to test the behaviour of
call_user_func() regarding error messages before changing the code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3161493&group_id=191583