|
From: Christian B. <pos...@cb...> - 2011-02-13 15:47:09
|
Hello,
I found a newly introduced bug when reviewing your changes ;-)
Am Dienstag, 8. Februar 2011 schrieb Gin...@us...:
> Revision: 952
> Author: GingerDog
> move this to common.php; i dislike inline php in templates
>
> Modified Paths:
> --------------
> trunk/templates/header.tpl
>
> Modified: trunk/templates/header.tpl
> ===================================================================
> --- trunk/templates/header.tpl 2011-02-07 23:30:17 UTC (rev 951)
> +++ trunk/templates/header.tpl 2011-02-07 23:30:46 UTC (rev 952)
> @@ -39,6 +39,5 @@
> {/foreach}
> </ul>
> {/if}
> - {php}$_SESSION['flash'] = array();{/php}
> {/if}
> {/strip}
(+ similar, but not equal code added to common.php in r953)
Unfortunately this change broak the flash messages. Or, to be exact, it
broke the cleanup of them ;-)
At the moment we have no code that cleans up the flash messages after
they have been printed out. The result is that the flash messages are
kept until you log out (instead of being displayed only once).
What we need is (pseudocode):
- assign flash messages to a smarty variable/array
- cleanup $_SESSION['flash']
Regards,
Christian Boltz
--
MSCE
Führerschein für die Maus. (Thore Tams)
|
